[vm/concurrency] Remove Dart_IsolateFlags.entry_points / Dart_QualifiedFunctionName from Dart C API
This CL removes the unused entry points in the C API. This is a breaking API change but we don't promise normal Dart C API stability and existing known embedders don't specify this flag. TEST=Pure refactoring - relying on existing test coverage. Issue https://github.com/dart-lang/sdk/issues/36097 Change-Id: Ic27662743e48f5f5cfbf770baf2cd255ed3f15b5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177121 Reviewed-by: Alexander Aprelev <aam@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com>
This commit is contained in:
@@ -759,10 +759,6 @@ static void CreateAndWritePrecompiledSnapshot() {
|
||||
}
|
||||
}
|
||||
|
||||
static Dart_QualifiedFunctionName no_entry_points[] = {
|
||||
{NULL, NULL, NULL} // Must be terminated with NULL entries.
|
||||
};
|
||||
|
||||
static int CreateIsolateAndSnapshot(const CommandLineOptions& inputs) {
|
||||
uint8_t* kernel_buffer = NULL;
|
||||
intptr_t kernel_buffer_size = 0;
|
||||
@@ -775,7 +771,6 @@ static int CreateIsolateAndSnapshot(const CommandLineOptions& inputs) {
|
||||
kernel_buffer, kernel_buffer_size);
|
||||
if (IsSnapshottingForPrecompilation()) {
|
||||
isolate_flags.obfuscate = obfuscate;
|
||||
isolate_flags.entry_points = no_entry_points;
|
||||
}
|
||||
|
||||
auto isolate_group_data = std::unique_ptr<IsolateGroupData>(
|
||||
|
||||
@@ -588,12 +588,6 @@ DART_EXPORT void Dart_UpdateFinalizableExternalSize(
|
||||
*/
|
||||
DART_EXPORT const char* Dart_VersionString();
|
||||
|
||||
typedef struct {
|
||||
const char* library_uri;
|
||||
const char* class_name;
|
||||
const char* function_name;
|
||||
} Dart_QualifiedFunctionName;
|
||||
|
||||
/**
|
||||
* Isolate specific flags are set when creating a new isolate using the
|
||||
* Dart_IsolateFlags structure.
|
||||
@@ -610,7 +604,6 @@ typedef struct {
|
||||
bool use_field_guards;
|
||||
bool use_osr;
|
||||
bool obfuscate;
|
||||
Dart_QualifiedFunctionName* entry_points;
|
||||
bool load_vmservice_library;
|
||||
bool copy_parent_code;
|
||||
bool null_safety;
|
||||
|
||||
@@ -1533,7 +1533,6 @@ void Isolate::FlagsInitialize(Dart_IsolateFlags* api_flags) {
|
||||
api_flags->isolate_flag = flag;
|
||||
BOOL_ISOLATE_FLAG_LIST(INIT_FROM_FLAG)
|
||||
#undef INIT_FROM_FLAG
|
||||
api_flags->entry_points = NULL;
|
||||
api_flags->copy_parent_code = false;
|
||||
}
|
||||
|
||||
@@ -1543,7 +1542,6 @@ void Isolate::FlagsCopyTo(Dart_IsolateFlags* api_flags) const {
|
||||
api_flags->isolate_flag = name();
|
||||
BOOL_ISOLATE_FLAG_LIST(INIT_FROM_FIELD)
|
||||
#undef INIT_FROM_FIELD
|
||||
api_flags->entry_points = NULL;
|
||||
api_flags->copy_parent_code = false;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user