dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

dart2js cps: Eliminate unary string concatenation.

Browse Source 
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org/1563983002 .
This commit is contained in:
Asger Feldthaus
2016-01-06 16:18:00 -08:00
parent 47461f8d2c
commit eadb59e4c1
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/compiler/lib/src/cps_ir/type_propagation.dart
+5
View File
@@ -2073,6 +2073,11 @@ class TransformingVisitor extends DeepRecursiveVisitor {
if (argumentsWereRemoved) {
node.arguments.removeWhere((ref) => ref == null);
}
if (node.arguments.length == 1) {
Primitive input = node.arguments[0].definition;
node.replaceUsesWith(input);
input.useElementAsHint(node.hint);
}
// TODO(asgerf): Rebalance nested StringConcats that arise from
// rewriting the + operator to StringConcat.
break;
tests/compiler/dart2js/js_backend_cps_ir_operators_test.dart
+2 -3
View File
@@ -130,11 +130,10 @@ main() {
print(list);
}""", r"""
function() {
var list = [1, 2, 3], res, v0;
var list = [1, 2, 3], v0;
list[1] = 6;
if (!(typeof (res = C.JSArray_methods.toString$0(list)) === "string"))
if (!(typeof (v0 = P.IterableBase_iterableToFullString(list, "[", "]")) === "string"))
throw H.wrapException(H.argumentErrorValue(list));
v0 = res;
if (typeof dartPrint == "function")
dartPrint(v0);
else if (typeof console == "object" && typeof console.log != "undefined")