Clarify risk and multiple channel CLs in cherry-pick request template.
Clarify the same CP request can be used for both beta and stable and make more room for doing so, as well as including a whole list of changelists to be cherry-picked for complicated cases. Clarify distinct gerrit CLs are needed for beta and stable. Replace the informationless risk field that everyone says is low with a mandatory question to explain the actual risk involved. Fixes: b/329611671 Change-Id: Ibfb81d89722c237e4b8a531bcac2d475798369b7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357603 Commit-Queue: Jonas Termansen <sortie@google.com> Reviewed-by: Kevin Chisholm <kevinjchisholm@google.com>
This commit is contained in:
committed by
Commit Queue
parent
3545100e32
commit
d7ee76326d
@@ -8,25 +8,25 @@ assignees:
|
||||
- vsmenon
|
||||
- itsjustkevin
|
||||
body:
|
||||
- type: input
|
||||
- type: textarea
|
||||
id: commit_hash
|
||||
attributes:
|
||||
label: Commit(s) to merge
|
||||
description: What are the commit hash(es) that have been merged to main?
|
||||
description: What are the changelist(s) that have been merged to main?
|
||||
validations:
|
||||
required: true
|
||||
- type: input
|
||||
id: target
|
||||
attributes:
|
||||
label: Target
|
||||
description: Should this be cherry-picked to beta, stable or both?
|
||||
description: Should the changes be cherry-picked to beta, stable, or both?
|
||||
validations:
|
||||
required: true
|
||||
- type: input
|
||||
id: changelist
|
||||
attributes:
|
||||
label: Prepared changelist for beta/stable
|
||||
description: Gerrit changelist against beta/stable per https://github.com/dart-lang/sdk/wiki/Cherry-picks-to-a-release-channel
|
||||
description: Gerrit changelist(s) against beta and/or stable per https://github.com/dart-lang/sdk/wiki/Cherry-picks-to-a-release-channel
|
||||
validations:
|
||||
required: true
|
||||
- type: textarea
|
||||
@@ -50,15 +50,11 @@ body:
|
||||
description: Describe the reasons, impacted users and functional issues to explain why this should be cherry-picked.
|
||||
validations:
|
||||
required: true
|
||||
- type: dropdown
|
||||
- type: textarea
|
||||
id: risk
|
||||
attributes:
|
||||
label: Risk
|
||||
description: What is the risk level of this cherry-pick?
|
||||
options:
|
||||
- low
|
||||
- medium
|
||||
- high
|
||||
validations:
|
||||
required: true
|
||||
- type: input
|
||||
|
||||
Reference in New Issue
Block a user