dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Revert "[vm] Disable longjmp() wrapper in exceptional flow in TSAN until g3 issue is fixed"

Browse Source 
This reverts commit 8d412e80e1.

Reason for revert: b/209838275#comment53

TEST=ci

Original change's description:
> [vm] Disable longjmp() wrapper in exceptional flow in TSAN until g3 issue is fixed
>
> Issue b/209838275
>
> TEST=ci
>
> Change-Id: Ie0a2e6f68a0c4f855dfd367dd3dd0a37053be479
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/222760
> Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com>
> Commit-Queue: Martin Kustermann <kustermann@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Iab202ddbd54060f609096b71f8ef83da53249d40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231005
Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com>
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
This commit is contained in:
Ivan Inozemtsev
2022-01-31 15:49:54 +00:00
committed by Commit Bot
parent 7771ed34cf
commit d7e3fadacd
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/vm/exceptions.cc
+1 -3
View File
@@ -631,9 +631,7 @@ void Exceptions::JumpToFrame(Thread* thread,
// The shadow call stack register will be restored by the JumpToFrame stub.
#endif
// TODO(b/209838275): Re-enable this once g3 build rules for gen_snapshot are
// working with TSAN.
#if 0 // defined(USING_THREAD_SANITIZER)
#if defined(USING_THREAD_SANITIZER)
if (thread->exit_through_ffi() == Thread::kExitThroughRuntimeCall) {
auto tsan_utils = thread->tsan_utils();
tsan_utils->exception_pc = program_counter;