dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[vm] Label object store fields in heap snapshots.

Browse Source 
TEST=examine snapshot
Change-Id: Ief0b059ef4dae05420452069bbdbb2febcf90d95
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/439382
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
This commit is contained in:
Ryan Macnak
2025-07-08 15:44:50 -07:00
committed by Commit Queue
parent 67e35919a3
commit c8c58aabdf
1 changed files with 43 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/vm/object_graph.cc
+43 -2
View File
@@ -1110,8 +1110,9 @@ enum ExtraCids {
kImagePageExtraCid = 2,
kRootSliceExtraCid = 3,
kIsolateExtraCid = 4,
kObjectStoreExtraCid = 5,
kNumExtraCids = 4,
kNumExtraCids = 5,
};
class Pass2Visitor : public ObjectVisitor,
@@ -1581,6 +1582,42 @@ void HeapSnapshotWriter::Write() {
WriteUtf8(""); // Reserved
}
}
{
ASSERT(kObjectStoreExtraCid == 5);
WriteUnsigned(0); // Flags
WriteUtf8("ObjectStore"); // Name
WriteUtf8(""); // Library name
WriteUtf8(""); // Library uri
WriteUtf8(""); // Reserved
enum {
#define V(type, name) kObjectStore_##name,
OBJECT_STORE_FIELD_LIST(V, V, V, V, V, V, V, V, V)
#undef EMIT_FIELD_NAME
kNumObjectStoreFields
};
WriteUnsigned(kNumObjectStoreFields);
// A strtab is smaller than an array of strings.
static const char* const names = ""
#define EMIT_FIELD_NAME(type, name) #name "_\0"
OBJECT_STORE_FIELD_LIST(EMIT_FIELD_NAME, EMIT_FIELD_NAME,
EMIT_FIELD_NAME, EMIT_FIELD_NAME,
EMIT_FIELD_NAME, EMIT_FIELD_NAME,
EMIT_FIELD_NAME, EMIT_FIELD_NAME,
EMIT_FIELD_NAME)
#undef EMIT_FIELD_NAME
; // NOLINT
const char* name = names;
for (intptr_t i = 0; i < kNumObjectStoreFields; i++) {
intptr_t flags = 1; // Strong.
WriteUnsigned(flags);
WriteUnsigned(i); // Index.
WriteUtf8(name);
WriteUtf8(""); // Reserved
name += strlen(name) + 1;
}
}
for (intptr_t cid = 1; cid <= class_count_; cid++) {
if (!class_table->HasValidClassAt(cid)) {
@@ -1708,7 +1745,11 @@ void HeapSnapshotWriter::Write() {
DEBUG_ASSERT(visitor.count() == num_image_objects);
}
for (intptr_t i = 0; i < kNumRootSlices; i++) {
WriteUnsigned(kRootSliceExtraCid);
if (i == kObjectStore) {
WriteUnsigned(kObjectStoreExtraCid);
} else {
WriteUnsigned(kRootSliceExtraCid);
}
WriteUnsigned(0); // shallowSize
WriteUnsigned(kNameData);
WriteUtf8(RootSliceToCString(i));