dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

analyzer: Move strong_mode.dart and inference_error.dart

Browse Source 
strong_mode.dart only contains a class, InstanceMemberInferrer, so it
can be named after that. InstanceMemberInferrer is only used by
`top_level_inference.dart`, so we move it to the same directory.

inference_error.dart just doesn't belong in the task directory. I think lib/src/error would be a fine location.

Change-Id: I6f36b1e8267bcf76f2e48aace4c93a719422dc21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399201
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This commit is contained in:
Sam Rawlins
2024-12-06 17:45:32 +00:00
committed by Commit Queue
parent d6274c9562
commit c0d4aa256d
18 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/analyzer/analyzer_use_new_elements.txt
+1 -1
View File
@@ -137,6 +137,7 @@ lib/src/summary2/element_builder.dart
lib/src/summary2/extension_type.dart
lib/src/summary2/function_type_builder.dart
lib/src/summary2/informative_data.dart
lib/src/summary2/instance_member_inferrer.dart
lib/src/summary2/library_builder.dart
lib/src/summary2/link.dart
lib/src/summary2/linked_element_factory.dart
@@ -157,7 +158,6 @@ lib/src/summary2/top_level_inference.dart
lib/src/summary2/type_alias.dart
lib/src/summary2/types_builder.dart
lib/src/summary2/variance_builder.dart
lib/src/task/strong_mode.dart
lib/src/test_utilities/find_element.dart
lib/src/test_utilities/find_node.dart
lib/src/test_utilities/mock_sdk_elements.dart
pkg/analyzer/lib/src/analysis_options/error/option_codes.g.dart
+1 -1
View File
@@ -15,7 +15,7 @@
// ignore_for_file: flutter_style_todos
/// @docImport 'package:analyzer/src/dart/error/syntactic_errors.g.dart';
/// @docImport 'package:analyzer/src/task/inference_error.dart';
/// @docImport 'package:analyzer/src/error/inference_error.dart';
library;
import "package:analyzer/error/error.dart";
pkg/analyzer/lib/src/dart/element/element.dart
+1 -1
View File
@@ -42,6 +42,7 @@ import 'package:analyzer/src/dart/element/type_provider.dart';
import 'package:analyzer/src/dart/element/type_system.dart';
import 'package:analyzer/src/dart/resolver/scope.dart'
show Namespace, NamespaceBuilder;
import 'package:analyzer/src/error/inference_error.dart';
import 'package:analyzer/src/generated/engine.dart' show AnalysisContext;
import 'package:analyzer/src/generated/source.dart' show DartUriResolver;
import 'package:analyzer/src/generated/utilities_collection.dart';
@@ -52,7 +53,6 @@ import 'package:analyzer/src/summary2/export.dart';
import 'package:analyzer/src/summary2/macro.dart';
import 'package:analyzer/src/summary2/macro_application_error.dart';
import 'package:analyzer/src/summary2/reference.dart';
import 'package:analyzer/src/task/inference_error.dart';
import 'package:analyzer/src/util/file_paths.dart' as file_paths;
import 'package:analyzer/src/utilities/extensions/collection.dart';
import 'package:analyzer/src/utilities/extensions/element.dart';
pkg/analyzer/lib/src/dart/error/ffi_code.g.dart
+1 -1
View File
@@ -15,7 +15,7 @@
// ignore_for_file: flutter_style_todos
/// @docImport 'package:analyzer/src/dart/error/syntactic_errors.g.dart';
/// @docImport 'package:analyzer/src/task/inference_error.dart';
/// @docImport 'package:analyzer/src/error/inference_error.dart';
library;
import "package:analyzer/error/error.dart";
pkg/analyzer/lib/src/dart/error/hint_codes.g.dart
+1 -1
View File
@@ -15,7 +15,7 @@
// ignore_for_file: flutter_style_todos
/// @docImport 'package:analyzer/src/dart/error/syntactic_errors.g.dart';
/// @docImport 'package:analyzer/src/task/inference_error.dart';
/// @docImport 'package:analyzer/src/error/inference_error.dart';
library;
import "package:analyzer/error/error.dart";
pkg/analyzer/lib/src/dart/error/syntactic_errors.g.dart
+1 -1
View File
@@ -15,7 +15,7 @@
// ignore_for_file: flutter_style_todos
/// @docImport 'package:analyzer/src/dart/error/syntactic_errors.g.dart';
/// @docImport 'package:analyzer/src/task/inference_error.dart';
/// @docImport 'package:analyzer/src/error/inference_error.dart';
library;
import "package:analyzer/error/error.dart";
pkg/analyzer/lib/src/error/codes.g.dart
+1 -1
View File
@@ -15,7 +15,7 @@
// ignore_for_file: flutter_style_todos
/// @docImport 'package:analyzer/src/dart/error/syntactic_errors.g.dart';
/// @docImport 'package:analyzer/src/task/inference_error.dart';
/// @docImport 'package:analyzer/src/error/inference_error.dart';
library;
import "package:analyzer/error/error.dart";
pkg/analyzer/lib/src/task/inference_error.dart → pkg/analyzer/lib/src/error/inference_error.dart
View File
pkg/analyzer/lib/src/error/inheritance_override.dart
+1 -1
View File
@@ -19,7 +19,7 @@ import 'package:analyzer/src/dart/element/type_system.dart';
import 'package:analyzer/src/error/codes.dart';
import 'package:analyzer/src/error/correct_override.dart';
import 'package:analyzer/src/error/getter_setter_types_verifier.dart';
import 'package:analyzer/src/task/inference_error.dart';
import 'package:analyzer/src/error/inference_error.dart';
import 'package:analyzer/src/utilities/extensions/element.dart';
final _missingMustBeOverridden = Expando<List<ExecutableElement>>();
pkg/analyzer/lib/src/generated/resolver.dart
+1 -1
View File
@@ -77,6 +77,7 @@ import 'package:analyzer/src/error/base_or_final_type_verifier.dart';
import 'package:analyzer/src/error/bool_expression_verifier.dart';
import 'package:analyzer/src/error/codes.dart';
import 'package:analyzer/src/error/dead_code_verifier.dart';
import 'package:analyzer/src/error/inference_error.dart';
import 'package:analyzer/src/error/nullable_dereference_verifier.dart';
import 'package:analyzer/src/error/super_formal_parameters_verifier.dart';
import 'package:analyzer/src/generated/element_resolver.dart';
@@ -85,7 +86,6 @@ import 'package:analyzer/src/generated/inference_log.dart';
import 'package:analyzer/src/generated/static_type_analyzer.dart';
import 'package:analyzer/src/generated/utilities_dart.dart';
import 'package:analyzer/src/generated/variable_type_provider.dart';
import 'package:analyzer/src/task/inference_error.dart';
import 'package:analyzer/src/util/ast_data_extractor.dart';
import 'package:analyzer/src/utilities/extensions/element.dart';
import 'package:analyzer/src/utilities/extensions/object.dart';
pkg/analyzer/lib/src/manifest/manifest_warning_code.g.dart
+1 -1
View File
@@ -15,7 +15,7 @@
// ignore_for_file: flutter_style_todos
/// @docImport 'package:analyzer/src/dart/error/syntactic_errors.g.dart';
/// @docImport 'package:analyzer/src/task/inference_error.dart';
/// @docImport 'package:analyzer/src/error/inference_error.dart';
library;
import "package:analyzer/error/error.dart";
pkg/analyzer/lib/src/pubspec/pubspec_warning_code.g.dart
+1 -1
View File
@@ -15,7 +15,7 @@
// ignore_for_file: flutter_style_todos
/// @docImport 'package:analyzer/src/dart/error/syntactic_errors.g.dart';
/// @docImport 'package:analyzer/src/task/inference_error.dart';
/// @docImport 'package:analyzer/src/error/inference_error.dart';
library;
import "package:analyzer/error/error.dart";
pkg/analyzer/lib/src/summary2/bundle_reader.dart
+1 -1
View File
@@ -21,6 +21,7 @@ import 'package:analyzer/src/dart/element/member.dart';
import 'package:analyzer/src/dart/element/name_union.dart';
import 'package:analyzer/src/dart/element/type.dart';
import 'package:analyzer/src/dart/element/type_algebra.dart';
import 'package:analyzer/src/error/inference_error.dart';
import 'package:analyzer/src/generated/utilities_dart.dart';
import 'package:analyzer/src/summary2/ast_binary_reader.dart';
import 'package:analyzer/src/summary2/ast_binary_tag.dart';
@@ -32,7 +33,6 @@ import 'package:analyzer/src/summary2/linked_element_factory.dart';
import 'package:analyzer/src/summary2/macro_application_error.dart';
import 'package:analyzer/src/summary2/macro_type_location_storage.dart';
import 'package:analyzer/src/summary2/reference.dart';
import 'package:analyzer/src/task/inference_error.dart';
import 'package:analyzer/src/utilities/extensions/collection.dart';
import 'package:analyzer/src/utilities/extensions/element.dart';
import 'package:analyzer/src/utilities/extensions/string.dart';
pkg/analyzer/lib/src/summary2/bundle_writer.dart
+1 -1
View File
@@ -18,6 +18,7 @@ import 'package:analyzer/src/dart/element/field_name_non_promotability_info.dart
import 'package:analyzer/src/dart/element/member.dart';
import 'package:analyzer/src/dart/element/type.dart';
import 'package:analyzer/src/dart/element/type_algebra.dart';
import 'package:analyzer/src/error/inference_error.dart';
import 'package:analyzer/src/summary2/ast_binary_tag.dart';
import 'package:analyzer/src/summary2/ast_binary_writer.dart';
import 'package:analyzer/src/summary2/data_writer.dart';
@@ -26,7 +27,6 @@ import 'package:analyzer/src/summary2/export.dart';
import 'package:analyzer/src/summary2/macro_application_error.dart';
import 'package:analyzer/src/summary2/macro_type_location_storage.dart';
import 'package:analyzer/src/summary2/reference.dart';
import 'package:analyzer/src/task/inference_error.dart';
import 'package:analyzer/src/utilities/extensions/object.dart';
class BundleWriter {
pkg/analyzer/lib/src/task/strong_mode.dart → pkg/analyzer/lib/src/summary2/instance_member_inferrer.dart
+1 -1
View File
@@ -10,7 +10,7 @@ import 'package:analyzer/src/dart/element/inheritance_manager3.dart';
import 'package:analyzer/src/dart/element/type.dart';
import 'package:analyzer/src/dart/element/type_algebra.dart';
import 'package:analyzer/src/dart/element/type_system.dart';
import 'package:analyzer/src/task/inference_error.dart';
import 'package:analyzer/src/error/inference_error.dart';
import 'package:analyzer/src/util/collection.dart';
import 'package:collection/collection.dart';
pkg/analyzer/lib/src/summary2/top_level_inference.dart
+2 -2
View File
@@ -9,12 +9,12 @@ import 'package:analyzer/src/dart/ast/ast.dart';
import 'package:analyzer/src/dart/ast/extensions.dart';
import 'package:analyzer/src/dart/element/element.dart';
import 'package:analyzer/src/dart/element/type.dart';
import 'package:analyzer/src/error/inference_error.dart';
import 'package:analyzer/src/summary2/ast_resolver.dart';
import 'package:analyzer/src/summary2/instance_member_inferrer.dart';
import 'package:analyzer/src/summary2/library_builder.dart';
import 'package:analyzer/src/summary2/link.dart';
import 'package:analyzer/src/summary2/linking_node_scope.dart';
import 'package:analyzer/src/task/inference_error.dart';
import 'package:analyzer/src/task/strong_mode.dart';
import 'package:analyzer/src/utilities/extensions/object.dart';
import 'package:collection/collection.dart';
pkg/analyzer/test/src/summary/element_text.dart
+1 -1
View File
@@ -9,10 +9,10 @@ import 'package:analyzer/dart/element/type.dart';
import 'package:analyzer/src/dart/element/element.dart';
import 'package:analyzer/src/dart/element/field_name_non_promotability_info.dart';
import 'package:analyzer/src/dart/element/member.dart';
import 'package:analyzer/src/error/inference_error.dart';
import 'package:analyzer/src/summary2/export.dart';
import 'package:analyzer/src/summary2/macro_application_error.dart';
import 'package:analyzer/src/summary2/macro_type_location.dart';
import 'package:analyzer/src/task/inference_error.dart';
import 'package:analyzer_utilities/testing/tree_string_sink.dart';
import 'package:collection/collection.dart';
import 'package:pub_semver/pub_semver.dart';
pkg/analyzer/tool/messages/generate.dart
+1 -1
View File
@@ -87,7 +87,7 @@ class _AnalyzerErrorGenerator {
// ignore_for_file: flutter_style_todos
/// @docImport 'package:analyzer/src/dart/error/syntactic_errors.g.dart';
/// @docImport 'package:analyzer/src/task/inference_error.dart';
/// @docImport 'package:analyzer/src/error/inference_error.dart';
library;
''');