Group the GC tests into a common directory.

The makes it possible to run just these tests with `test.py vm/gc/`.

Change-Id: Ied4aa0b2fb045c19b1aced68f58a1ef195a5df8a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311145
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
This commit is contained in:
Ryan Macnak
2023-06-29 17:27:48 +00:00
committed by Commit Queue
parent 41bb44e93e
commit ac77af1c07
55 changed files with 22 additions and 41 deletions
@@ -95,7 +95,7 @@
"../vm/dart/single_target_and_method_extractors2_test.dart",
"../vm/dart/single_target_and_method_extractors_test.dart",
"../vm/dart/slow_path_shared_stub_test.dart",
"../vm/dart/splay_test.dart",
"../vm/dart/gc/splay_test.dart",
"../vm/dart/stack_overflow_shared_test.dart",
"../vm/dart/stacktrace_mixin_application_test.dart",
"../vm/dart/strict_null_safety_checks_in_weak_mode_test.dart",
@@ -3201,7 +3201,6 @@
"../../../tests/standalone/double_temp_test.dart",
"../../../tests/standalone/double_to_int_test.dart",
"../../../tests/standalone/float_array_test.dart",
"../../../tests/standalone/fragmentation_typed_data_test.dart",
"../../../tests/standalone/int_array_load_elimination_test.dart",
"../../../tests/standalone/int_array_test.dart",
"../../../tests/standalone/int_list_test.dart",
@@ -3475,7 +3474,7 @@
"../vm/dart_2/single_target_and_method_extractors2_test.dart",
"../vm/dart_2/single_target_and_method_extractors_test.dart",
"../vm/dart_2/slow_path_shared_stub_test.dart",
"../vm/dart_2/splay_test.dart",
"../vm/dart_2/gc/splay_test.dart",
"../vm/dart_2/stack_overflow_shared_test.dart",
"../vm/dart_2/stacktrace_mixin_application_test.dart",
"../vm/dart_2/switchable_call_monomorphic_regression_42517_test.dart",
@@ -6,7 +6,7 @@
import 'dart:async';
import 'snapshot_test_helper.dart';
import 'splay_test.dart';
import 'gc/splay_test.dart';
int fib(int n) {
if (n <= 1) return 1;
@@ -8,7 +8,7 @@ import 'dart:async';
import 'dart:isolate';
import 'package:expect/expect.dart';
import "splay_test.dart" deferred as splay;
import "gc/splay_test.dart" deferred as splay;
worker(SendPort sendPort) {
Expect.throws(() => splay.main(),
@@ -8,7 +8,7 @@
// VMOptions=--no_retain_function_objects
// VMOptions=--dwarf_stack_traces
import "splay_test.dart" deferred as splay; // Some non-trivial code.
import "gc/splay_test.dart" deferred as splay; // Some non-trivial code.
main() async {
await splay.loadLibrary();
@@ -2,7 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
import "splay_test.dart" deferred as splay; // Some non-trivial code.
import "gc/splay_test.dart" deferred as splay; // Some non-trivial code.
main() async {
await splay.loadLibrary();
@@ -2,7 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
// OtherResources=splay_test.dart splay_common.dart
// OtherResources=gc/splay_test.dart gc/splay_common.dart
// Tests AOT kernel generation split into 2 steps using '--from-dill' option.
@@ -44,5 +44,5 @@ Future<void> runSplitAOTKernelGenerationTest(Uri testScriptUri) async {
main() async {
await runSplitAOTKernelGenerationTest(
Platform.script.resolve('splay_test.dart'));
Platform.script.resolve('gc/splay_test.dart'));
}
@@ -8,7 +8,7 @@
import 'dart:async';
import 'snapshot_test_helper.dart';
import 'splay_test.dart';
import 'gc/splay_test.dart';
int fib(int n) {
if (n <= 1) return 1;
@@ -9,7 +9,7 @@
import 'dart:isolate';
import 'package:expect/expect.dart';
import "splay_test.dart" deferred as splay;
import "gc/splay_test.dart" deferred as splay;
worker(SendPort sendPort) {
Expect.throws(() => splay.main(),
@@ -10,7 +10,7 @@
// VMOptions=--no_retain_function_objects
// VMOptions=--dwarf_stack_traces
import "splay_test.dart" deferred as splay; // Some non-trivial code.
import "gc/splay_test.dart" deferred as splay; // Some non-trivial code.
main() async {
await splay.loadLibrary();
@@ -4,7 +4,7 @@
// @dart = 2.9
import "splay_test.dart" deferred as splay; // Some non-trivial code.
import "gc/splay_test.dart" deferred as splay; // Some non-trivial code.
main() async {
await splay.loadLibrary();
@@ -4,7 +4,7 @@
// @dart = 2.9
// OtherResources=splay_test.dart splay_common.dart
// OtherResources=gc/splay_test.dart gc/splay_common.dart
// Tests AOT kernel generation split into 2 steps using '--from-dill' option.
@@ -46,5 +46,5 @@ Future<void> runSplitAOTKernelGenerationTest(Uri testScriptUri) async {
main() async {
await runSplitAOTKernelGenerationTest(
Platform.script.resolve('splay_test.dart'));
Platform.script.resolve('gc/splay_test.dart'));
}
+8 -6
View File
@@ -87,6 +87,9 @@ dart_2/null_safety_autodetection_in_kernel_compiler_test: SkipSlow # gen_kernel
[ $builder_tag == tsan ]
dart/analyze_snapshot_binary_test: SkipSlow
dart/appjit_cha_deopt_test: SkipSlow
dart/gc/fragmentation*: Skip # Uses too much memory with TSAN overhead and kills bot
dart/gc/out_of_memory*: Skip # Uses too much memory with TSAN overhead and kills bot
dart/gc/scavenger_abort_test: SkipSlow
dart/hash_map_probes_limit_test: SkipSlow # Test includes large program compilation.
dart/regress_40462_test: SkipSlow
dart/regress_40753_test: Skip # This test crashes on the bot, but not locally, and infrastructure repeatedly fails to locate its coredump.
@@ -98,6 +101,9 @@ dart/v8_snapshot_profile_writer_test: SkipSlow
dart/weak_canonical_string_table_test: Pass, Slow # This test can take a longer time to complete.
dart_2/analyze_snapshot_binary_test: SkipSlow
dart_2/appjit_cha_deopt_test: SkipSlow
dart_2/gc/fragmentation*: Skip # Uses too much memory with TSAN overhead and kills bot
dart_2/gc/out_of_memory*: Skip # Uses too much memory with TSAN overhead and kills bot
dart_2/gc/scavenger_abort_test: SkipSlow
dart_2/hash_map_probes_limit_test: SkipSlow # Test includes large program compilation.
dart_2/regress_40462_test: SkipSlow
dart_2/regress_40753_test: Skip # This test crashes on the bot, but not locally, and infrastructure repeatedly fails to locate its coredump.
@@ -143,10 +149,8 @@ dart_2/snapshot_depfile_test: SkipByDesign # Test needs to run from source
dart/await_type_check_with_dynamic_loading_test: SkipByDesign # Uses dart:mirrors.
dart/finalizer/finalizer_isolate_groups_run_gc_test: SkipByDesign # Isolate.spawnUri is not supported in AOT.
dart/redirection_type_shuffling_test: SkipByDesign # Uses dart:mirrors.
dart/scavenger_abort_test: SkipSlow
dart/v8_snapshot_profile_writer_test: Pass, Slow # Can be slow due to re-invoking the precompiler.
dart_2/redirection_type_shuffling_test: SkipByDesign # Uses dart:mirrors.
dart_2/scavenger_abort_test: SkipSlow
dart_2/v8_snapshot_profile_writer_test: Pass, Slow # Can be slow due to re-invoking the precompiler.
[ $compiler != dartkp ]
@@ -260,21 +264,21 @@ cc/Profiler_ToggleRecordAllocation: SkipByDesign
cc/Profiler_TrivialRecordAllocation: SkipByDesign
cc/Profiler_TypedArrayAllocation: SkipByDesign
cc/Service_Profile: SkipByDesign
dart/gc/splay_c_finalizer_test: SkipByDesign # No FFI on simulators
dart/isolates/dart_api_create_lightweight_isolate_test: SkipByDesign # https://dartbug.com/37299 Test uses dart:ffi which is not supported on simulators.
dart/isolates/thread_pool_test: SkipByDesign # https://dartbug.com/37299 Test uses dart:ffi which is not supported on simulators.
dart/regress_41971_test: SkipByDesign # https://dartbug.com/37299 dart:ffi is not supported on simulator
dart/regress_b_216834909_test: SkipByDesign # No FFI on simulators
dart/sdk_hash_test: SkipSlow # gen_kernel is slow to run on simarm
dart/splay_c_finalizer_test: SkipByDesign # No FFI on simulators
dart/unboxed_param_args_descriptor_test: SkipByDesign # https://dartbug.com/37299 FFI helper not supported on simulator
dart/unboxed_param_tear_off_test: SkipByDesign # https://dartbug.com/37299 FFI helper not supported on simulator
dart/unboxed_param_test: SkipByDesign # https://dartbug.com/37299 FFI helper not supported on simulator
dart_2/gc/splay_c_finalizer_test: SkipByDesign # No FFI on simulators
dart_2/isolates/dart_api_create_lightweight_isolate_test: SkipByDesign # https://dartbug.com/37299 Test uses dart:ffi which is not supported on simulators.
dart_2/isolates/thread_pool_test: SkipByDesign # https://dartbug.com/37299 Test uses dart:ffi which is not supported on simulators.
dart_2/regress_41971_test: SkipByDesign # https://dartbug.com/37299 dart:ffi is not supported on simulator
dart_2/regress_b_216834909_test: SkipByDesign # No FFI on simulators
dart_2/sdk_hash_test: SkipSlow # gen_kernel is slow to run on simarm
dart_2/splay_c_finalizer_test: SkipByDesign # No FFI on simulators
dart_2/unboxed_param_args_descriptor_test: SkipByDesign # https://dartbug.com/37299 FFI helper not supported on simulator
dart_2/unboxed_param_tear_off_test: SkipByDesign # https://dartbug.com/37299 FFI helper not supported on simulator
dart_2/unboxed_param_test: SkipByDesign # https://dartbug.com/37299 FFI helper not supported on simulator
@@ -522,7 +526,6 @@ dart/print_flow_graph_determinism_test: SkipSlow
dart/slow_path_shared_stub_test: SkipSlow # Too slow with --shared-slow-path-triggers-gc flag and not relevant outside precompiled.
dart/spawn_infinite_loop_test: Skip # We can shutdown an isolate before it reloads.
dart/spawn_shutdown_test: Skip # We can shutdown an isolate before it reloads.
dart/splay_test: SkipSlow
dart/stack_overflow_shared_test: SkipSlow # Too slow with --shared-slow-path-triggers-gc flag and not relevant outside precompiled.
dart_2/appjit*: SkipByDesign # Cannot reload with URI pointing to app snapshot.
dart_2/disassemble_determinism_test: SkipSlow # Runs expensive fibonacci(32) computation in 2 subprocesses
@@ -533,7 +536,6 @@ dart_2/print_flow_graph_determinism_test: SkipSlow
dart_2/slow_path_shared_stub_test: SkipSlow # Too slow with --shared-slow-path-triggers-gc flag and not relevant outside precompiled.
dart_2/spawn_infinite_loop_test: Skip # We can shutdown an isolate before it reloads.
dart_2/spawn_shutdown_test: Skip # We can shutdown an isolate before it reloads.
dart_2/splay_test: SkipSlow
dart_2/stack_overflow_shared_test: SkipSlow # Too slow with --shared-slow-path-triggers-gc flag and not relevant outside precompiled.
[ $hot_reload || $hot_reload_rollback || $compiler != dartk && $compiler != dartkp ]
-4
View File
@@ -105,10 +105,6 @@ io/raw_secure_server_socket_test: Crash
io/raw_server_socket_cancel_test: Skip # Issue 28182 # This test sometimes hangs on Mac.
io/socket_many_connections_test: Skip # This test fails with "Too many open files" on the Mac OS buildbot. This is expected as MacOS by default runs with a very low number of allowed open files ('ulimit -n' says something like 256).
[ $arch == arm || $arch == arm64 || $runtime != vm || $system == android ]
fragmentation_test: SkipSlow
fragmentation_typed_data_test: SkipSlow
[ $compiler == dart2js || $compiler == ddc ]
*: SkipByDesign
@@ -4,14 +4,8 @@
# Sections in this file should contain "$compiler == dartk" or
# "$compiler == dartkp".
fragmentation_test: Pass, Slow # GC heavy
fragmentation_typed_data_test: Pass, Slow # GC heavy
io/process_sync_test: Pass, Slow # Spawns synchronously subprocesses in sequence.
[ $builder_tag == tsan ]
fragmentation_test: Skip # This test crashes on the bot, but not locally, and infrastructure repeatedly fails to locate its coredump.
fragmentation_typed_data_test: Skip # This test crashes on the bot, but not locally, and infrastructure repeatedly fails to locate its coredump.
[ $system == android ]
entrypoints_verification_test: Skip # Requires shared objects which the test script doesn't "adb push".
io/http_ban_http_embedder_test: Skip # Requires http server bound to non-loopback; not provided by system.
-4
View File
@@ -105,10 +105,6 @@ io/raw_secure_server_socket_test: Crash
io/raw_server_socket_cancel_test: Skip # Issue 28182 # This test sometimes hangs on Mac.
io/socket_many_connections_test: Skip # This test fails with "Too many open files" on the Mac OS buildbot. This is expected as MacOS by default runs with a very low number of allowed open files ('ulimit -n' says something like 256).
[ $arch == arm || $arch == arm64 || $runtime != vm || $system == android ]
fragmentation_test: SkipSlow
fragmentation_typed_data_test: SkipSlow
[ $compiler == dart2js || $compiler == ddc ]
*: SkipByDesign
@@ -4,14 +4,8 @@
# Sections in this file should contain "$compiler == dartk" or
# "$compiler == dartkp".
fragmentation_test: Pass, Slow # GC heavy
fragmentation_typed_data_test: Pass, Slow # GC heavy
io/process_sync_test: Pass, Slow # Spawns synchronously subprocesses in sequence.
[ $builder_tag == tsan ]
fragmentation_test: Skip # This test crashes on the bot, but not locally, and infrastructure repeatedly fails to locate its coredump.
fragmentation_typed_data_test: Skip # This test crashes on the bot, but not locally, and infrastructure repeatedly fails to locate its coredump.
[ $system == android ]
entrypoints_verification_test: Skip # Requires shared objects which the test script doesn't "adb push".
io/http_ban_http_embedder_test: Skip # Requires http server bound to non-loopback; not provided by system.