Work around issue with -r in presubmit scripts.
For some reason, when a `CheckSorted` presubmit invokes `verify_sorted_test.dart`, the `-r` flag is preventing the compiler from picking up the proper language version from `.dart_tool/package_config.json`. This is interfering with my ability to run presubmits for https://dart-review.googlesource.com/c/sdk/+/505046. See https://github.com/dart-lang/sdk/issues/63464 for additional details. As a temporary workaround, this CL removes the `-r` flag. It should be reverted once https://github.com/dart-lang/sdk/issues/63464 has been fixed (and the pre-built SDK has been updated to include the fix). Change-Id: Ibc48eec4ef382d6afe17d73454f07dcd6a6a6964 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/506700 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Samuel Rawlins <srawlins@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This commit is contained in:
committed by
dart-scoped@luci-project-accounts.iam.gserviceaccount.com
parent
d0f27293ce
commit
9bd89a769d
@@ -44,7 +44,6 @@ def CheckSorted(input_api, output_api):
|
||||
result = subprocess.run([
|
||||
dart,
|
||||
'run',
|
||||
'-r',
|
||||
os.path.join(local_root, 'pkg', 'analysis_server', 'test',
|
||||
'verify_sorted_test.dart'),
|
||||
] + sourceArgs,
|
||||
|
||||
@@ -44,7 +44,6 @@ def CheckSorted(input_api, output_api):
|
||||
result = subprocess.run([
|
||||
dart,
|
||||
'run',
|
||||
'-r',
|
||||
os.path.join(local_root, 'pkg', 'analysis_server', 'test',
|
||||
'verify_sorted_test.dart'),
|
||||
] + sourceArgs,
|
||||
|
||||
@@ -44,7 +44,6 @@ def CheckSorted(input_api, output_api):
|
||||
result = subprocess.run([
|
||||
dart,
|
||||
'run',
|
||||
'-r',
|
||||
os.path.join(local_root, 'pkg', 'analysis_server', 'test',
|
||||
'verify_sorted_test.dart'),
|
||||
] + sourceArgs,
|
||||
|
||||
@@ -44,7 +44,6 @@ def CheckSorted(input_api, output_api):
|
||||
result = subprocess.run([
|
||||
dart,
|
||||
'run',
|
||||
'-r',
|
||||
os.path.join(local_root, 'pkg', 'analysis_server', 'test',
|
||||
'verify_sorted_test.dart'),
|
||||
] + sourceArgs,
|
||||
|
||||
Reference in New Issue
Block a user