dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Add missing smi tag shifts

Browse Source 
TEST=ci

Bug: b/502506240
Change-Id: Icb81c2c0653ed7793194c2454aa3fc283e797323
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/495380
Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
This commit is contained in:
Ivan Inozemtsev
2026-04-14 09:43:24 -07:00
committed by dart-scoped@luci-project-accounts.iam.gserviceaccount.com
parent b809db2c48
commit 97685b7dbb
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/vm/compiler/stub_code_compiler.cc
+4 -2
View File
@@ -3345,7 +3345,8 @@ void StubCodeCompiler::GenerateSubtypeTestCacheSearch(
ZERO, (n >= 5) ? &load_function_type_arguments : &initialized);
__ ExtractBitField(
instance_type_args_reg, TypeTestABI::kScratchReg,
UntaggedClosure::InstantiatorTypeArgumentsIndexBits::shift(),
UntaggedClosure::InstantiatorTypeArgumentsIndexBits::shift() +
kSmiTagShift,
UntaggedClosure::InstantiatorTypeArgumentsIndexBits::bitsize());
__ LoadIndexedCompressed(
instance_type_args_reg, TypeTestABI::kInstanceReg,
@@ -3360,7 +3361,8 @@ void StubCodeCompiler::GenerateSubtypeTestCacheSearch(
(n >= 6) ? &load_delayed_type_arguments : &initialized);
__ ExtractBitField(
parent_fun_type_args_reg, TypeTestABI::kScratchReg,
UntaggedClosure::FunctionTypeArgumentsIndexBits::shift(),
UntaggedClosure::FunctionTypeArgumentsIndexBits::shift() +
kSmiTagShift,
UntaggedClosure::FunctionTypeArgumentsIndexBits::bitsize());
__ LoadIndexedCompressed(
parent_fun_type_args_reg, TypeTestABI::kInstanceReg,
runtime/vm/compiler/stub_code_compiler_ia32.cc
+4 -2
View File
@@ -2795,7 +2795,8 @@ void StubCodeCompiler::GenerateSubtypeNTestCacheStub(Assembler* assembler,
__ ExtractBitField(
STCInternal::kInstanceInstantiatorTypeArgumentsReg,
STCInternal::kScratchReg,
UntaggedClosure::InstantiatorTypeArgumentsIndexBits::shift(),
UntaggedClosure::InstantiatorTypeArgumentsIndexBits::shift() +
kSmiTagShift,
UntaggedClosure::InstantiatorTypeArgumentsIndexBits::bitsize());
__ Load(
STCInternal::kInstanceInstantiatorTypeArgumentsReg,
@@ -2812,7 +2813,8 @@ void StubCodeCompiler::GenerateSubtypeNTestCacheStub(Assembler* assembler,
&no_function_type_arguments);
__ ExtractBitField(
STCInternal::kScratchReg, STCInternal::kScratchReg,
UntaggedClosure::FunctionTypeArgumentsIndexBits::shift(),
UntaggedClosure::FunctionTypeArgumentsIndexBits::shift() +
kSmiTagShift,
UntaggedClosure::FunctionTypeArgumentsIndexBits::bitsize());
__ pushl(FieldAddress(TypeTestABI::kInstanceReg,
STCInternal::kScratchReg, TIMES_WORD_SIZE,