dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[build] Remove runtime_kernel target from GN build

Browse Source 
Remove the runtime_kernel target and all uses of it in scripts or
the test matrix.  This runtime_kernel target is only an alias for
the runtime target, now that kernel is the default.

BUG=https://github.com/dart-lang/sdk/issues/46892

Change-Id: I00c0ecf8adbd7bff3fd3df48023a2976c5172066
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210000
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: William Hesse <whesse@google.com>
This commit is contained in:
William Hesse
2021-08-13 10:09:41 +00:00
committed by commit-bot@chromium.org
parent fb861597e4
commit 8776e15f60
6 changed files with 32 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files
BUILD.gn
-8
View File
@@ -73,14 +73,6 @@ group("run_ffi_unit_tests") {
deps = [ "runtime/bin/ffi_unit_test:run_ffi_unit_tests" ]
}
group("runtime_kernel") {
if (targetting_fuchsia) {
# Fuchsia has run_vm_tests marked testonly.
testonly = true
}
deps = [ ":runtime" ]
}
group("runtime_precompiled") {
deps = [
"runtime/bin:dart_precompiled_runtime",
pkg/front_end/lib/src/fasta/README.md
+2 -2
View File
@@ -13,10 +13,10 @@ Fasta sounds like faster, and that's a promise we intend to keep.
## Getting Started
1. [Build](https://github.com/dart-lang/sdk/wiki/Building#building) the VM and patched SDK. Note: you only need to build the targets `runtime_kernel`, and `dart_precompiled_runtime`, so you only need to run this command:
1. [Build](https://github.com/dart-lang/sdk/wiki/Building#building) the VM and patched SDK. Note: you only need to build the targets `runtime` and `dart_precompiled_runtime`, so you only need to run this command:
```bash
./tools/build.py --mode release --arch x64 runtime_kernel dart_precompiled_runtime
./tools/build.py --mode release --arch x64 runtime dart_precompiled_runtime
```
## Create an Outline File
pkg/front_end/lib/src/fasta/TESTING.md
+1 -1
View File
@@ -40,7 +40,7 @@ Note that this test requires a 64-bit build because app-jit snapshot does not wo
```
# Language, co19, kernel, for VM using Fasta.
./tools/build.py -mrelease runtime_kernel && ./tools/test.py -mrelease -cdartk co19 language kernel --time -pcolor --report -j16
./tools/build.py -mrelease runtime && ./tools/test.py -mrelease -cdartk co19 language kernel --time -pcolor --report -j16
```
runtime/docs/aot_binary_size_analysis.md
+2 -2
View File
@@ -13,7 +13,7 @@ This flag can be passed to `gen_snapshot` directly, or to the various wrapper
scripts (e.g. `pkg/vm/tool/precompiler2`):
```
% tools/build.py -mrelease -ax64 runtime_kernel dart_precompiled_runtime
% tools/build.py -mrelease -ax64 runtime dart_precompiled_runtime
% pkg/vm/tool/precompiler2 --print-instructions-sizes-to=hello_sizes.json hello.dart hello.dart.aot
```
@@ -59,7 +59,7 @@ This flag can be passed to `gen_snapshot` directly, or to the various wrapper
scripts (e.g. `pkg/vm/tool/precompiler2`):
```
% tools/build.py -mrelease -ax64 runtime_kernel dart_precompiled_runtime
% tools/build.py -mrelease -ax64 runtime dart_precompiled_runtime
% pkg/vm/tool/precompiler2 --write-v8-snapshot-profile-to=hello.heapsnapshot hello.dart hello.dart.aot
```
runtime/docs/dwarf_stack_traces.md
+1 -1
View File
@@ -46,7 +46,7 @@ Below is the result of running the file both without and with
`--dwarf-stack-traces` in a 64-bit Linux development environment:
```bash
$ python3 tools/build.py -a x64 -m release runtime_kernel runtime_precompiled
$ python3 tools/build.py -a x64 -m release runtime runtime_precompiled
$ pkg/vm/tool/gen_kernel --platform out/ReleaseX64/vm_platform_strong.dill -o throws.dill throws.dart
tools/bots/test_matrix.json
+26 -27
View File
@@ -1016,7 +1016,7 @@
"create_sdk",
"dartdevc_test",
"kernel_platform_files",
"runtime_kernel"
"runtime"
]
},
{
@@ -1095,7 +1095,7 @@
"create_sdk",
"dartdevc_test",
"kernel_platform_files",
"runtime_kernel"
"runtime"
]
},
{
@@ -1186,7 +1186,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"runtime_kernel",
"runtime",
"dart_precompiled_runtime",
"--os=android"
]
@@ -1222,7 +1222,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"runtime_kernel",
"runtime",
"--os=android"
]
},
@@ -1267,7 +1267,7 @@
"arguments": [
"--use-qemu",
"dart_precompiled_runtime",
"runtime_kernel"
"runtime"
]
},
{
@@ -1306,7 +1306,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"runtime_kernel",
"runtime",
"dart_precompiled_runtime",
"gen_snapshot"
]
@@ -1364,7 +1364,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"runtime_kernel",
"runtime",
"dart_precompiled_runtime"
]
},
@@ -1435,7 +1435,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"runtime_kernel",
"runtime",
"dart_precompiled_runtime"
]
},
@@ -1478,7 +1478,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"runtime_kernel",
"runtime",
"dart_precompiled_runtime"
]
},
@@ -1508,7 +1508,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"runtime_kernel",
"runtime",
"dart_precompiled_runtime"
]
},
@@ -1535,7 +1535,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"runtime_kernel",
"runtime",
"dart_precompiled_runtime"
]
},
@@ -1565,7 +1565,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"runtime_kernel",
"runtime",
"dart_precompiled_runtime"
]
},
@@ -1592,7 +1592,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"runtime_kernel",
"runtime",
"dart_precompiled_runtime"
]
},
@@ -1796,7 +1796,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"runtime_kernel"
"runtime"
]
},
{
@@ -1840,8 +1840,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"create_sdk",
"runtime_kernel"
"runtime"
]
},
{
@@ -1926,7 +1925,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"runtime_kernel"
"runtime"
]
},
{
@@ -1961,7 +1960,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"runtime_kernel"
"runtime"
]
},
{
@@ -2009,7 +2008,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"runtime_kernel"
"runtime"
]
},
{
@@ -2037,7 +2036,7 @@
"arguments": [
"dart_precompiled_runtime",
"gen_snapshot",
"runtime_kernel"
"runtime"
]
},
{
@@ -2067,7 +2066,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"runtime_kernel"
"runtime"
]
},
{
@@ -2365,7 +2364,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"runtime_kernel"
"runtime"
]
},
{
@@ -2393,7 +2392,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"runtime_kernel"
"runtime"
]
},
{
@@ -2421,7 +2420,7 @@
"name": "build dart",
"script": "tools/build.py",
"arguments": [
"runtime_kernel"
"runtime"
]
},
{
@@ -2973,7 +2972,7 @@
"--arch=ia32,x64",
"--mode=release",
"create_sdk",
"runtime_kernel"
"runtime"
]
},
{
@@ -3836,7 +3835,7 @@
"arguments": [
"--mode=debug,release",
"--arch=x64",
"runtime_kernel",
"runtime",
"dart_precompiled_runtime"
]
},
@@ -3847,7 +3846,7 @@
"--mode=release",
"--arch=x64",
"--sanitizer=tsan",
"runtime_kernel",
"runtime",
"dart_precompiled_runtime"
]
},