dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

CQ. Fix superclassName value for constConstructorWithNonConstSuper.

Browse Source 
Change-Id: Ib90558dfabf72b2a3743dc06b6bc4886eb65fbba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/508442
Reviewed-by: Johnni Winther <johnniwinther@google.com>
This commit is contained in:
Konstantin Shcheglov
2026-06-02 11:57:55 -07:00
parent 2cc79a0fec
commit 856afa7248
3 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/analyzer/lib/src/generated/error_verifier.dart
+3 -1
View File
@@ -3764,7 +3764,9 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
var errorRange = superInvocation?.sourceRange ?? implicitErrorRange;
diagnosticReporter.report(
diag.constConstructorWithNonConstSuper
.withArguments(superclassName: element.enclosingElement.displayName)
.withArguments(
superclassName: invokedSuper.enclosingElement.displayName,
)
.atSourceRange(errorRange),
);
return true;
pkg/analyzer/test/src/dart/resolution/super_constructor_invocation_test.dart
+1 -1
View File
@@ -127,7 +127,7 @@ class A {
class B extends A {
const B() : super(5);
// ^^^^^^^^
// [diag.constConstructorWithNonConstSuper] A constant constructor can't call a non-constant super constructor of 'B'.
// [diag.constConstructorWithNonConstSuper] A constant constructor can't call a non-constant super constructor of 'A'.
}
''');
pkg/analyzer/test/src/diagnostics/const_constructor_with_non_const_super_test.dart
+8 -8
View File
@@ -20,7 +20,7 @@ class A {}
class B extends A {
const new(): super();
// ^^^^^^^
// [diag.constConstructorWithNonConstSuper] A constant constructor can't call a non-constant super constructor of 'B'.
// [diag.constConstructorWithNonConstSuper] A constant constructor can't call a non-constant super constructor of 'A'.
}
''');
}
@@ -31,7 +31,7 @@ class A {}
class B extends A {
const B(): super();
// ^^^^^^^
// [diag.constConstructorWithNonConstSuper] A constant constructor can't call a non-constant super constructor of 'B'.
// [diag.constConstructorWithNonConstSuper] A constant constructor can't call a non-constant super constructor of 'A'.
}
''');
}
@@ -42,7 +42,7 @@ class A {}
class const B() extends A {
this : super();
// ^^^^^^^
// [diag.constConstructorWithNonConstSuper] A constant constructor can't call a non-constant super constructor of 'B'.
// [diag.constConstructorWithNonConstSuper] A constant constructor can't call a non-constant super constructor of 'A'.
}
''');
}
@@ -53,7 +53,7 @@ class A {}
class B extends A {
const new();
// ^^^
// [diag.constConstructorWithNonConstSuper] A constant constructor can't call a non-constant super constructor of 'B'.
// [diag.constConstructorWithNonConstSuper] A constant constructor can't call a non-constant super constructor of 'A'.
}
''');
}
@@ -64,7 +64,7 @@ class A {}
class B extends A {
const B();
// ^
// [diag.constConstructorWithNonConstSuper] A constant constructor can't call a non-constant super constructor of 'B'.
// [diag.constConstructorWithNonConstSuper] A constant constructor can't call a non-constant super constructor of 'A'.
}
''');
}
@@ -74,7 +74,7 @@ class B extends A {
class A {}
class const B() extends A {
// ^^^^^
// [diag.constConstructorWithNonConstSuper] A constant constructor can't call a non-constant super constructor of 'B'.
// [diag.constConstructorWithNonConstSuper] A constant constructor can't call a non-constant super constructor of 'A'.
this;
}
''');
@@ -85,7 +85,7 @@ class const B() extends A {
class A {}
class const B() extends A;
// ^^^^^
// [diag.constConstructorWithNonConstSuper] A constant constructor can't call a non-constant super constructor of 'B'.
// [diag.constConstructorWithNonConstSuper] A constant constructor can't call a non-constant super constructor of 'A'.
''');
}
@@ -114,7 +114,7 @@ class B extends A {
const B.foo() : this.bar();
const B.bar() : super._();
// ^^^^^^^^^
// [diag.constConstructorWithNonConstSuper] A constant constructor can't call a non-constant super constructor of 'B'.
// [diag.constConstructorWithNonConstSuper] A constant constructor can't call a non-constant super constructor of 'A'.
}
''');
}