dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Revert "[VM/Timeline] Reset flow_ids_ in TimelineEvent::Reset"

Browse Source 
This reverts commit 0d0e301979.

Reason for revert: breaks tests in G3, see b/286799580

Original change's description:
> [VM/Timeline] Reset flow_ids_ in TimelineEvent::Reset
>
> TEST=Ran the vm/cc/DartAPI_TimelineEvents_Serialization test with ASAN.
>
> Fixes: https://github.com/dart-lang/sdk/issues/52652
> Change-Id: I665c7fc6c8fa2a12c24b579386b1373f7e63792c
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308360
> Reviewed-by: Ben Konyi <bkonyi@google.com>
> Commit-Queue: Derek Xu <derekx@google.com>

Change-Id: I344320d97cb414f29b627859f71fba4967073062
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308660
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Ilya Yanok <yanok@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
This commit is contained in:
Ilya Yanok
2023-06-12 10:35:27 +00:00
committed by Commit Queue
parent d735c5d3bc
commit 84a6b3197b
1 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/vm/timeline.cc
+5 -9
View File
@@ -519,19 +519,15 @@ TimelineEvent::~TimelineEvent() {
}
void TimelineEvent::Reset() {
timestamp0_ = 0;
timestamp1_or_id_ = 0;
flow_id_count_ = 0;
flow_ids_.reset();
state_ = 0;
if (owns_label() && label_ != nullptr) {
free(const_cast<char*>(label_));
}
label_ = nullptr;
stream_ = nullptr;
state_ = 0;
thread_ = OSThread::kInvalidThreadId;
isolate_id_ = ILLEGAL_ISOLATE_ID;
isolate_group_id_ = ILLEGAL_ISOLATE_GROUP_ID;
isolate_id_ = ILLEGAL_PORT;
isolate_group_id_ = 0;
stream_ = nullptr;
label_ = nullptr;
arguments_.Free();
set_event_type(kNone);
set_pre_serialized_args(false);