dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Avoid call to deprecated X509_STORE_get0_objects

Browse Source 
X509_STORE_get0_objects is not thread-safe and also constrains
X509_STORE's internals in undesirable ways. See
https://github.com/openssl/openssl/pull/23224

TEST=ci

Change-Id: I0d501d92208e4af9de944b38c07cbcb66acaec66
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/407840
Auto-Submit: David Benjamin <davidben@google.com>
Commit-Queue: Brian Quinlan <bquinlan@google.com>
Reviewed-by: Brian Quinlan <bquinlan@google.com>
This commit is contained in:
David Benjamin
2025-02-25 14:24:38 -08:00
committed by Commit Queue
parent e0455b71b2
commit 7793a2e39c
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/bin/security_context_macos.cc
+2 -1
View File
@@ -146,7 +146,8 @@ static ssl_verify_result_t CertificateVerificationCallback(SSL* ssl,
CFArrayCreateMutable(nullptr, 0, nullptr));
ASSERT(store != nullptr);
for (const X509_OBJECT* obj : X509_STORE_get0_objects(store)) {
bssl::UniquePtr<STACK_OF(X509_OBJECT)> objs(X509_STORE_get1_objects(store));
for (const X509_OBJECT* obj : objs.get()) {
X509* ca = X509_OBJECT_get0_X509(obj);
ScopedSecCertificateRef cert(CreateSecCertificateFromX509(ca));
if (cert == nullptr) {