dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Refactor VM service IDs:

Browse Source 
- IDs are strings which can be concatenated together like paths.
- Isolate ID is now "/isolates/XXX"
- Function, field, class, library, and script IDs are now stable.
- Introduce <type-ref> tags.

R=turnidge@google.com

Review URL: https://codereview.chromium.org//98253009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31358 260f80e4-7a28-3924-810f-c04153c831b5
This commit is contained in:
johnmccutchan@google.com
2013-12-20 22:35:55 +00:00
parent 383468782e
commit 727d29d6b6
54 changed files with 39393 additions and 34058 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/standalone/vmservice/isolate_bad_class_test.dart
+3 -3
View File
@@ -10,16 +10,16 @@ import 'package:expect/expect.dart';
class NullCollectionTest extends VmServiceRequestHelper {
NullCollectionTest(port, id, collection) :
super('http://127.0.0.1:$port/isolates/$id/$collection/9999999');
super('http://127.0.0.1:$port/$id/$collection/9999999');
onRequestCompleted(Map reply) {
Expect.equals('null', reply['type']);
Expect.equals('Error', reply['type']);
}
}
class BadCollectionTest extends VmServiceRequestHelper {
BadCollectionTest(port, id, collection) :
super('http://127.0.0.1:$port/isolates/$id/$collection');
super('http://127.0.0.1:$port/$id/$collection');
onRequestCompleted(Map reply) {
Expect.equals('Error', reply['type']);
tests/standalone/vmservice/isolate_bad_object_test.dart
+2 -2
View File
@@ -10,7 +10,7 @@ import 'package:expect/expect.dart';
class NullCollectionTest extends VmServiceRequestHelper {
NullCollectionTest(port, id) :
super('http://127.0.0.1:$port/isolates/$id/objects/50');
super('http://127.0.0.1:$port/$id/objects/50');
onRequestCompleted(Map reply) {
Expect.equals('null', reply['type']);
@@ -19,7 +19,7 @@ class NullCollectionTest extends VmServiceRequestHelper {
class BadCollectionTest extends VmServiceRequestHelper {
BadCollectionTest(port, id) :
super('http://127.0.0.1:$port/isolates/$id/objects');
super('http://127.0.0.1:$port/$id/objects');
onRequestCompleted(Map reply) {
Expect.equals('Error', reply['type']);
tests/standalone/vmservice/isolate_class_field_test.dart
+1 -1
View File
@@ -140,7 +140,7 @@ class BadBananaClassTest {
class ClassTableTest extends VmServiceRequestHelper {
ClassTableTest(port, id) :
super('http://127.0.0.1:$port/isolates/$id/classes/');
super('http://127.0.0.1:$port/$id/classes/');
int banana_class_id;
int bad_banana_class_id;
tests/standalone/vmservice/isolate_class_test.dart
+3 -3
View File
@@ -10,7 +10,7 @@ import 'package:expect/expect.dart';
class ClassTest extends VmServiceRequestHelper {
ClassTest(port, id, classId) :
super('http://127.0.0.1:$port/isolates/$id/classes/$classId');
super('http://127.0.0.1:$port/$id/$classId');
onRequestCompleted(Map reply) {
Expect.equals('Class', reply['type']);
@@ -22,7 +22,7 @@ class ClassTest extends VmServiceRequestHelper {
class LibraryTest extends VmServiceRequestHelper {
LibraryTest(port, id, libId) :
super('http://127.0.0.1:$port/isolates/$id/objects/$libId');
super('http://127.0.0.1:$port/$id/$libId');
int _classId;
onRequestCompleted(Map reply) {
@@ -37,7 +37,7 @@ class LibraryTest extends VmServiceRequestHelper {
class RootLibraryTest extends VmServiceRequestHelper {
RootLibraryTest(port, id) :
super('http://127.0.0.1:$port/isolates/$id/library');
super('http://127.0.0.1:$port/$id/library');
int _libId;
onRequestCompleted(Map reply) {
tests/standalone/vmservice/isolate_code_test.dart
+3 -3
View File
@@ -10,7 +10,7 @@ import 'package:expect/expect.dart';
class CodeATest extends VmServiceRequestHelper {
CodeATest(port, id, codeId) :
super('http://127.0.0.1:$port/isolates/$id/objects/$codeId');
super('http://127.0.0.1:$port/$id/$codeId');
onRequestCompleted(Map reply) {
Expect.equals('Code', reply['type']);
@@ -21,7 +21,7 @@ class CodeATest extends VmServiceRequestHelper {
class CodeCTest extends VmServiceRequestHelper {
CodeCTest(port, id, codeId) :
super('http://127.0.0.1:$port/isolates/$id/objects/$codeId');
super('http://127.0.0.1:$port/$id/$codeId');
onRequestCompleted(Map reply) {
Expect.equals('Code', reply['type']);
@@ -32,7 +32,7 @@ class CodeCTest extends VmServiceRequestHelper {
class StackTraceTest extends VmServiceRequestHelper {
StackTraceTest(port, id) :
super('http://127.0.0.1:$port/isolates/$id/stacktrace');
super('http://127.0.0.1:$port/$id/stacktrace');
int _aId;
int _cId;
tests/standalone/vmservice/isolate_echo_test.dart
+1 -1
View File
@@ -9,7 +9,7 @@ import 'package:expect/expect.dart';
class EchoRequestTest extends VmServiceRequestHelper {
EchoRequestTest(port, id) :
super('http://127.0.0.1:$port/isolates/$id/_echo/foo/bar?a=b&k=&d=e&z=w');
super('http://127.0.0.1:$port/$id/_echo/foo/bar?a=b&k=&d=e&z=w');
onRequestCompleted(Map reply) {
Expect.equals('message', reply['type']);
tests/standalone/vmservice/isolate_function_test.dart
+3 -3
View File
@@ -10,7 +10,7 @@ import 'package:expect/expect.dart';
class MethodTest extends VmServiceRequestHelper {
MethodTest(port, id, functionId) :
super('http://127.0.0.1:$port/isolates/$id/objects/$functionId');
super('http://127.0.0.1:$port/$id/$functionId');
onRequestCompleted(Map reply) {
Expect.equals('Function', reply['type']);
Expect.equals('C.c', reply['user_name']);
@@ -20,7 +20,7 @@ class MethodTest extends VmServiceRequestHelper {
class FunctionTest extends VmServiceRequestHelper {
FunctionTest(port, id, functionId) :
super('http://127.0.0.1:$port/isolates/$id/objects/$functionId');
super('http://127.0.0.1:$port/$id/$functionId');
onRequestCompleted(Map reply) {
Expect.equals('Function', reply['type']);
@@ -31,7 +31,7 @@ class FunctionTest extends VmServiceRequestHelper {
class StackTraceTest extends VmServiceRequestHelper {
StackTraceTest(port, id) :
super('http://127.0.0.1:$port/isolates/$id/stacktrace');
super('http://127.0.0.1:$port/$id/stacktrace');
int _aId;
int _cId;
tests/standalone/vmservice/isolate_library_test.dart
+2 -2
View File
@@ -10,7 +10,7 @@ import 'package:expect/expect.dart';
class LibraryTest extends VmServiceRequestHelper {
LibraryTest(port, id, libId) :
super('http://127.0.0.1:$port/isolates/$id/objects/$libId');
super('http://127.0.0.1:$port/$id/$libId');
onRequestCompleted(Map reply) {
Expect.equals('Library', reply['type']);
@@ -20,7 +20,7 @@ class LibraryTest extends VmServiceRequestHelper {
class RootLibraryTest extends VmServiceRequestHelper {
RootLibraryTest(port, id) :
super('http://127.0.0.1:$port/isolates/$id/library');
super('http://127.0.0.1:$port/$id/library');
int _libId;
onRequestCompleted(Map reply) {
tests/standalone/vmservice/isolate_stacktrace_command_test.dart
+1 -1
View File
@@ -9,7 +9,7 @@ import 'package:expect/expect.dart';
class StacktraceTest extends VmServiceRequestHelper {
StacktraceTest(port, id) :
super('http://127.0.0.1:$port/isolates/$id/stacktrace');
super('http://127.0.0.1:$port/$id/stacktrace');
onRequestCompleted(Map reply) {
Expect.equals('StackTrace', reply['type'], 'Not a StackTrace message.');
tests/standalone/vmservice/test_helper.dart
+2 -2
View File
@@ -255,7 +255,7 @@ class ClassTableHelper {
class FieldRequestHelper extends VmServiceRequestHelper {
FieldRequestHelper(port, isolate_id, field_id) :
super('http://127.0.0.1:$port/isolates/$isolate_id/objects/$field_id');
super('http://127.0.0.1:$port/$isolate_id/$field_id');
Map field;
onRequestCompleted(Map reply) {
Expect.equals('Field', reply['type']);
@@ -269,7 +269,7 @@ class ClassFieldRequestHelper extends VmServiceRequestHelper {
int port_;
int isolate_id_;
ClassFieldRequestHelper(port, isolate_id, class_id, this.fieldNames) :
super('http://127.0.0.1:$port/isolates/$isolate_id/classes/$class_id') {
super('http://127.0.0.1:$port/$isolate_id/$class_id') {
port_ = port;
isolate_id_ = isolate_id;
}
tests/standalone/vmservice/unknown_isolate_command_test.dart
+1 -1
View File
@@ -10,7 +10,7 @@ import 'package:expect/expect.dart';
class ClassTableTest extends VmServiceRequestHelper {
ClassTableTest(port, id) :
super('http://127.0.0.1:$port/isolates/$id/classes');
super('http://127.0.0.1:$port/$id/classes');
onRequestCompleted(Map reply) {
ClassTableHelper helper = new ClassTableHelper(reply);