From 727d29d6b6d4324595750411647789d2fd39dbb4 Mon Sep 17 00:00:00 2001 From: "johnmccutchan@google.com" Date: Fri, 20 Dec 2013 22:35:55 +0000 Subject: [PATCH] Refactor VM service IDs: - IDs are strings which can be concatenated together like paths. - Isolate ID is now "/isolates/XXX" - Function, field, class, library, and script IDs are now stable. - Introduce tags. R=turnidge@google.com Review URL: https://codereview.chromium.org//98253009 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31358 260f80e4-7a28-3924-810f-c04153c831b5 --- .../client/{build.dart => build_.dart} | 0 .../vmservice/client/deployed/web/index.html | 148 +- .../deployed/web/index.html_bootstrap.dart.js | 24617 ++++---- .../client/deployed/web/index_devtools.html | 148 +- .../web/index_devtools.html_bootstrap.dart.js | 47134 ++++++++-------- .../client/lib/observatory_elements.dart | 8 +- .../client/lib/observatory_elements.html | 7 + .../client/lib/src/observatory/isolate.dart | 2 +- .../lib/src/observatory/isolate_manager.dart | 6 +- .../lib/src/observatory/location_manager.dart | 78 +- .../lib/src/observatory/request_manager.dart | 61 +- .../src/observatory_elements/class_ref.dart | 13 + .../src/observatory_elements/class_ref.html | 9 + .../src/observatory_elements/class_view.html | 18 +- .../src/observatory_elements/code_ref.dart | 13 + .../src/observatory_elements/code_ref.html | 9 + .../src/observatory_elements/code_view.html | 5 +- .../src/observatory_elements/field_ref.dart | 5 +- .../src/observatory_elements/field_ref.html | 18 +- .../src/observatory_elements/field_view.html | 15 +- .../observatory_elements/function_ref.dart | 13 + .../observatory_elements/function_ref.html | 9 + .../observatory_elements/function_view.html | 12 +- .../observatory_elements/instance_ref.dart | 12 +- .../observatory_elements/instance_ref.html | 15 +- .../observatory_elements/instance_view.html | 12 +- .../observatory_elements/isolate_summary.dart | 2 +- .../src/observatory_elements/library_ref.dart | 13 + .../src/observatory_elements/library_ref.html | 9 + .../observatory_elements/library_view.html | 28 +- .../observatory_elements/navigation_bar.html | 4 - .../observatory_element.dart | 4 + .../src/observatory_elements/script_ref.dart | 13 + .../src/observatory_elements/script_ref.html | 10 + .../src/observatory_elements/service_ref.dart | 38 + .../src/observatory_elements/service_ref.html | 6 + .../src/observatory_elements/stack_trace.html | 8 +- runtime/bin/vmservice/running_isolates.dart | 5 +- runtime/vm/object.cc | 271 +- runtime/vm/object.h | 9 +- runtime/vm/object_test.cc | 162 + runtime/vm/service.cc | 226 +- runtime/vm/service_test.cc | 212 + .../vmservice/isolate_bad_class_test.dart | 6 +- .../vmservice/isolate_bad_object_test.dart | 4 +- .../vmservice/isolate_class_field_test.dart | 2 +- .../vmservice/isolate_class_test.dart | 6 +- .../vmservice/isolate_code_test.dart | 6 +- .../vmservice/isolate_echo_test.dart | 2 +- .../vmservice/isolate_function_test.dart | 6 +- .../vmservice/isolate_library_test.dart | 4 +- .../isolate_stacktrace_command_test.dart | 2 +- tests/standalone/vmservice/test_helper.dart | 4 +- .../unknown_isolate_command_test.dart | 2 +- 54 files changed, 39393 insertions(+), 34058 deletions(-) rename runtime/bin/vmservice/client/{build.dart => build_.dart} (100%) create mode 100644 runtime/bin/vmservice/client/lib/src/observatory_elements/class_ref.dart create mode 100644 runtime/bin/vmservice/client/lib/src/observatory_elements/class_ref.html create mode 100644 runtime/bin/vmservice/client/lib/src/observatory_elements/code_ref.dart create mode 100644 runtime/bin/vmservice/client/lib/src/observatory_elements/code_ref.html create mode 100644 runtime/bin/vmservice/client/lib/src/observatory_elements/function_ref.dart create mode 100644 runtime/bin/vmservice/client/lib/src/observatory_elements/function_ref.html create mode 100644 runtime/bin/vmservice/client/lib/src/observatory_elements/library_ref.dart create mode 100644 runtime/bin/vmservice/client/lib/src/observatory_elements/library_ref.html create mode 100644 runtime/bin/vmservice/client/lib/src/observatory_elements/script_ref.dart create mode 100644 runtime/bin/vmservice/client/lib/src/observatory_elements/script_ref.html create mode 100644 runtime/bin/vmservice/client/lib/src/observatory_elements/service_ref.dart create mode 100644 runtime/bin/vmservice/client/lib/src/observatory_elements/service_ref.html diff --git a/runtime/bin/vmservice/client/build.dart b/runtime/bin/vmservice/client/build_.dart similarity index 100% rename from runtime/bin/vmservice/client/build.dart rename to runtime/bin/vmservice/client/build_.dart diff --git a/runtime/bin/vmservice/client/deployed/web/index.html b/runtime/bin/vmservice/client/deployed/web/index.html index b226dd56531..9b5881fa82f 100644 --- a/runtime/bin/vmservice/client/deployed/web/index.html +++ b/runtime/bin/vmservice/client/deployed/web/index.html @@ -29,7 +29,15 @@ - + + + + + + + - +