dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

change the java impl of the vm service protocol library to support new major protocol versions

Browse Source 
Change-Id: I0a954cbcf1103f999575f7d923037ae342f4256c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162140
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This commit is contained in:
Devon Carew
2020-09-09 16:04:09 +00:00
committed by commit-bot@chromium.org
parent 6daf283c96
commit 70eb699641
2 changed files with 1 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/dds/lib/dds.dart
+1 -1
View File
@@ -114,7 +114,7 @@ abstract class DartDevelopmentService {
/// Stop accepting requests after gracefully handling existing requests.
Future<void> shutdown();
/// Set to `true` if this isntance of [DartDevelopmentService] requires an
/// Set to `true` if this instance of [DartDevelopmentService] requires an
/// authentication code to connect.
bool get authCodesEnabled;
pkg/vm_service/java/src/org/dartlang/vm/service/VmServiceBase.java
-15
View File
@@ -132,21 +132,6 @@ abstract class VmServiceBase implements VmServiceConst {
@Override
public void received(Version version) {
int major = version.getMajor();
int minor = version.getMinor();
if (major != VmService.versionMajor || minor != VmService.versionMinor) {
if (major == 2 || major == 3) {
Logging.getLogger().logInformation(
"Difference in protocol version: client=" + VmService.versionMajor + "."
+ VmService.versionMinor + " vm=" + major + "." + minor);
} else {
String msg = "Incompatible protocol version: client=" + VmService.versionMajor + "."
+ VmService.versionMinor + " vm=" + major + "." + minor;
Logging.getLogger().logError(msg);
errMsg[0] = msg;
}
}
vmService.runtimeVersion = version;
latch.countDown();