dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Bump wasm packages to language version 3.12.

Browse Source 
This CL is part of an effort to bump the SDK requirement to `3.12.0-0`
for all the packages in `pkg` that are not published to `pub`, so that
we can get better testing of the "private named parameters" feature.

(Packages that *are* published to `pub` can't be safely bumped yet,
because SDK 3.12 hasn't been released, and I don't want to block those
packages' ability to publish useful updates to customers.)

This change covers the following packages, which are owned by
OWNERS_WASM:
- pkg/dart2wasm
- pkg/wasm_builder

Changes to `pubspec.yaml` files were made manually.

Changes to `.dart` files were made automatically, using `dart fix` to
fix failures in the unnecessary_underscores lint.

Change-Id: Ia83ba9109dcd3d488755d2df990dd2496a6a6964
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/487944
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
This commit is contained in:
Paul Berry
2026-03-16 05:13:37 -07:00
committed by Commit Queue
parent 5190320af8
commit 6eb6232be7
5 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/dart2wasm/lib/code_generator.dart
+5 -5
View File
@@ -1870,7 +1870,7 @@ abstract class AstCodeGenerator
}
}
void right([_, __]) {
void right([_, _]) {
b.local_get(rightLocal);
if (rightNullable) {
b.ref_as_non_null();
@@ -2127,7 +2127,7 @@ abstract class AstCodeGenerator
w.Label nullLabel = b.block();
translateExpression(node.receiver, translator.topType);
b.br_on_null(nullLabel);
}, (_, __) {}, useUncheckedEntry: false);
}, (_, _) {}, useUncheckedEntry: false);
b.br(doneLabel);
b.end(); // nullLabel
switch (target.name.text) {
@@ -2160,7 +2160,7 @@ abstract class AstCodeGenerator
_VirtualCallKind.Get,
(signature) =>
translateExpression(node.receiver, signature.inputs.first),
(_, __) {},
(_, _) {},
useUncheckedEntry: false);
}
}
@@ -2231,7 +2231,7 @@ abstract class AstCodeGenerator
translateExpression(node.receiver, translator.topType);
b.br_on_null(nullLabel);
translator.convertType(b, translator.topType, signature.inputs[0]);
}, (_, __) {}, useUncheckedEntry: false);
}, (_, _) {}, useUncheckedEntry: false);
b.br(doneLabel);
b.end(); // nullLabel
switch (target.name.text) {
@@ -2262,7 +2262,7 @@ abstract class AstCodeGenerator
_VirtualCallKind.Get,
(signature) =>
translateExpression(node.receiver, signature.inputs.first),
(_, __) {},
(_, _) {},
useUncheckedEntry: false);
}
pkg/dart2wasm/lib/constants.dart
+13 -13
View File
@@ -354,7 +354,7 @@ class Constants {
final info = ConstantInfo(
constant,
children,
(_, __) {
(_, _) {
throw StateError(
'Should not try to generate code for imported constant');
},
@@ -362,7 +362,7 @@ class Constants {
needsRuntimeCanonicalization,
exportByMainApp,
type,
(_, __, ___) {
(_, _, _) {
throw StateError(
'Should not try to generate code for imported constant');
});
@@ -727,7 +727,7 @@ class ConstantCreator extends ConstantVisitor<ConstantInfo?>
return ConstantInfo(
constant,
childConstants,
forceLazyConstant ?? (_, __) => false,
forceLazyConstant ?? (_, _) => false,
canBeEager,
needsRuntimeCanonicalization,
exportByMainApp,
@@ -742,7 +742,7 @@ class ConstantCreator extends ConstantVisitor<ConstantInfo?>
ConstantInfo? visitBoolConstant(BoolConstant constant) {
ClassInfo info = translator.classInfo[translator.boxedBoolClass]!;
return createConstant(constant, const [], info.nonNullableType,
canBeEager: true, (_, b, __) {
canBeEager: true, (_, b, _) {
b.i32_const((info.classId as AbsoluteClassId).value);
b.i32_const(constant.value ? 1 : 0);
b.struct_new(info.struct);
@@ -753,7 +753,7 @@ class ConstantCreator extends ConstantVisitor<ConstantInfo?>
ConstantInfo? visitIntConstant(IntConstant constant) {
ClassInfo info = translator.classInfo[translator.boxedIntClass]!;
return createConstant(constant, const [], info.nonNullableType,
canBeEager: true, (_, b, __) {
canBeEager: true, (_, b, _) {
b.i32_const((info.classId as AbsoluteClassId).value);
b.i64_const(constant.value);
b.struct_new(info.struct);
@@ -764,7 +764,7 @@ class ConstantCreator extends ConstantVisitor<ConstantInfo?>
ConstantInfo? visitDoubleConstant(DoubleConstant constant) {
ClassInfo info = translator.classInfo[translator.boxedDoubleClass]!;
return createConstant(constant, const [], info.nonNullableType,
canBeEager: true, (_, b, __) {
canBeEager: true, (_, b, _) {
b.i32_const((info.classId as AbsoluteClassId).value);
b.f64_const(constant.value);
b.struct_new(info.struct);
@@ -775,7 +775,7 @@ class ConstantCreator extends ConstantVisitor<ConstantInfo?>
ConstantInfo? visitStringConstant(StringConstant constant) {
ClassInfo info = translator.classInfo[translator.jsStringClass]!;
return createConstant(constant, const [], info.nonNullableType,
canBeEager: true, (_, b, __) {
canBeEager: true, (_, b, _) {
b.pushObjectHeaderFields(translator, info);
translator.globals.readGlobal(
b,
@@ -856,7 +856,7 @@ class ConstantCreator extends ConstantVisitor<ConstantInfo?>
lazy |= info.classId is RelativeClassId;
return createConstant(constant, childConstants, type, canBeEager: !lazy,
(_, b, __) {
(_, b, _) {
b.pushObjectHeaderFields(translator, info);
for (int i = FieldIndex.objectFieldBase; i < fieldCount; i++) {
Constant subConstant = subConstants[i]!;
@@ -896,7 +896,7 @@ class ConstantCreator extends ConstantVisitor<ConstantInfo?>
return createConstant(
constant, childConstants, w.RefType.def(arrayType, nullable: false),
canBeEager: !tooLargeForArrayNewFixed, (_, b, __) {
canBeEager: !tooLargeForArrayNewFixed, (_, b, _) {
if (tooLargeForArrayNewFixed) {
// We use WasmArray<WasmI32> for some RTT data structures. Those arrays
// can get rather large and cross the 10k limit.
@@ -1141,7 +1141,7 @@ class ConstantCreator extends ConstantVisitor<ConstantInfo?>
final vtableModule = closure.vtable.enclosingModule;
return constantModule != vtableModule &&
vtableModule != translator.mainModule.module;
}, (cinfo, b, __) {
}, (cinfo, b, _) {
b.pushObjectHeaderFields(translator, closureClassInfo);
translator
.getDummyValuesCollectorForModule(b.moduleBuilder)
@@ -1367,7 +1367,7 @@ class ConstantCreator extends ConstantVisitor<ConstantInfo?>
}
return createConstant(constant, childConstants, info.nonNullableType,
canBeEager: true, (_, b, __) {
canBeEager: true, (_, b, _) {
b.pushObjectHeaderFields(translator, info);
constants.instantiateConstant(b, nameConstant, stringType);
b.struct_new(info.struct);
@@ -1393,7 +1393,7 @@ class ConstantCreator extends ConstantVisitor<ConstantInfo?>
return createConstant(
constant, childConstants, recordClassInfo.nonNullableType,
canBeEager: true, (_, b, __) {
canBeEager: true, (_, b, _) {
b.pushObjectHeaderFields(translator, recordClassInfo);
for (Constant argument in arguments) {
constants.instantiateConstant(b, argument, translator.topType);
@@ -1422,7 +1422,7 @@ class ConstantCreator extends ConstantVisitor<ConstantInfo?>
return createConstant(
constant, childConstants, w.RefType(type, nullable: false),
canBeEager: true, (_, b, __) {
canBeEager: true, (_, b, _) {
translator.instantiateDummyValueHeapType(b, type, constant.name,
(ib, heapType) {
constants.instantiateConstant(
pkg/dart2wasm/lib/intrinsics.dart
+1 -1
View File
@@ -2866,7 +2866,7 @@ class Intrinsifier {
b.if_([], [translator.nullableObjectArrayTypeRef]);
translator.makeArray(
b, translator.nullableObjectArrayType, 0, (_, __) {});
b, translator.nullableObjectArrayType, 0, (_, _) {});
b.else_();
// List argument may be a custom list type, convert it to `WasmListBase`
pkg/dart2wasm/pubspec.yaml
+1 -1
View File
@@ -2,7 +2,7 @@ name: dart2wasm
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
environment:
sdk: ^3.6.0
sdk: '^3.12.0-0'
resolution: workspace
pkg/wasm_builder/pubspec.yaml
+1 -1
View File
@@ -4,7 +4,7 @@ publish_to: none
description: Generate binary Wasm modules
environment:
sdk: ^3.5.0
sdk: '^3.12.0-0'
resolution: workspace