dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[vm/compiler] Make StopInstr methods architecture-independent.

Browse Source 
The Stop assembler macro was abstracted in AssemblerBase a while back,
so all of the architecture-dependent StopInstr::MakeLocationSummary
and StopInstr::EmitNativeCode implementations are the same. Replace
them with a single architecture-independent implementation in il.cc.

TEST=ci (refactoring cleanup)

Change-Id: I29e16bd70ab5733417e664c2946abe492d3b0d2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379301
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
This commit is contained in:
Tess Strickland
2024-08-07 11:32:28 +00:00
committed by Commit Queue
parent c50c194d41
commit 6cbe05e6c0
6 changed files with 8 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/vm/compiler/backend/il.cc
+8
View File
@@ -4526,6 +4526,14 @@ void IndirectEntryInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
JoinEntryInstr::EmitNativeCode(compiler);
}
LocationSummary* StopInstr::MakeLocationSummary(Zone* zone, bool opt) const {
return new (zone) LocationSummary(zone, 0, 0, LocationSummary::kNoCall);
}
void StopInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ Stop(message());
}
LocationSummary* LoadStaticFieldInstr::MakeLocationSummary(Zone* zone,
bool opt) const {
const intptr_t kNumInputs = 0;
runtime/vm/compiler/backend/il_arm.cc
-8
View File
@@ -7207,14 +7207,6 @@ void BitCastInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
}
}
LocationSummary* StopInstr::MakeLocationSummary(Zone* zone, bool opt) const {
return new (zone) LocationSummary(zone, 0, 0, LocationSummary::kNoCall);
}
void StopInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ Stop(message());
}
void GraphEntryInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
BlockEntryInstr* entry = normal_entry();
if (entry != nullptr) {
runtime/vm/compiler/backend/il_arm64.cc
-8
View File
@@ -6241,14 +6241,6 @@ void BitCastInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
}
}
LocationSummary* StopInstr::MakeLocationSummary(Zone* zone, bool opt) const {
return new (zone) LocationSummary(zone, 0, 0, LocationSummary::kNoCall);
}
void StopInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ Stop(message());
}
void GraphEntryInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
BlockEntryInstr* entry = normal_entry();
if (entry != nullptr) {
runtime/vm/compiler/backend/il_ia32.cc
-8
View File
@@ -6210,14 +6210,6 @@ void IntConverterInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
}
}
LocationSummary* StopInstr::MakeLocationSummary(Zone* zone, bool opt) const {
return new (zone) LocationSummary(zone, 0, 0, LocationSummary::kNoCall);
}
void StopInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ Stop(message());
}
void GraphEntryInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
BlockEntryInstr* entry = normal_entry();
if (entry != nullptr) {
runtime/vm/compiler/backend/il_riscv.cc
-8
View File
@@ -7144,14 +7144,6 @@ void BitCastInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
}
}
LocationSummary* StopInstr::MakeLocationSummary(Zone* zone, bool opt) const {
return new (zone) LocationSummary(zone, 0, 0, LocationSummary::kNoCall);
}
void StopInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ Stop(message());
}
void GraphEntryInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
BlockEntryInstr* entry = normal_entry();
if (entry != nullptr) {
runtime/vm/compiler/backend/il_x64.cc
-8
View File
@@ -6478,14 +6478,6 @@ void IntConverterInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
}
}
LocationSummary* StopInstr::MakeLocationSummary(Zone* zone, bool opt) const {
return new (zone) LocationSummary(zone, 0, 0, LocationSummary::kNoCall);
}
void StopInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ Stop(message());
}
void GraphEntryInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
BlockEntryInstr* entry = normal_entry();
if (entry != nullptr) {