dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Skip regress_41329 tests on precompiled runtimes

Browse Source 
(these tests target the dartdev workflow which is not supported in
 the precompiled runtime).

Also updated regress_41329_relative_test to not be a duplicate of the
absolute test.

Change-Id: I1df086c8cb2b6a03fad0043bc1f63b08370fdbae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165120
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
This commit is contained in:
Ben Konyi
2020-09-30 16:18:34 +00:00
committed by commit-bot@chromium.org
parent 3198d7c307
commit 6bc7248049
4 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/standalone/regress_41329_absolute_test.dart
+2 -2
View File
@@ -19,7 +19,7 @@ Future<void> main() async {
// /usr/local/Cellar/dart/2.8.0-dev.20.0/bin/dart -> $DART_SDK/bin/dart
Directory.current = a;
final linkLocation = '../Cellar/dart/2.8.0-dev.20.0/bin/dart';
final linkLocation = '${d.path}/usr/local/bin/Cellar/dart/2.8.0-dev.20.0/bin/dart';
final link = Link(linkLocation);
link.createSync(exePath, recursive: true);
@@ -27,6 +27,6 @@ Future<void> main() async {
final link2 = Link('dart')..createSync(linkLocation, recursive: true);
final path = Uri.parse(link2.absolute.path).path;
Directory.current = origDir;
final result = await Process.run('${path}', ['help']);
final result = await Process.run('$path', ['help']);
Expect.equals(result.exitCode, 0);
}
tests/standalone/standalone_precompiled.status
+1
View File
@@ -54,6 +54,7 @@ package/scenarios/packages_file_strange_formatting/empty_lines_test: Skip
package/scenarios/packages_file_strange_formatting/mixed_line_ends_test: Skip
package/scenarios/packages_option_only/packages_option_only_noimports_test: Skip
package/scenarios/packages_option_only/packages_option_only_test: Skip
regress_41329_*: SkipByDesign # Expects to find the test directory relative to the script.
[ $arch == arm && $mode == release && $runtime == dart_precompiled && $system == android ]
io/socket_cancel_connect_test: RuntimeError # Issue 34142
tests/standalone_2/regress_41329_absolute_test.dart
+2 -2
View File
@@ -19,7 +19,7 @@ Future<void> main() async {
// /usr/local/Cellar/dart/2.8.0-dev.20.0/bin/dart -> $DART_SDK/bin/dart
Directory.current = a;
final linkLocation = '../Cellar/dart/2.8.0-dev.20.0/bin/dart';
final linkLocation = '${d.path}/usr/local/bin/Cellar/dart/2.8.0-dev.20.0/bin/dart';
final link = Link(linkLocation);
link.createSync(exePath, recursive: true);
@@ -27,6 +27,6 @@ Future<void> main() async {
final link2 = Link('dart')..createSync(linkLocation, recursive: true);
final path = Uri.parse(link2.absolute.path).path;
Directory.current = origDir;
final result = await Process.run('${path}', ['help']);
final result = await Process.run('$path', ['help']);
Expect.equals(result.exitCode, 0);
}
tests/standalone_2/standalone_2_precompiled.status
+1
View File
@@ -51,6 +51,7 @@ package/scenarios/packages_file_strange_formatting/empty_lines_test: Skip
package/scenarios/packages_file_strange_formatting/mixed_line_ends_test: Skip
package/scenarios/packages_option_only/packages_option_only_noimports_test: Skip
package/scenarios/packages_option_only/packages_option_only_test: Skip
regress_41329_*: SkipByDesign # Expects to be running from 'dart' instead of 'dart_precompiled_runtime'
[ $arch == arm && $mode == release && $runtime == dart_precompiled && $system == android ]
io/socket_cancel_connect_test: RuntimeError # Issue 34142