dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[build] Skip unnecessary read when using incbin.

Browse Source 
Change-Id: I7eb56ec2a29ecaf4f4ce578f9666436969cbe15d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510041
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
This commit is contained in:
Ryan Macnak
2026-06-08 11:05:48 -07:00
committed by dart-scoped@luci-project-accounts.iam.gserviceaccount.com
parent 28d7984e31
commit 5955f2b806
1 changed files with 11 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/tools/bin_to_assembly.py
+11 -16
View File
@@ -89,22 +89,17 @@ def Main():
output_file.write(".balign 64\n")
output_file.write("%s:\n" % options.symbol_name)
size = 0
with open(options.input, "rb") as input_file:
if options.target_os in ["win"]:
for byte in input_file.read():
output_file.write("byte %d\n" % (byte if isinstance(byte, int) else ord(byte)))
size += 1
else:
incbin = options.incbin
for byte in input_file.read():
size += 1
if not incbin:
output_file.write(
".byte %d\n" %
(byte if isinstance(byte, int) else ord(byte)))
if incbin:
output_file.write(".incbin \"%s\"\n" % options.input)
size = os.path.getsize(options.input)
if options.incbin:
output_file.write(".incbin \"%s\"\n" % options.input)
else:
with open(options.input, "rb") as input_file:
if options.target_os in ["win"]:
for byte in input_file.read():
output_file.write("byte %d\n" % byte)
else:
for byte in input_file.read():
output_file.write(".byte %d\n" % byte)
if options.target_os not in ["mac", "ios", "watchos", "win", "win_gnu"]:
output_file.write(".size {0}, .-{0}\n".format(options.symbol_name))