[windows] Fix hang on crash?

Try passing another flag to SetErrorMode(), which seems to work locally.
On the bots, who knows?

related #30202, #30850

Change-Id: Id3f14bc883008f8f0e743617d1ae5a1cc62e34a0
Reviewed-on: https://dart-review.googlesource.com/7631
Reviewed-by: Alexander Markov <alexmarkov@google.com>

runtime/bin/platform_win.cc

@@ -57,7 +57,8 @@ class PlatformWin {
     // Disable dialog boxes for "critical" errors or when OpenFile cannot find
     // the requested file. See:
     // See: https://msdn.microsoft.com/en-us/library/windows/desktop/ms680621(v=vs.85).aspx
-    SetErrorMode(SEM_FAILCRITICALERRORS | SEM_NOOPENFILEERRORBOX);
+    SetErrorMode(SEM_FAILCRITICALERRORS | SEM_NOOPENFILEERRORBOX |
+                 SEM_NOGPFAULTERRORBOX);
     // Set up a signal handler that restores the console state on a
     // CTRL_C_EVENT signal. This will only run when there is no signal handler
     // registered for the CTRL_C_EVENT from Dart code.

runtime/tests/vm/vm.status

@@ -11,8 +11,10 @@ cc/IsolateReload_PendingStaticCall_DefinedToNSM: SkipSlow
 cc/IsolateReload_PendingStaticCall_NSMToDefined: SkipSlow
 
 # These tests are expected to crash on all platforms.
-cc/ArrayNew_Overflow_Crash: SkipSlow
-cc/AllocGeneric_Overflow: SkipSlow
+cc/ArrayNew_Overflow_Crash: Crash, Fail
+cc/AllocGeneric_Overflow: Crash, Fail
+cc/CodeImmutability: Crash, Fail
+cc/SNPrint_BadArgs: Crash, Fail
 cc/Fail0: Fail
 cc/Fail1: Fail
 cc/Fail2: Fail
@@ -20,8 +22,6 @@ cc/Fail2: Fail
 cc/Dart2JSCompileAll: Fail, Crash # Issue 27369
 cc/Dart2JSCompilerStats: Fail, Crash # Issue 27369
 
-cc/SNPrint_BadArgs: Skip
-
 cc/Profiler_InliningIntervalBoundry: Skip # Differences in ia32, debug, release
 
 # Flaky on buildbot. Issue 5133 and 10409.
@@ -39,15 +39,8 @@ cc/VerifyExplicit_Crash: Crash
 # It can take some time for all the isolates to shutdown in a Debug build.
 dart/spawn_shutdown_test: Pass, Slow  # VM Shutdown test
 
-# CodeImmutability test ocassionally times out on Windows. Issue #30202.
-[ $system != windows ]
-cc/CodeImmutability: Crash
-
 [ $system == windows ]
-cc/CodeImmutability: Crash, Timeout
-cc/Dart2JSCompileAll: Skip
 cc/Service_Profile: Skip
-cc/Dart2JSCompilerStats: Skip
 cc/CorelibCompilerStats: Skip
 
 [ $system == fuchsia ]