dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fixes for service.md.

Browse Source 
- getInstances needs a param for isolateId. Without this param, we see runtime errors.
- InstanceSet needs instances to have type @Object[]. We see types of objects here other than
  InstanceRefs (ObjRef, FieldRef, etc.), and we need to be able to handle all types. If we do
  not, we see runtime errors.
- getVMTimeline params should be optional. Before this method was made public, you did not
  have to specify origin / extent times to pull the timeline.

Fixes https://github.com/dart-lang/sdk/issues/37349.
Fixes https://github.com/dart-lang/sdk/issues/37351.


Change-Id: Icb9874cfb102268cc561978a74c11cac02bcfc0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107190
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Kenzie Schmoll <kenzieschmoll@google.com>
This commit is contained in:
Kenzie Schmoll
2019-06-25 19:14:52 +00:00
committed by commit-bot@chromium.org
parent bb42e9dad3
commit 3e732e5bbe
2 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/vm/service/service.md
+5 -4
View File
@@ -643,7 +643,8 @@ See [FlagList](#flaglist).
### getInstances
```
InstanceSet getInstances(string objectId,
InstanceSet getInstances(string isolateId,
string objectId,
int limit)
```
@@ -806,8 +807,8 @@ See [VM](#vm).
### getVMTimeline
```
Timeline getVMTimeline(int timeOriginMicros,
int timeExtentMicros)
Timeline getVMTimeline(int timeOriginMicros [optional],
int timeExtentMicros [optional])
```
The _getVMTimeline_ RPC is used to retrieve an object which contains VM timeline
@@ -2318,7 +2319,7 @@ class InstanceSet extends Response {
int totalCount;
// An array of instances of the requested type.
@Instance[] instances;
@Object[] instances;
}
```
runtime/vm/service/service_dev.md
+5 -4
View File
@@ -643,7 +643,8 @@ See [FlagList](#flaglist).
### getInstances
```
InstanceSet getInstances(string objectId,
InstanceSet getInstances(string isolateId,
string objectId,
int limit)
```
@@ -806,8 +807,8 @@ See [VM](#vm).
### getVMTimeline
```
Timeline getVMTimeline(int timeOriginMicros,
int timeExtentMicros)
Timeline getVMTimeline(int timeOriginMicros [optional],
int timeExtentMicros [optional])
```
The _getVMTimeline_ RPC is used to retrieve an object which contains VM timeline
@@ -2318,7 +2319,7 @@ class InstanceSet extends Response {
int totalCount;
// An array of instances of the requested type.
@Instance[] instances;
@Object[] instances;
}
```