Error produced for missing var, final, const or type on field declarations.

BUG=2997
TEST=tests/language/field_decl_missing_var_type_test

Review URL: https://chromiumcodereview.appspot.com//10690106

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9585 260f80e4-7a28-3924-810f-c04153c831b5

lib/compiler/implementation/scanner/listener.dart

@@ -1531,6 +1531,14 @@ class PartialFieldListElement extends VariableListElement {
     cachedNode = parse(listener,
                        getCompilationUnit(),
                        (p) => p.parseVariablesDeclaration(beginToken));
+    if (!cachedNode.modifiers.isVar() &&
+        !cachedNode.modifiers.isFinal() &&
+        !cachedNode.modifiers.isConst() &&
+        cachedNode.type === null) {
+      listener.cancel('A field declaration must start with var, final, '
+                      'const, or a type annotation.',
+                      cachedNode);
+    }
     return cachedNode;
   }
 

tests/co19/co19-leg.status

@@ -520,7 +520,6 @@ Language/07_Classes/3_Setters_A04_t01: Fail, OK # @compile-error
 Language/07_Classes/3_Setters_A04_t02: Fail, OK # @compile-error
 Language/07_Classes/3_Setters_A04_t07: Fail, OK # @compile-error
 Language/07_Classes/3_Setters_A04_t08: Fail, OK # @compile-error
-Language/07_Classes/5_Constructors/1_Generative_Constructors_A01_t02: Fail, OK # @compile-error
 Language/07_Classes/5_Constructors/1_Generative_Constructors_A01_t04: Fail, OK # @compile-error
 Language/07_Classes/5_Constructors/1_Generative_Constructors_A01_t05: Fail, OK # @compile-error
 Language/07_Classes/5_Constructors/1_Generative_Constructors_A03_t05: Fail, OK # @compile-error

tests/language/field_decl_missing_var_type_test.dart

@@ -0,0 +1,15 @@
+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+// Dart test program for constructors and initializers.
+
+// Exercises issue 2997, missing var or type on field declarations should
+// generate a compile-time error.
+
+class A {
+  _this;                      /// 01: compile-time error
+  A(x) : this._this = x;      /// 01: continued
+}
+main() {
+  new A(0);                   /// 01: continued
+}