Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
351 lines
12 KiB
C
351 lines
12 KiB
C
/**
|
|
* @file
|
|
* @author Andriy Sukhynyuk, Vasyl Tkhir, Andriy Ivasiv
|
|
* @date 2012
|
|
* @brief Network layer for BACnet routing
|
|
*
|
|
* @section LICENSE
|
|
*
|
|
* SPDX-License-Identifier: MIT
|
|
*/
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include "network_layer.h"
|
|
#include "bacnet/bacint.h"
|
|
|
|
uint16_t process_network_message(
|
|
const BACMSG *msg, MSG_DATA *data, uint8_t **buff)
|
|
{
|
|
BACNET_NPDU_DATA npdu_data;
|
|
ROUTER_PORT *srcport;
|
|
ROUTER_PORT *destport;
|
|
uint16_t net;
|
|
uint8_t error_code;
|
|
int16_t buff_len = 0;
|
|
int apdu_offset;
|
|
int apdu_len;
|
|
|
|
memmove(data, msg->data, sizeof(MSG_DATA));
|
|
|
|
apdu_offset = bacnet_npdu_decode(data->pdu, data->pdu_len, &data->dest,
|
|
NULL, &npdu_data);
|
|
apdu_len = data->pdu_len - apdu_offset;
|
|
|
|
srcport = find_snet(msg->origin);
|
|
data->src.net = srcport->route_info.net;
|
|
|
|
switch (npdu_data.network_message_type) {
|
|
case NETWORK_MESSAGE_WHO_IS_ROUTER_TO_NETWORK:
|
|
PRINT(INFO, "Recieved Who-Is-Router-To-Network message\n");
|
|
if (apdu_len) {
|
|
/* if NET specified */
|
|
decode_unsigned16(&data->pdu[apdu_offset], &net);
|
|
if (srcport->route_info.net == net) {
|
|
PRINT(INFO, "Message discarded: NET directly connected\n");
|
|
return -2;
|
|
}
|
|
|
|
destport = find_dnet(net, NULL); /* see if NET can be reached */
|
|
if (destport) {
|
|
/* if TRUE send reply */
|
|
PRINT(INFO, "Sending I-Am-Router-To-Network message\n");
|
|
buff_len = create_network_message(
|
|
NETWORK_MESSAGE_I_AM_ROUTER_TO_NETWORK, data, buff,
|
|
&net);
|
|
} else {
|
|
data->dest.net = net; /* NET to look for */
|
|
return -1; /* else initiate NET search procedure */
|
|
}
|
|
} else {
|
|
/* if NET is omitted (message sent with -1) */
|
|
PRINT(INFO, "Sending I-Am-Router-To-Network message\n");
|
|
buff_len = create_network_message(
|
|
NETWORK_MESSAGE_I_AM_ROUTER_TO_NETWORK, data, buff, NULL);
|
|
}
|
|
|
|
break;
|
|
|
|
case NETWORK_MESSAGE_I_AM_ROUTER_TO_NETWORK: {
|
|
PRINT(INFO, "Recieved I-Am-Router-To-Network message\n");
|
|
int net_count = apdu_len / 2;
|
|
int i;
|
|
for (i = 0; i < net_count; i++) {
|
|
decode_unsigned16(&data->pdu[apdu_offset + 2 * i],
|
|
&net); /* decode received NET values */
|
|
add_dnet(&srcport->route_info, net,
|
|
data->src); /* and update routing table */
|
|
}
|
|
break;
|
|
}
|
|
case NETWORK_MESSAGE_REJECT_MESSAGE_TO_NETWORK: {
|
|
/* first octet of the message contains rejection reason */
|
|
/* next two octets contain NET (can be decoded for additional info
|
|
* on error) */
|
|
error_code = data->pdu[apdu_offset];
|
|
switch (error_code) {
|
|
case 0:
|
|
PRINT(ERROR, "Error!\n");
|
|
break;
|
|
case 1:
|
|
PRINT(ERROR, "Error: Network unreachable\n");
|
|
break;
|
|
case 2:
|
|
PRINT(ERROR, "Error: Network is busy\n");
|
|
break;
|
|
case 3:
|
|
PRINT(ERROR, "Error: Unknown network message type\n");
|
|
break;
|
|
case 4:
|
|
PRINT(ERROR, "Error: Message too long\n");
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
break;
|
|
}
|
|
case NETWORK_MESSAGE_INIT_RT_TABLE:
|
|
PRINT(INFO, "Recieved Initialize-Routing-Table message\n");
|
|
if (data->pdu[apdu_offset] > 0) {
|
|
int net_count = data->pdu[apdu_offset];
|
|
while (net_count--) {
|
|
int i = 1;
|
|
decode_unsigned16(&data->pdu[apdu_offset + i],
|
|
&net); /* decode received NET values */
|
|
add_dnet(&srcport->route_info, net,
|
|
data->src); /* and update routing table */
|
|
if (data->pdu[apdu_offset + i + 3] >
|
|
0) { /* find next NET value */
|
|
i = data->pdu[apdu_offset + i + 3] + 4;
|
|
} else {
|
|
i = i + 4;
|
|
}
|
|
}
|
|
buff_len = create_network_message(
|
|
NETWORK_MESSAGE_INIT_RT_TABLE_ACK, data, buff, NULL);
|
|
} else {
|
|
buff_len = create_network_message(
|
|
NETWORK_MESSAGE_INIT_RT_TABLE_ACK, data, buff, &buff);
|
|
}
|
|
break;
|
|
|
|
case NETWORK_MESSAGE_INIT_RT_TABLE_ACK:
|
|
PRINT(INFO, "Recieved Initialize-Routing-Table-Ack message\n");
|
|
if (data->pdu[apdu_offset] > 0) {
|
|
int net_count = data->pdu[apdu_offset];
|
|
while (net_count--) {
|
|
int i = 1;
|
|
decode_unsigned16(&data->pdu[apdu_offset + i],
|
|
&net); /* decode received NET values */
|
|
add_dnet(&srcport->route_info, net,
|
|
data->src); /* and update routing table */
|
|
if (data->pdu[apdu_offset + i + 3] >
|
|
0) { /* find next NET value */
|
|
i = data->pdu[apdu_offset + i + 3] + 4;
|
|
} else {
|
|
i = i + 4;
|
|
}
|
|
}
|
|
}
|
|
break;
|
|
|
|
case NETWORK_MESSAGE_INVALID:
|
|
case NETWORK_MESSAGE_I_COULD_BE_ROUTER_TO_NETWORK:
|
|
case NETWORK_MESSAGE_ROUTER_BUSY_TO_NETWORK:
|
|
case NETWORK_MESSAGE_ROUTER_AVAILABLE_TO_NETWORK:
|
|
case NETWORK_MESSAGE_ESTABLISH_CONNECTION_TO_NETWORK:
|
|
case NETWORK_MESSAGE_DISCONNECT_CONNECTION_TO_NETWORK:
|
|
/* hell if I know what to do with these messages */
|
|
break;
|
|
case NETWORK_MESSAGE_CHALLENGE_REQUEST:
|
|
case NETWORK_MESSAGE_SECURITY_PAYLOAD:
|
|
case NETWORK_MESSAGE_SECURITY_RESPONSE:
|
|
case NETWORK_MESSAGE_REQUEST_KEY_UPDATE:
|
|
case NETWORK_MESSAGE_UPDATE_KEY_SET:
|
|
case NETWORK_MESSAGE_UPDATE_DISTRIBUTION_KEY:
|
|
case NETWORK_MESSAGE_REQUEST_MASTER_KEY:
|
|
case NETWORK_MESSAGE_SET_MASTER_KEY:
|
|
case NETWORK_MESSAGE_NETWORK_NUMBER_IS:
|
|
/* security messages */
|
|
break;
|
|
case NETWORK_MESSAGE_WHAT_IS_NETWORK_NUMBER:
|
|
buff_len = create_network_message(
|
|
NETWORK_MESSAGE_NETWORK_NUMBER_IS, data, buff, &buff);
|
|
break;
|
|
|
|
default:
|
|
PRINT(ERROR, "Error: Message unsupported\n");
|
|
break;
|
|
}
|
|
|
|
return buff_len;
|
|
}
|
|
|
|
uint16_t create_network_message(
|
|
BACNET_NETWORK_MESSAGE_TYPE network_message_type,
|
|
MSG_DATA *data,
|
|
uint8_t **buff,
|
|
void *val)
|
|
{
|
|
int16_t buff_len;
|
|
bool data_expecting_reply = false;
|
|
BACNET_NPDU_DATA npdu_data;
|
|
|
|
if (network_message_type == NETWORK_MESSAGE_INIT_RT_TABLE) {
|
|
data_expecting_reply = true;
|
|
}
|
|
init_npdu(&npdu_data, network_message_type, data_expecting_reply);
|
|
|
|
*buff = (uint8_t *)malloc(128); /* resolve different length */
|
|
|
|
/* manual destination setup for Init-RT-Table-Ack message */
|
|
data->dest.net = BACNET_BROADCAST_NETWORK;
|
|
buff_len = npdu_encode_pdu(*buff, &data->dest, NULL, &npdu_data);
|
|
|
|
switch (network_message_type) {
|
|
case NETWORK_MESSAGE_WHO_IS_ROUTER_TO_NETWORK:
|
|
if (val != NULL) {
|
|
uint8_t *valptr = (uint8_t *)val;
|
|
uint16_t val16 = (valptr[0]) + (valptr[1] << 8);
|
|
buff_len += encode_unsigned16(*buff + buff_len, val16);
|
|
}
|
|
break;
|
|
|
|
case NETWORK_MESSAGE_I_AM_ROUTER_TO_NETWORK:
|
|
if (val != NULL) {
|
|
uint8_t *valptr = (uint8_t *)val;
|
|
uint16_t val16 = (valptr[0]) + (valptr[1] << 8);
|
|
buff_len += encode_unsigned16(*buff + buff_len, val16);
|
|
} else {
|
|
ROUTER_PORT *port = head;
|
|
DNET *dnet;
|
|
while (port != NULL) {
|
|
if (port->route_info.net != data->src.net) {
|
|
buff_len += encode_unsigned16(
|
|
*buff + buff_len, port->route_info.net);
|
|
dnet = port->route_info.dnets;
|
|
while (dnet != NULL) {
|
|
buff_len +=
|
|
encode_unsigned16(*buff + buff_len, dnet->net);
|
|
dnet = dnet->next;
|
|
}
|
|
port = port->next;
|
|
} else {
|
|
dnet = port->route_info.dnets;
|
|
while (dnet != NULL) {
|
|
buff_len +=
|
|
encode_unsigned16(*buff + buff_len, dnet->net);
|
|
dnet = dnet->next;
|
|
}
|
|
port = port->next;
|
|
}
|
|
}
|
|
}
|
|
break;
|
|
|
|
case NETWORK_MESSAGE_REJECT_MESSAGE_TO_NETWORK: {
|
|
uint8_t *valptr = (uint8_t *)val;
|
|
uint16_t val16 = (valptr[0]) + (valptr[1] << 8);
|
|
buff_len += encode_unsigned16(*buff + buff_len, val16);
|
|
break;
|
|
}
|
|
case NETWORK_MESSAGE_INIT_RT_TABLE:
|
|
case NETWORK_MESSAGE_INIT_RT_TABLE_ACK:
|
|
if ((uint8_t *)val) {
|
|
(*buff)[buff_len++] = (uint8_t)port_count;
|
|
|
|
if (port_count > 0) {
|
|
ROUTER_PORT *port = head;
|
|
uint8_t portID = 1;
|
|
|
|
while (port != NULL) {
|
|
buff_len += encode_unsigned16(
|
|
*buff + buff_len, port->route_info.net);
|
|
(*buff)[buff_len++] = portID++;
|
|
(*buff)[buff_len++] = 0;
|
|
port = port->next;
|
|
}
|
|
}
|
|
} else {
|
|
(*buff)[buff_len++] = (uint8_t)0;
|
|
}
|
|
break;
|
|
|
|
case NETWORK_MESSAGE_INVALID:
|
|
case NETWORK_MESSAGE_I_COULD_BE_ROUTER_TO_NETWORK:
|
|
case NETWORK_MESSAGE_ROUTER_BUSY_TO_NETWORK:
|
|
case NETWORK_MESSAGE_ROUTER_AVAILABLE_TO_NETWORK:
|
|
case NETWORK_MESSAGE_ESTABLISH_CONNECTION_TO_NETWORK:
|
|
case NETWORK_MESSAGE_DISCONNECT_CONNECTION_TO_NETWORK:
|
|
/* hell if I know what to do with these messages */
|
|
break;
|
|
case NETWORK_MESSAGE_CHALLENGE_REQUEST:
|
|
case NETWORK_MESSAGE_SECURITY_PAYLOAD:
|
|
case NETWORK_MESSAGE_SECURITY_RESPONSE:
|
|
case NETWORK_MESSAGE_REQUEST_KEY_UPDATE:
|
|
case NETWORK_MESSAGE_UPDATE_KEY_SET:
|
|
case NETWORK_MESSAGE_UPDATE_DISTRIBUTION_KEY:
|
|
case NETWORK_MESSAGE_REQUEST_MASTER_KEY:
|
|
case NETWORK_MESSAGE_SET_MASTER_KEY:
|
|
/* security messages */
|
|
break;
|
|
case NETWORK_MESSAGE_NETWORK_NUMBER_IS:
|
|
/* fixme: needs message constructed */
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
|
|
return buff_len;
|
|
}
|
|
|
|
void send_network_message(BACNET_NETWORK_MESSAGE_TYPE network_message_type,
|
|
MSG_DATA *data,
|
|
uint8_t **buff,
|
|
void *val)
|
|
{
|
|
BACMSG msg;
|
|
ROUTER_PORT *port = head;
|
|
int16_t buff_len;
|
|
|
|
if (!data) {
|
|
data = (MSG_DATA *)malloc(sizeof(MSG_DATA));
|
|
data->dest.net = BACNET_BROADCAST_NETWORK;
|
|
data->dest.len = 0;
|
|
}
|
|
|
|
buff_len = create_network_message(network_message_type, data, buff, val);
|
|
|
|
/* form network message */
|
|
data->pdu = *buff;
|
|
data->pdu_len = buff_len;
|
|
msg.origin = head->main_id;
|
|
msg.type = DATA;
|
|
msg.data = data;
|
|
|
|
data->ref_count = port_count;
|
|
while (port != NULL) {
|
|
if (port->state == FINISHED) {
|
|
port = port->next;
|
|
continue;
|
|
}
|
|
send_to_msgbox(port->port_id, &msg);
|
|
port = port->next;
|
|
}
|
|
}
|
|
|
|
void init_npdu(BACNET_NPDU_DATA *npdu_data,
|
|
BACNET_NETWORK_MESSAGE_TYPE network_message_type,
|
|
bool data_expecting_reply)
|
|
{
|
|
if (npdu_data) {
|
|
npdu_data->data_expecting_reply = data_expecting_reply;
|
|
npdu_data->protocol_version = BACNET_PROTOCOL_VERSION;
|
|
npdu_data->network_layer_message = true;
|
|
npdu_data->network_message_type = network_message_type;
|
|
npdu_data->vendor_id = 0;
|
|
npdu_data->priority = MESSAGE_PRIORITY_NORMAL;
|
|
npdu_data->hop_count = HOP_COUNT_DEFAULT;
|
|
}
|
|
}
|