Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
47 lines
1.1 KiB
C
47 lines
1.1 KiB
C
/**************************************************************************
|
|
*
|
|
* Copyright (C) 2009 Steve Karg <skarg@users.sourceforge.net>
|
|
*
|
|
* SPDX-License-Identifier: MIT
|
|
*********************************************************************/
|
|
#include <stdbool.h>
|
|
#include <stdint.h>
|
|
#include <stdlib.h>
|
|
#include "hardware.h"
|
|
#include "eeprom.h"
|
|
|
|
/* Internal EEPROM of the AVR - http://supp.iar.com/Support/?note=45745 */
|
|
|
|
int eeprom_bytes_read(
|
|
uint16_t eeaddr, /* EEPROM starting memory address (offset of zero) */
|
|
uint8_t *buf, /* data to store */
|
|
int len)
|
|
{ /* number of bytes of data to read */
|
|
int count = 0; /* return value */
|
|
|
|
while (len) {
|
|
__EEGET(buf[count], eeaddr);
|
|
count++;
|
|
eeaddr++;
|
|
len--;
|
|
}
|
|
|
|
return count;
|
|
}
|
|
|
|
int eeprom_bytes_write(uint16_t eeaddr, /* EEPROM starting memory address */
|
|
const uint8_t *buf, /* data to send */
|
|
int len)
|
|
{ /* number of bytes of data */
|
|
int count = 0;
|
|
|
|
while (len) {
|
|
__EEPUT(eeaddr, buf[count]);
|
|
count++;
|
|
eeaddr++;
|
|
len--;
|
|
}
|
|
|
|
return count;
|
|
}
|