Fixed BACNET_APPLICATION_DATA_VALUE declarations to be initialized so that the next pointer is NULL by default. (#814)

apps/blinkt/device.c

@@ -1406,7 +1406,7 @@ bool Device_Write_Property_Local(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     BACNET_OBJECT_TYPE object_type = OBJECT_NONE;
     uint32_t object_instance = 0;
     int result = 0;

apps/perl/perl_bindings.c

@@ -116,7 +116,7 @@ void rp_ack_extract_data(BACNET_READ_PROPERTY_DATA *data)
     char ackString[MAX_ACK_STRING] = "";
     char *pAckString = &ackString[0];
     BACNET_OBJECT_PROPERTY_VALUE object_value; /* for bacapp printing */
-    BACNET_APPLICATION_DATA_VALUE value; /* for decode value data */
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     int len = 0;
     uint8_t *application_data;
     int application_data_len;
@@ -714,7 +714,7 @@ int BacnetWriteProperty(
         /* Handle the tag/value pair */
         uint8_t context_tag = 0;
         BACNET_APPLICATION_TAG property_tag;
-        BACNET_APPLICATION_DATA_VALUE propertyValue;
+        BACNET_APPLICATION_DATA_VALUE propertyValue = { 0 };
 
         if (toupper(tag[0]) == 'C') {
             context_tag = strtol(&tag[1], NULL, 0);

apps/piface/device.c

@@ -1358,7 +1358,7 @@ bool Device_Write_Property_Local(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     BACNET_OBJECT_TYPE object_type = OBJECT_NONE;
     uint32_t object_instance = 0;
     int result = 0;

ports/arduino_uno/av.c

@@ -146,7 +146,7 @@ bool Analog_Value_Write_Property(
     bool status = false; /* return value */
     unsigned int object_index = 0;
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (!Analog_Value_Valid_Instance(wp_data->object_instance)) {
         *error_class = ERROR_CLASS_OBJECT;

ports/arduino_uno/bv.c

@@ -164,7 +164,7 @@ bool Binary_Value_Write_Property(
     bool status = false; /* return value */
     unsigned int object_index = 0;
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (!Binary_Value_Valid_Instance(wp_data->object_instance)) {
         *error_class = ERROR_CLASS_OBJECT;

ports/arduino_uno/device.c

@@ -333,7 +333,7 @@ bool Device_Write_Property(
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (!Device_Valid_Object_Instance_Number(wp_data->object_instance)) {
         *error_class = ERROR_CLASS_OBJECT;

ports/at91sam7s/av.c

@@ -289,7 +289,7 @@ bool Analog_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
     unsigned int priority = 0;
     uint8_t level = ANALOG_LEVEL_NULL;
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (!Analog_Value_Valid_Instance(wp_data->object_instance)) {
         wp_data->error_class = ERROR_CLASS_OBJECT;

ports/at91sam7s/bv.c

@@ -198,7 +198,7 @@ bool Binary_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
     unsigned int priority = 0;
     BACNET_BINARY_PV level = BINARY_NULL;
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (!Binary_Value_Valid_Instance(wp_data->object_instance)) {
         wp_data->error_class = ERROR_CLASS_OBJECT;

ports/at91sam7s/device.c

@@ -799,7 +799,7 @@ bool Device_Write_Property_Local(BACNET_WRITE_PROPERTY_DATA *wp_data)
     int len = 0;
     uint8_t encoding = 0;
     size_t length = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_application_data(

ports/at91sam7s/netport.c

@@ -652,7 +652,7 @@ bool Network_Port_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (!Network_Port_Valid_Instance(wp_data->object_instance)) {
         wp_data->error_class = ERROR_CLASS_OBJECT;

ports/atmega328/av.c

@@ -518,7 +518,7 @@ bool Analog_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (!Analog_Value_Valid_Instance(wp_data->object_instance)) {
         wp_data->error_class = ERROR_CLASS_OBJECT;

ports/atmega328/bv.c

@@ -286,7 +286,7 @@ bool Binary_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (!Binary_Value_Valid_Instance(wp_data->object_instance)) {
         wp_data->error_class = ERROR_CLASS_OBJECT;

ports/atmega328/device.c

@@ -322,7 +322,7 @@ bool Device_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     size_t name_length;
 
     if (!Device_Valid_Object_Instance_Number(wp_data->object_instance)) {

ports/bdk-atxx4-mstp/av.c

@@ -299,7 +299,7 @@ bool Analog_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
     unsigned int object_index = 0;
     unsigned int priority = 0;
 #endif
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     int len = 0;
 
     /* decode the some of the request */

ports/bdk-atxx4-mstp/bo.c

@@ -354,7 +354,7 @@ bool Binary_Output_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
     unsigned int priority = 0;
     BACNET_BINARY_PV level = BINARY_NULL;
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_application_data(

ports/bdk-atxx4-mstp/device.c

@@ -794,7 +794,7 @@ bool Device_Write_Property_Local(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value - false=error */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     uint8_t max_master = 0;
 
     /* decode the some of the request */

ports/bdk-atxx4-mstp/netport.c

@@ -653,7 +653,7 @@ bool Network_Port_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (!Network_Port_Valid_Instance(wp_data->object_instance)) {
         wp_data->error_class = ERROR_CLASS_OBJECT;

ports/esp32/src/ai.c

@@ -583,7 +583,7 @@ bool Analog_Input_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
     bool status = false; /* return value */
     unsigned int object_index = 0;
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     ANALOG_INPUT_DESCR *CurrentAI;
 
     /* decode the some of the request */

ports/esp32/src/bo.c

@@ -323,7 +323,7 @@ bool Binary_Output_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
     unsigned int priority = 0;
     BACNET_BINARY_PV level = BINARY_NULL;
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_application_data(

ports/esp32/src/device.c

@@ -1213,7 +1213,7 @@ bool Device_Write_Property_Local(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     BACNET_OBJECT_TYPE object_type = OBJECT_NONE;
     uint32_t object_instance = 0;
     int temp;

ports/pic18f6720/av.c

@@ -268,7 +268,7 @@ bool Analog_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
     unsigned int priority = 0;
     uint8_t level = ANALOG_LEVEL_NULL;
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     Analog_Value_Init();
     if (!Analog_Value_Valid_Instance(wp_data->object_instance)) {

ports/pic18f6720/bv.c

@@ -180,7 +180,7 @@ bool Binary_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
     unsigned int priority = 0;
     BACNET_BINARY_PV level = BINARY_NULL;
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (!Binary_Value_Valid_Instance(wp_data->object_instance)) {
         wp_data->error_class = ERROR_CLASS_OBJECT;

ports/pic18f6720/device.c

@@ -579,7 +579,7 @@ bool Device_Write_Property_Local(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (!Device_Valid_Object_Instance_Number(wp_data->object_instance)) {
         wp_data->error_class = ERROR_CLASS_OBJECT;

ports/pic18f97j60/av.c

@@ -268,7 +268,7 @@ bool Analog_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
     unsigned int priority = 0;
     uint8_t level = ANALOG_LEVEL_NULL;
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     Analog_Value_Init();
     if (!Analog_Value_Valid_Instance(wp_data->object_instance)) {

ports/pic18f97j60/bv.c

@@ -180,7 +180,7 @@ bool Binary_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
     unsigned int priority = 0;
     BACNET_BINARY_PV level = BINARY_NULL;
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (!Binary_Value_Valid_Instance(wp_data->object_instance)) {
         wp_data->error_class = ERROR_CLASS_OBJECT;

ports/pic18f97j60/device.c

@@ -510,7 +510,7 @@ bool Device_Write_Property_Local(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (!Device_Valid_Object_Instance_Number(wp_data->object_instance)) {
         wp_data->error_class = ERROR_CLASS_OBJECT;

ports/rx62n/bo.c

@@ -343,7 +343,7 @@ bool Binary_Output_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
     unsigned int priority = 0;
     BACNET_BINARY_PV level = BINARY_NULL;
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_application_data(

ports/rx62n/device.c

@@ -835,7 +835,7 @@ bool Device_Write_Property_Local(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     int temp;
 
     /* decode the some of the request */

ports/stm32f10x/bo.c

@@ -332,7 +332,7 @@ bool Binary_Output_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
     unsigned int priority = 0;
     BACNET_BINARY_PV level = BINARY_NULL;
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_application_data(

ports/stm32f10x/device.c

@@ -813,7 +813,7 @@ bool Device_Write_Property_Local(BACNET_WRITE_PROPERTY_DATA *wp_data)
     int len = 0;
     uint8_t encoding = 0;
     size_t length = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_application_data(

ports/stm32f10x/netport.c

@@ -652,7 +652,7 @@ bool Network_Port_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (!Network_Port_Valid_Instance(wp_data->object_instance)) {
         wp_data->error_class = ERROR_CLASS_OBJECT;

ports/stm32f4xx/device.c

@@ -961,7 +961,7 @@ bool Device_Write_Property_Local(BACNET_WRITE_PROPERTY_DATA *wp_data)
     int len = 0;
     uint8_t encoding = 0;
     size_t length = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_application_data(

ports/stm32f4xx/netport.c

@@ -683,7 +683,7 @@ bool Network_Port_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (!Network_Port_Valid_Instance(wp_data->object_instance)) {
         wp_data->error_class = ERROR_CLASS_OBJECT;

ports/xplained/ai.c

@@ -246,7 +246,7 @@ bool Analog_Input_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_application_data(

ports/xplained/device.c

@@ -767,7 +767,7 @@ bool Device_Write_Property_Local(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value - false=error */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     uint8_t max_master = 0;
 
     /* decode the some of the request */

ports/xplained/netport.c

@@ -646,7 +646,7 @@ bool Network_Port_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (!Network_Port_Valid_Instance(wp_data->object_instance)) {
         wp_data->error_class = ERROR_CLASS_OBJECT;

src/bacnet/bacapp.c

@@ -2584,7 +2584,7 @@ static int bacapp_snprintf_weeklyschedule(
     int ret_val = 0;
     int wi, ti;
     BACNET_OBJECT_PROPERTY_VALUE dummyPropValue;
-    BACNET_APPLICATION_DATA_VALUE dummyDataValue;
+    BACNET_APPLICATION_DATA_VALUE dummyDataValue = { 0 };
 
     const char *weekdaynames[7] = { "Mon", "Tue", "Wed", "Thu",
                                     "Fri", "Sat", "Sun" };

src/bacnet/bactimevalue.c

@@ -69,7 +69,7 @@ int bacnet_time_value_encode(uint8_t *apdu, const BACNET_TIME_VALUE *value)
 {
     int len;
     int apdu_len = 0;
-    BACNET_APPLICATION_DATA_VALUE data;
+    BACNET_APPLICATION_DATA_VALUE data = { 0 };
 
     if (!value || !is_data_value_schedule_compatible(value->Value.tag)) {
         return BACNET_STATUS_ERROR;

src/bacnet/basic/object/acc.c

@@ -376,7 +376,7 @@ int Accumulator_Read_Property(BACNET_READ_PROPERTY_DATA *rpdata)
 bool Accumulator_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_application_data(

src/bacnet/basic/object/access_credential.c

@@ -321,7 +321,7 @@ bool Access_Credential_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     unsigned object_index = 0;
 
     /* decode the some of the request */

src/bacnet/basic/object/access_door.c

@@ -432,7 +432,7 @@ bool Access_Door_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     unsigned object_index = 0;
 
     /* decode the some of the request */

src/bacnet/basic/object/access_point.c

@@ -313,7 +313,7 @@ bool Access_Point_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_application_data(

src/bacnet/basic/object/access_rights.c

@@ -297,7 +297,7 @@ bool Access_Rights_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
     bool status = false; /* return value */
     bool is_array = false;
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     unsigned object_index = 0;
 
     /* decode the some of the request */

src/bacnet/basic/object/access_user.c

@@ -212,7 +212,7 @@ bool Access_User_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     unsigned object_index = 0;
 
     /* decode the some of the request */

src/bacnet/basic/object/access_zone.c

@@ -264,7 +264,7 @@ bool Access_Zone_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     unsigned object_index = 0;
 
     /* decode the some of the request */

src/bacnet/basic/object/ai.c

@@ -820,7 +820,7 @@ bool Analog_Input_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     struct analog_input_descr *pObject;
 
     /* Valid data? */

src/bacnet/basic/object/ao.c

@@ -1108,7 +1108,7 @@ bool Analog_Output_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_application_data(

src/bacnet/basic/object/av.c

@@ -838,7 +838,7 @@ bool Analog_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     ANALOG_VALUE_DESCR *CurrentAV;
 
     /* Valid data? */

src/bacnet/basic/object/bacfile.c

@@ -681,7 +681,7 @@ bool bacfile_write_property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (!bacfile_valid_instance(wp_data->object_instance)) {
         wp_data->error_class = ERROR_CLASS_OBJECT;

src/bacnet/basic/object/bi.c

@@ -1054,7 +1054,7 @@ bool Binary_Input_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     struct object_data *pObject;
 
     /* decode the some of the request */

src/bacnet/basic/object/bitstring_value.c

@@ -636,7 +636,7 @@ bool BitString_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (wp_data == NULL) {
         return false;

src/bacnet/basic/object/blo.c

@@ -1393,7 +1393,7 @@ bool Binary_Lighting_Output_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_application_data(

src/bacnet/basic/object/bo.c

@@ -1113,7 +1113,7 @@ bool Binary_Output_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_application_data(

src/bacnet/basic/object/bv.c

@@ -1061,7 +1061,7 @@ bool Binary_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     struct object_data *pObject;
 
     /* Valid data? */

src/bacnet/basic/object/calendar.c

@@ -573,7 +573,7 @@ bool Calendar_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     int iOffset;
     BACNET_CALENDAR_ENTRY entry;
     bool pv_old;

src/bacnet/basic/object/channel.c

@@ -1542,7 +1542,7 @@ bool Channel_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     int element_len = 0;
     uint32_t count = 0;
 

src/bacnet/basic/object/color_object.c

@@ -996,7 +996,7 @@ bool Color_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     int apdu_size = 0;
     const uint8_t *apdu = NULL;
 

src/bacnet/basic/object/color_temperature.c

@@ -1429,7 +1429,7 @@ bool Color_Temperature_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     int apdu_size = 0;
     const uint8_t *apdu = NULL;
 

src/bacnet/basic/object/command.c

@@ -467,7 +467,7 @@ bool Command_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
     bool status = false; /* return value */
     unsigned int object_index = 0;
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     /* decode the some of the request */
     len = bacapp_decode_application_data(
         wp_data->application_data, wp_data->application_data_len, &value);

src/bacnet/basic/object/credential_data_input.c

@@ -276,7 +276,7 @@ bool Credential_Data_Input_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     unsigned object_index = 0;
 
     /* decode the some of the request */

src/bacnet/basic/object/csv.c

@@ -545,7 +545,7 @@ bool CharacterString_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
     bool status = false; /* return value */
     int len = 0;
     unsigned object_index = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (wp_data == NULL) {
         return false;

src/bacnet/basic/object/device.c

@@ -1659,7 +1659,7 @@ bool Device_Write_Property_Local(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     BACNET_OBJECT_TYPE object_type = OBJECT_NONE;
     uint32_t object_instance = 0;
     int result = 0;

src/bacnet/basic/object/gateway/gw_device.c

@@ -451,7 +451,7 @@ bool Routed_Device_Write_Property_Local(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_application_data(

src/bacnet/basic/object/iv.c

@@ -546,7 +546,7 @@ bool Integer_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_application_data(

src/bacnet/basic/object/lo.c

@@ -2141,7 +2141,7 @@ bool Lighting_Output_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_known_property(

src/bacnet/basic/object/lsp.c

@@ -574,7 +574,7 @@ bool Life_Safety_Point_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_application_data(

src/bacnet/basic/object/lsz.c

@@ -753,7 +753,7 @@ bool Life_Safety_Zone_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_application_data(

src/bacnet/basic/object/ms-input.c

@@ -812,7 +812,7 @@ bool Multistate_Input_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the first chunk of the request */
     len = bacapp_decode_application_data(

src/bacnet/basic/object/mso.c

@@ -1057,7 +1057,7 @@ bool Multistate_Output_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the first chunk of the request */
     len = bacapp_decode_application_data(

src/bacnet/basic/object/msv.c

@@ -815,7 +815,7 @@ bool Multistate_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_application_data(

src/bacnet/basic/object/nc.c

@@ -295,7 +295,7 @@ bool Notification_Class_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     NOTIFICATION_CLASS_INFO *CurrentNotify;
     NOTIFICATION_CLASS_INFO TmpNotify;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     uint8_t TmpPriority[MAX_BACNET_EVENT_TRANSITION]; /* BACnetARRAY[3] of
                                                          Unsigned */
     bool status = false;

src/bacnet/basic/object/netport.c

@@ -3507,7 +3507,7 @@ bool Network_Port_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (!Network_Port_Valid_Instance(wp_data->object_instance)) {
         wp_data->error_class = ERROR_CLASS_OBJECT;

src/bacnet/basic/object/osv.c

@@ -257,7 +257,7 @@ bool OctetString_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
     bool status = false; /* return value */
     unsigned int object_index = 0;
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     OCTETSTRING_VALUE_DESCR *CurrentAV;
 
     /* decode the some of the request */

src/bacnet/basic/object/piv.c

@@ -268,7 +268,7 @@ bool PositiveInteger_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
     bool status = false; /* return value */
     unsigned int object_index = 0;
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     POSITIVEINTEGER_VALUE_DESCR *CurrentAV;
 
     /* decode the some of the request */

src/bacnet/basic/object/schedule.c

@@ -420,7 +420,7 @@ bool Schedule_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
     unsigned object_index;
     bool status = false; /* return value */
     int len;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     /* decode the some of the request */
     len = bacapp_decode_application_data(

src/bacnet/basic/object/time_value.c

@@ -614,7 +614,7 @@ int Time_Value_Read_Property(BACNET_READ_PROPERTY_DATA *rpdata)
 bool Time_Value_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     int len = 0;
 
     /* decode the some of the request */

src/bacnet/basic/object/trendlog.c

@@ -421,7 +421,7 @@ bool Trend_Log_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
 {
     bool status = false; /* return value */
     int len = 0;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     TL_LOG_INFO *CurrentLog;
     BACNET_DATE start_date, stop_date;
     BACNET_DEVICE_OBJECT_PROPERTY_REFERENCE TempSource;

src/bacnet/basic/service/h_rp_a.c

@@ -35,7 +35,7 @@ void rp_ack_print_data(BACNET_READ_PROPERTY_DATA *data)
 #ifdef BACAPP_PRINT_ENABLED
     BACNET_OBJECT_PROPERTY_VALUE object_value; /* for bacapp printing */
 #endif
-    BACNET_APPLICATION_DATA_VALUE value; /* for decode value data */
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     int len = 0;
     uint8_t *application_data;
     int application_data_len;

src/bacnet/basic/service/h_rr_a.c

@@ -27,7 +27,7 @@ static void PrintReadRangeData(BACNET_READ_RANGE_DATA *data)
 #ifdef BACAPP_PRINT_ENABLED
     BACNET_OBJECT_PROPERTY_VALUE object_value; /* for bacapp printing */
 #endif
-    BACNET_APPLICATION_DATA_VALUE value; /* for decode value data */
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     int len = 0;
     uint8_t *application_data;
     int application_data_len;

src/bacnet/basic/service/h_upt.c

@@ -28,7 +28,7 @@ void private_transfer_print_data(BACNET_PRIVATE_TRANSFER_DATA *private_data)
 #ifdef BACAPP_PRINT_ENABLED
     BACNET_OBJECT_PROPERTY_VALUE object_value; /* for bacapp printing */
 #endif
-    BACNET_APPLICATION_DATA_VALUE value; /* for decode value data */
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     int len = 0;
     uint8_t *application_data;
     int application_data_len;

src/bacnet/get_alarm_sum.c

@@ -105,7 +105,7 @@ int get_alarm_summary_ack_decode_apdu_data(
     BACNET_GET_ALARM_SUMMARY_DATA *get_alarm_data)
 {
     int apdu_len = 0; /* total length of the apdu, return value */
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     if (!apdu) {
         apdu_len = BACNET_STATUS_ERROR;

src/bacnet/special_event.c

@@ -228,7 +228,7 @@ int bacnet_special_event_context_decode(
 bool bacnet_special_event_same(
     const BACNET_SPECIAL_EVENT *value1, const BACNET_SPECIAL_EVENT *value2)
 {
-    BACNET_APPLICATION_DATA_VALUE adv1, adv2;
+    BACNET_APPLICATION_DATA_VALUE adv1 = { 0 }, adv2 = { 0 };
     const BACNET_TIME_VALUE *tv1, *tv2;
     int ti;
 

src/bacnet/weeklyschedule.c

@@ -171,7 +171,7 @@ int bacnet_weeklyschedule_context_decode(
 bool bacnet_weeklyschedule_same(
     const BACNET_WEEKLY_SCHEDULE *value1, const BACNET_WEEKLY_SCHEDULE *value2)
 {
-    BACNET_APPLICATION_DATA_VALUE adv1, adv2;
+    BACNET_APPLICATION_DATA_VALUE adv1 = { 0 }, adv2 = { 0 };
     const BACNET_DAILY_SCHEDULE *ds1, *ds2;
     const BACNET_TIME_VALUE *tv1, *tv2;
     int wi, ti;

test/bacnet/bacapp/src/main.c

@@ -570,7 +570,7 @@ static void testBACnetApplicationData_Safe(void)
     BACNET_APPLICATION_DATA_VALUE input_value[13];
     uint32_t len_segment[13];
     uint32_t single_length_segment;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     for (i = 0; i < 13; i++) {
         input_value[i].tag = (BACNET_APPLICATION_TAG)i;

test/bacnet/basic/object/access_door/src/main.c

@@ -30,7 +30,7 @@ static void test_object_access_door(void)
     int test_len = 0;
     BACNET_READ_PROPERTY_DATA rpdata;
     /* for decode value data */
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     const int *pRequired = NULL;
     const int *pOptional = NULL;
     const int *pProprietary = NULL;

test/bacnet/basic/object/lc/src/main.c

@@ -56,7 +56,7 @@ Load_Control_WriteProperty_Request_Shed_Level(int instance, unsigned level)
 static void Load_Control_WriteProperty_Enable(int instance, bool enable)
 {
     bool status = false;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     BACNET_WRITE_PROPERTY_DATA wp_data;
 
     wp_data.object_type = OBJECT_LOAD_CONTROL;
@@ -80,7 +80,7 @@ static void
 Load_Control_WriteProperty_Shed_Duration(int instance, unsigned duration)
 {
     bool status = false;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     BACNET_WRITE_PROPERTY_DATA wp_data;
 
     wp_data.object_type = OBJECT_LOAD_CONTROL;
@@ -103,7 +103,7 @@ static void
 Load_Control_WriteProperty_Duty_Window(int instance, unsigned duration)
 {
     bool status = false;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     BACNET_WRITE_PROPERTY_DATA wp_data;
 
     wp_data.object_type = OBJECT_LOAD_CONTROL;
@@ -126,7 +126,7 @@ static void Load_Control_WriteProperty_Start_Time_Wildcards(int instance)
 {
     int len = 0;
     bool status = false;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     BACNET_WRITE_PROPERTY_DATA wp_data;
 
     wp_data.object_type = OBJECT_LOAD_CONTROL;
@@ -158,7 +158,7 @@ static void Load_Control_WriteProperty_Start_Time(
 {
     int len = 0;
     bool status = false;
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
     BACNET_WRITE_PROPERTY_DATA wp_data;
 
     wp_data.object_type = OBJECT_LOAD_CONTROL;

test/bacnet/ptransfer/src/main.c

@@ -157,8 +157,8 @@ static void test_Private_Transfer_Ack(void)
     uint8_t test_value[480] = { 0 };
     int private_data_len = 0;
     char private_data_chunk[33] = { "00112233445566778899AABBCCDDEEFF" };
-    BACNET_APPLICATION_DATA_VALUE data_value;
-    BACNET_APPLICATION_DATA_VALUE test_data_value;
+    BACNET_APPLICATION_DATA_VALUE data_value = { 0 };
+    BACNET_APPLICATION_DATA_VALUE test_data_value = { 0 };
     bool status = false;
 
     private_data.vendorID = BACNET_VENDOR_ID;
@@ -213,8 +213,8 @@ static void test_Private_Transfer_Error(void)
     uint8_t test_value[480] = { 0 };
     int private_data_len = 0;
     char private_data_chunk[33] = { "00112233445566778899AABBCCDDEEFF" };
-    BACNET_APPLICATION_DATA_VALUE data_value;
-    BACNET_APPLICATION_DATA_VALUE test_data_value;
+    BACNET_APPLICATION_DATA_VALUE data_value = { 0 };
+    BACNET_APPLICATION_DATA_VALUE test_data_value = { 0 };
     bool status = false;
 
     private_data.vendorID = BACNET_VENDOR_ID;
@@ -315,8 +315,8 @@ static void test_Unconfirmed_Private_Transfer_Request(void)
     int apdu_len = 0;
     int private_data_len = 0;
     char private_data_chunk[32] = { "I Love You, Patricia!" };
-    BACNET_APPLICATION_DATA_VALUE data_value;
-    BACNET_APPLICATION_DATA_VALUE test_data_value;
+    BACNET_APPLICATION_DATA_VALUE data_value = { 0 };
+    BACNET_APPLICATION_DATA_VALUE test_data_value = { 0 };
     BACNET_PRIVATE_TRANSFER_DATA private_data;
     BACNET_PRIVATE_TRANSFER_DATA test_data;
     bool status = false;

test/bacnet/wp/src/main.c

@@ -67,7 +67,7 @@ static void testWritePropertyTag(const BACNET_APPLICATION_DATA_VALUE *value)
 {
     BACNET_WRITE_PROPERTY_DATA wpdata = { 0 };
     BACNET_WRITE_PROPERTY_DATA test_data = { 0 };
-    BACNET_APPLICATION_DATA_VALUE test_value;
+    BACNET_APPLICATION_DATA_VALUE test_value = { 0 };
     uint8_t apdu[480] = { 0 };
     int len = 0;
     int null_len = 0;
@@ -181,7 +181,7 @@ ZTEST(wp_tests, testWriteProperty)
 static void testWriteProperty(void)
 #endif
 {
-    BACNET_APPLICATION_DATA_VALUE value;
+    BACNET_APPLICATION_DATA_VALUE value = { 0 };
 
     value.tag = BACNET_APPLICATION_TAG_NULL;
     testWritePropertyTag(&value);