Make most of functions const correct (#714)

* Make most of the functions const correct

Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.

This commit does not yet touch handlers and typedefs of those.

* Fix Arduino uno handler_who_is() has extra parenthesis

For some reason there is extra parenthesis. Remove it this is more
likely buildable.

* Bugfix/bacapp: Fix uninitilized array_index

We have changed bacapp_snprintf_value() to be const correct. After that
we got

```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
                ret_val = bacapp_snprintf_weeklyschedule(
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```

So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.

* cmake: Add and ignore Wwrite-strings compiler option

Wwrite-strings helps find places where const correctness is broken.

Example it will warn about these

```C

void func1(char* str);

func("test") /* "test" is const so we should not pass it to func1().

char* func2()
{
  return "test"; /* func2() should return const char*.
}
```

We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.

---------

Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>

test/CMakeLists.txt

@@ -24,6 +24,7 @@ if (CMAKE_C_COMPILER_ID MATCHES "Clang" OR CMAKE_C_COMPILER_ID MATCHES "GNU")
     add_compile_options(-Wswitch-default)
     add_compile_options(-Wunused-variable)
     add_compile_options(-Wcast-qual)
+    add_compile_options(-Wwrite-strings)
 
     # don't warn about conversion, sign, compares, long long and attributes
     # since they are common in embedded
@@ -41,6 +42,7 @@ if (CMAKE_C_COMPILER_ID MATCHES "Clang" OR CMAKE_C_COMPILER_ID MATCHES "GNU")
     add_compile_options(-Wno-float-conversion)
     add_compile_options(-Wno-missing-declarations)
     add_compile_options(-Wno-unused-but-set-variable)
+    add_compile_options(-Wno-write-strings)
 
     add_link_options(-fprofile-arcs -ftest-coverage)
 endif()

test/bacnet/arf/src/main.c

@@ -112,7 +112,7 @@ static void testAtomicReadFileAck(void)
     return;
 }
 
-static void testAtomicReadFileAccess(BACNET_ATOMIC_READ_FILE_DATA *data)
+static void testAtomicReadFileAccess(const BACNET_ATOMIC_READ_FILE_DATA *data)
 {
     BACNET_ATOMIC_READ_FILE_DATA test_data = { 0 };
     uint8_t apdu[480] = { 0 };

test/bacnet/awf/src/main.c

@@ -100,7 +100,8 @@ static void testAtomicWriteFile(void)
     return;
 }
 
-static void testAtomicWriteFileAckAccess(BACNET_ATOMIC_WRITE_FILE_DATA *data)
+static void testAtomicWriteFileAckAccess(
+    const BACNET_ATOMIC_WRITE_FILE_DATA *data)
 {
     BACNET_ATOMIC_WRITE_FILE_DATA test_data = { 0 };
     uint8_t apdu[480] = { 0 };

test/bacnet/bacapp/src/main.c

@@ -860,7 +860,7 @@ static void testBACnetApplicationDataLength(void)
  * @brief Test
  */
 static bool
-verifyBACnetApplicationDataValue(BACNET_APPLICATION_DATA_VALUE *value)
+verifyBACnetApplicationDataValue(const BACNET_APPLICATION_DATA_VALUE *value)
 {
     uint8_t apdu[480] = { 0 };
     int apdu_len = 0;
@@ -917,7 +917,7 @@ verifyBACnetApplicationDataValue(BACNET_APPLICATION_DATA_VALUE *value)
  * @brief Test
  */
 static void verifyBACnetComplexDataValue(
-    BACNET_APPLICATION_DATA_VALUE *value,
+    const BACNET_APPLICATION_DATA_VALUE *value,
     BACNET_OBJECT_TYPE object_type,
     BACNET_PROPERTY_ID prop)
 {

test/bacnet/bacerror/src/main.c

@@ -18,7 +18,7 @@
  */
 
 static int bacerror_decode_apdu(
-    uint8_t *apdu,
+    const uint8_t *apdu,
     unsigned apdu_size,
     uint8_t *invoke_id,
     BACNET_CONFIRMED_SERVICE *service,

test/bacnet/bacstr/src/main.c

@@ -95,7 +95,7 @@ static void testCharacterString(void)
 #endif
 {
     BACNET_CHARACTER_STRING bacnet_string;
-    char *value = "Joshua,Mary,Anna,Christopher";
+    const char *value = "Joshua,Mary,Anna,Christopher";
     char test_value[MAX_APDU] = "Patricia";
     char test_append_value[MAX_APDU] = " and the Kids";
     char test_append_string[MAX_APDU] = "";

test/bacnet/basic/bbmd/src/main.c

@@ -70,7 +70,8 @@ uint16_t bip_receive(
  * @return Upon successful completion, returns the number of bytes sent.
  *  Otherwise, -1 shall be returned and errno set to indicate the error.
  */
-int bip_send_mpdu(BACNET_IP_ADDRESS *dest, uint8_t *mtu, uint16_t mtu_len)
+int bip_send_mpdu(
+    const BACNET_IP_ADDRESS *dest, const uint8_t *mtu, uint16_t mtu_len)
 {
     uint8_t message_type = 0;
     uint16_t message_length = 0;

test/bacnet/basic/bbmd6/src/main.c

@@ -75,7 +75,8 @@ uint16_t bip6_receive(
  * @return Upon successful completion, returns the number of bytes sent.
  *  Otherwise, -1 shall be returned and errno set to indicate the error.
  */
-int bip6_send_mpdu(BACNET_IP6_ADDRESS *dest, uint8_t *mtu, uint16_t mtu_len)
+int bip6_send_mpdu(
+    const BACNET_IP6_ADDRESS *dest, const uint8_t *mtu, uint16_t mtu_len)
 {
     uint8_t message_type = 0;
     uint16_t message_length = 0;

test/bacnet/basic/object/nc/stubs.c

@@ -19,7 +19,9 @@ uint32_t Device_Object_Instance_Number(void)
 }
 
 int Send_UEvent_Notify(
-    uint8_t *buffer, BACNET_EVENT_NOTIFICATION_DATA *data, BACNET_ADDRESS *dest)
+    uint8_t *buffer,
+    const BACNET_EVENT_NOTIFICATION_DATA *data,
+    BACNET_ADDRESS *dest)
 {
     (void)buffer;
     (void)data;

test/bacnet/basic/object/test/device_mock.c

@@ -11,7 +11,7 @@
 #include <bacnet/basic/object/device.h>
 
 bool Device_Valid_Object_Name(
-    BACNET_CHARACTER_STRING *object_name,
+    const BACNET_CHARACTER_STRING *object_name,
     BACNET_OBJECT_TYPE *object_type,
     uint32_t *object_instance)
 {

test/bacnet/basic/object/test/property_test.h

@@ -15,7 +15,7 @@
 
 /* function API pattern for testing ASCII name get/set */
 typedef bool (*object_name_ascii_set_function) (uint32_t object_instance,
-    char *new_name);
+    const char *new_name);
 typedef const char * (*object_name_ascii_function) (
     uint32_t object_instance);
 

test/bacnet/basic/sys/filename/src/main.c

@@ -25,12 +25,12 @@ ZTEST(filename_tests, testFilename)
 static void testFilename(void)
 #endif
 {
-    char *data1 = "c:\\Joshua\\run";
-    char *data2 = "/home/Anna/run";
-    char *data3 = "c:\\Program Files\\Christopher\\run.exe";
-    char *data4 = "//Mary/data/run";
-    char *data5 = "bin\\run";
-    char *filename = NULL;
+    const char *data1 = "c:\\Joshua\\run";
+    const char *data2 = "/home/Anna/run";
+    const char *data3 = "c:\\Program Files\\Christopher\\run.exe";
+    const char *data4 = "//Mary/data/run";
+    const char *data5 = "bin\\run";
+    const char *filename = NULL;
 
     filename = filename_remove_path(data1);
     zassert_equal(strcmp("run", filename), 0, NULL);

test/bacnet/cov/src/main.c

@@ -21,7 +21,10 @@
  * @brief Test encode/decode API for unsigned 16b integers
  */
 int ccov_notify_decode_apdu(
-    uint8_t *apdu, unsigned apdu_len, uint8_t *invoke_id, BACNET_COV_DATA *data)
+    const uint8_t *apdu,
+    unsigned apdu_len,
+    uint8_t *invoke_id,
+    BACNET_COV_DATA *data)
 {
     int len = 0;
     unsigned offset = 0;
@@ -48,7 +51,7 @@ int ccov_notify_decode_apdu(
 }
 
 int ucov_notify_decode_apdu(
-    uint8_t *apdu, unsigned apdu_len, BACNET_COV_DATA *data)
+    const uint8_t *apdu, unsigned apdu_len, BACNET_COV_DATA *data)
 {
     int len = 0;
     unsigned offset = 0;
@@ -71,7 +74,7 @@ int ucov_notify_decode_apdu(
 }
 
 static int cov_subscribe_decode_apdu(
-    uint8_t *apdu,
+    const uint8_t *apdu,
     unsigned apdu_len,
     uint8_t *invoke_id,
     BACNET_SUBSCRIBE_COV_DATA *data)
@@ -100,7 +103,7 @@ static int cov_subscribe_decode_apdu(
 }
 
 static int cov_subscribe_property_decode_apdu(
-    uint8_t *apdu,
+    const uint8_t *apdu,
     unsigned apdu_len,
     uint8_t *invoke_id,
     BACNET_SUBSCRIBE_COV_DATA *data)
@@ -129,9 +132,10 @@ static int cov_subscribe_property_decode_apdu(
 }
 
 /* dummy function stubs */
-static void testCOVNotifyData(BACNET_COV_DATA *data, BACNET_COV_DATA *test_data)
+static void testCOVNotifyData(
+    const BACNET_COV_DATA *data, BACNET_COV_DATA *test_data)
 {
-    BACNET_PROPERTY_VALUE *value = NULL;
+    const BACNET_PROPERTY_VALUE *value = NULL;
     BACNET_PROPERTY_VALUE *test_value = NULL;
 
     zassert_equal(
@@ -170,7 +174,7 @@ static void testCOVNotifyData(BACNET_COV_DATA *data, BACNET_COV_DATA *test_data)
     }
 }
 
-static void testUCOVNotifyData(BACNET_COV_DATA *data)
+static void testUCOVNotifyData(const BACNET_COV_DATA *data)
 {
     uint8_t apdu[480] = { 0 };
     int len = 0, null_len = 0, apdu_len = 0;
@@ -190,7 +194,7 @@ static void testUCOVNotifyData(BACNET_COV_DATA *data)
     testCOVNotifyData(data, &test_data);
 }
 
-static void testCCOVNotifyData(uint8_t invoke_id, BACNET_COV_DATA *data)
+static void testCCOVNotifyData(uint8_t invoke_id, const BACNET_COV_DATA *data)
 {
     uint8_t apdu[480] = { 0 };
     int len = 0, null_len = 0, apdu_len = 0;
@@ -247,7 +251,8 @@ static void testCOVNotify(void)
 }
 
 static void testCOVSubscribeData(
-    BACNET_SUBSCRIBE_COV_DATA *data, BACNET_SUBSCRIBE_COV_DATA *test_data)
+    const BACNET_SUBSCRIBE_COV_DATA *data,
+    const BACNET_SUBSCRIBE_COV_DATA *test_data)
 {
     zassert_equal(
         test_data->subscriberProcessIdentifier,
@@ -272,7 +277,8 @@ static void testCOVSubscribeData(
 }
 
 static void testCOVSubscribePropertyData(
-    BACNET_SUBSCRIBE_COV_DATA *data, BACNET_SUBSCRIBE_COV_DATA *test_data)
+    const BACNET_SUBSCRIBE_COV_DATA *data,
+    const BACNET_SUBSCRIBE_COV_DATA *test_data)
 {
     testCOVSubscribeData(data, test_data);
     zassert_equal(
@@ -290,7 +296,8 @@ static void testCOVSubscribePropertyData(
 }
 
 static void
-testCOVSubscribeEncoding(uint8_t invoke_id, BACNET_SUBSCRIBE_COV_DATA *data)
+testCOVSubscribeEncoding(
+    uint8_t invoke_id, const BACNET_SUBSCRIBE_COV_DATA *data)
 {
     uint8_t apdu[480] = { 0 };
     int len = 0;
@@ -310,7 +317,7 @@ testCOVSubscribeEncoding(uint8_t invoke_id, BACNET_SUBSCRIBE_COV_DATA *data)
 }
 
 static void testCOVSubscribePropertyEncoding(
-    uint8_t invoke_id, BACNET_SUBSCRIBE_COV_DATA *data)
+    uint8_t invoke_id, const BACNET_SUBSCRIBE_COV_DATA *data)
 {
     uint8_t apdu[480] = { 0 };
     int len = 0;

test/bacnet/datalink/bvlc/src/main.c

@@ -22,14 +22,15 @@
  * @brief Test
  */
 static void test_BVLC_Address(
-    BACNET_IP_ADDRESS *bip_address_1, BACNET_IP_ADDRESS *bip_address_2)
+    const BACNET_IP_ADDRESS *bip_address_1,
+    const BACNET_IP_ADDRESS *bip_address_2)
 {
     zassert_false(bvlc_address_different(bip_address_1, bip_address_2), NULL);
 }
 
 static void test_BVLC_Broadcast_Distribution_Mask(
-    BACNET_IP_BROADCAST_DISTRIBUTION_MASK *bd_mask_1,
-    BACNET_IP_BROADCAST_DISTRIBUTION_MASK *bd_mask_2)
+    const BACNET_IP_BROADCAST_DISTRIBUTION_MASK *bd_mask_1,
+    const BACNET_IP_BROADCAST_DISTRIBUTION_MASK *bd_mask_2)
 {
     zassert_false(
         bvlc_broadcast_distribution_mask_different(bd_mask_1, bd_mask_2), NULL);
@@ -68,7 +69,7 @@ static void test_BVLC_Foreign_Device_Table_Entry(
 }
 
 static int test_BVLC_Header(
-    uint8_t *pdu,
+    const uint8_t *pdu,
     uint16_t pdu_len,
     uint8_t *message_type,
     uint16_t *message_length)
@@ -175,8 +176,8 @@ static void test_BVLC_Original_Unicast_NPDU(void)
     test_BVLC_Original_Unicast_NPDU_Message(npdu, npdu_len);
 }
 
-static void
-test_BVLC_Original_Broadcast_NPDU_Message(uint8_t *npdu, uint16_t npdu_len)
+static void test_BVLC_Original_Broadcast_NPDU_Message(
+    const uint8_t *npdu, uint16_t npdu_len)
 {
     uint8_t test_npdu[50] = { 0 };
     uint8_t pdu[60] = { 0 };
@@ -223,7 +224,9 @@ static void test_BVLC_Original_Broadcast_NPDU(void)
 }
 
 static void test_BVLC_Forwarded_NPDU_Message(
-    uint8_t *npdu, uint16_t npdu_len, BACNET_IP_ADDRESS *bip_address)
+    const uint8_t *npdu,
+    uint16_t npdu_len,
+    const BACNET_IP_ADDRESS *bip_address)
 {
     uint8_t test_npdu[50] = { 0 };
     uint8_t pdu[75] = { 0 };
@@ -314,7 +317,7 @@ static void test_BVLC_Register_Foreign_Device(void)
 }
 
 static void test_BVLC_Delete_Foreign_Device_Message(
-    BACNET_IP_FOREIGN_DEVICE_TABLE_ENTRY *fdt_entry)
+    const BACNET_IP_FOREIGN_DEVICE_TABLE_ENTRY *fdt_entry)
 {
     uint8_t pdu[64] = { 0 };
     BACNET_IP_FOREIGN_DEVICE_TABLE_ENTRY test_fdt_entry = { 0 };
@@ -362,7 +365,8 @@ static void test_BVLC_Delete_Foreign_Device(void)
     test_BVLC_Delete_Foreign_Device_Message(&fdt_entry);
 }
 
-static void test_BVLC_Secure_BVLL_Message(uint8_t *sbuf, uint16_t sbuf_len)
+static void test_BVLC_Secure_BVLL_Message(
+    const uint8_t *sbuf, uint16_t sbuf_len)
 {
     uint8_t test_sbuf[50] = { 0 };
     uint8_t pdu[60] = { 0 };
@@ -429,7 +433,7 @@ static void test_BVLC_Read_Broadcast_Distribution_Table_Message(void)
 }
 
 static void test_BVLC_Distribute_Broadcast_To_Network_Message(
-    uint8_t *npdu, uint16_t npdu_len)
+    const uint8_t *npdu, uint16_t npdu_len)
 {
     uint8_t test_npdu[50] = { 0 };
     uint8_t pdu[60] = { 0 };

test/bacnet/datalink/mock/src/bip-mock.c

@@ -19,7 +19,7 @@ bool bip_init(char *ifname)
     return ztest_get_return_value();
 }
 
-void bip_set_interface(char *ifname)
+void bip_set_interface(const char *ifname)
 {
     ztest_check_expected_value(ifname);
 }
@@ -56,7 +56,8 @@ int bip_send_pdu(
     return ztest_get_return_value();
 }
 
-int bip_send_mpdu(BACNET_IP_ADDRESS *dest, uint8_t *mtu, uint16_t mtu_len)
+int bip_send_mpdu(
+    const BACNET_IP_ADDRESS *dest, const uint8_t *mtu, uint16_t mtu_len)
 {
     ztest_check_expected_value(dest);
     ztest_check_expected_data(mtu, mtu_len);
@@ -87,7 +88,7 @@ uint16_t bip_get_port(void)
     return ztest_get_return_value();
 }
 
-bool bip_set_addr(BACNET_IP_ADDRESS *addr)
+bool bip_set_addr(const BACNET_IP_ADDRESS *addr)
 {
     ztest_check_expected_data(addr, sizeof(BACNET_IP_ADDRESS));
     return ztest_get_return_value();
@@ -111,7 +112,7 @@ void bip_get_broadcast_address(BACNET_ADDRESS *dest)
     ztest_copy_return_data(dest, sizeof(BACNET_ADDRESS));
 }
 
-bool bip_set_broadcast_addr(BACNET_IP_ADDRESS *addr)
+bool bip_set_broadcast_addr(const BACNET_IP_ADDRESS *addr)
 {
     return ztest_get_return_value();
 }

test/bacnet/datalink/mock/src/bip6-mock.c

@@ -58,13 +58,13 @@ void bip6_set_interface(char *ifname)
     ztest_check_expected_value(ifname);
 }
 
-bool bip6_address_match_self(BACNET_IP6_ADDRESS *addr)
+bool bip6_address_match_self(const BACNET_IP6_ADDRESS *addr)
 {
     ztest_check_expected_value(addr);
     return ztest_get_return_value();
 }
 
-bool bip6_set_addr(BACNET_IP6_ADDRESS *addr)
+bool bip6_set_addr(const BACNET_IP6_ADDRESS *addr)
 {
     ztest_check_expected_data(addr, sizeof(BACNET_IP6_ADDRESS));
     return ztest_get_return_value();
@@ -91,12 +91,12 @@ void bip6_get_broadcast_address(BACNET_ADDRESS *my_address)
     ztest_copy_return_data(my_address, sizeof(BACNET_ADDRESS));
 }
 
-bool bip6_set_broadcast_addr(BACNET_IP6_ADDRESS *addr)
+bool bip6_set_broadcast_addr(const BACNET_IP6_ADDRESS *addr)
 {
     return ztest_get_return_value();
 }
 
-int bip6_send_mpdu(BACNET_IP6_ADDRESS *dest, uint8_t *mtu, uint16_t mtu_len)
+int bip6_send_mpdu(const BACNET_IP6_ADDRESS *dest, const uint8_t *mtu, uint16_t mtu_len)
 {
     ztest_check_expected_value(dest);
     ztest_check_expected_data(mtu, mtu_len);

test/bacnet/datalink/mock/src/ethernet-mock.c

@@ -45,7 +45,7 @@ uint16_t ethernet_receive(
     return ztest_get_return_value();
 }
 
-void ethernet_set_my_address(BACNET_ADDRESS *my_address)
+void ethernet_set_my_address(const BACNET_ADDRESS *my_address)
 {
     ztest_check_expected_data(my_address, sizeof(BACNET_ADDRESS));
 }
@@ -60,7 +60,7 @@ void ethernet_get_broadcast_address(BACNET_ADDRESS *dest)
     ztest_copy_return_data(dest, sizeof(BACNET_ADDRESS));
 }
 
-void ethernet_debug_address(const char *info, BACNET_ADDRESS *dest)
+void ethernet_debug_address(const char *info, const BACNET_ADDRESS *dest)
 {
     ztest_check_expected_value(info);
     ztest_check_expected_value(dest);

test/bacnet/datalink/mstp/src/main.c

@@ -45,7 +45,9 @@ static uint8_t TxBuffer[MAX_MPDU];
  * @param nbytes number of bytes to send
  */
 void RS485_Send_Frame(
-    struct mstp_port_struct_t *mstp_port, uint8_t *buffer, uint16_t nbytes)
+    struct mstp_port_struct_t *mstp_port,
+    const uint8_t *buffer,
+    uint16_t nbytes)
 {
     (void)mstp_port;
     (void)buffer;
@@ -61,7 +63,7 @@ static FIFO_BUFFER Test_Queue;
  * @param buffer pointer to the data
  * @param len number of bytes to load
  */
-static void Load_Input_Buffer(uint8_t *buffer, size_t len)
+static void Load_Input_Buffer(const uint8_t *buffer, size_t len)
 {
     static bool initialized = false; /* tracks our init */
     if (!initialized) {
@@ -154,7 +156,9 @@ static void Timer_Silence_Reset(void *pArg)
  * @param nbytes number of bytes to send
  */
 void MSTP_Send_Frame(
-    struct mstp_port_struct_t *mstp_port, uint8_t *buffer, uint16_t nbytes)
+    struct mstp_port_struct_t *mstp_port,
+    const uint8_t *buffer,
+    uint16_t nbytes)
 {
     if (mstp_port && mstp_port->OutputBuffer && buffer && (nbytes > 0) &&
         (nbytes <= mstp_port->OutputBufferSize)) {

test/bacnet/dcc/src/main.c

@@ -20,7 +20,7 @@
  * @brief Test
  */
 static int dcc_decode_apdu(
-    uint8_t *apdu,
+    const uint8_t *apdu,
     unsigned apdu_size,
     uint8_t *invoke_id,
     uint16_t *timeDuration,
@@ -64,7 +64,7 @@ static void test_DeviceCommunicationControlData(
     uint8_t invoke_id,
     uint16_t timeDuration,
     BACNET_COMMUNICATION_ENABLE_DISABLE enable_disable,
-    BACNET_CHARACTER_STRING *password)
+    const BACNET_CHARACTER_STRING *password)
 {
     uint8_t apdu[480] = { 0 };
     int apdu_size = 0, null_len = 0, test_len = 0;

test/bacnet/getalarm/src/main.c

@@ -24,7 +24,7 @@
  * @return number of bytes decoded
  */
 static int get_alarm_summary_decode_apdu(
-    uint8_t *apdu, unsigned apdu_size, uint8_t *invoke_id)
+    const uint8_t *apdu, unsigned apdu_size, uint8_t *invoke_id)
 {
     if (!apdu) {
         return BACNET_STATUS_ERROR;
@@ -53,7 +53,7 @@ static int get_alarm_summary_decode_apdu(
  * @return number of bytes decoded
  */
 static int get_alarm_summary_ack_decode_apdu(
-    uint8_t *apdu,
+    const uint8_t *apdu,
     int apdu_len,
     uint8_t *invoke_id,
     BACNET_GET_ALARM_SUMMARY_DATA *get_alarm_data)

test/bacnet/getevent/src/main.c

@@ -20,7 +20,7 @@
  * @brief Test
  */
 static int getevent_decode_apdu(
-    uint8_t *apdu,
+    const uint8_t *apdu,
     unsigned apdu_size,
     uint8_t *invoke_id,
     BACNET_OBJECT_ID *lastReceivedObjectIdentifier)
@@ -58,7 +58,7 @@ static int getevent_decode_apdu(
 }
 
 static int getevent_ack_decode_apdu(
-    uint8_t *apdu,
+    const uint8_t *apdu,
     int apdu_len, /* total length of the apdu */
     uint8_t *invoke_id,
     BACNET_GET_EVENT_INFORMATION_DATA *get_event_data,

test/bacnet/iam/src/main.c

@@ -20,7 +20,7 @@
  * @brief Test
  */
 static int iam_decode_apdu(
-    uint8_t *apdu,
+    const uint8_t *apdu,
     uint32_t *pDevice_id,
     unsigned *pMax_apdu,
     int *pSegmentation,

test/bacnet/ihave/src/main.c

@@ -19,7 +19,7 @@
 /**
  * @brief Test
  */
-static void testIHaveData(BACNET_I_HAVE_DATA *data)
+static void testIHaveData(const BACNET_I_HAVE_DATA *data)
 {
     uint8_t apdu[480] = { 0 };
     int len = 0;

test/bacnet/rd/src/main.c

@@ -21,7 +21,7 @@
  * @brief Test
  */
 static int rd_decode_apdu(
-    uint8_t *apdu,
+    const uint8_t *apdu,
     unsigned apdu_size,
     uint8_t *invoke_id,
     BACNET_REINITIALIZED_STATE *state,

test/bacnet/reject/src/main.c

@@ -21,7 +21,7 @@
  */
 /* decode the whole APDU - mainly used for unit testing */
 static int reject_decode_apdu(
-    uint8_t *apdu,
+    const uint8_t *apdu,
     unsigned apdu_len,
     uint8_t *invoke_id,
     uint8_t *reject_reason)

test/bacnet/rp/src/main.c

@@ -21,7 +21,7 @@
  * @brief Test
  */
 static int rp_decode_apdu(
-    uint8_t *apdu,
+    const uint8_t *apdu,
     unsigned apdu_size,
     uint8_t *invoke_id,
     BACNET_READ_PROPERTY_DATA *rpdata)

test/bacnet/timesync/src/main.c

@@ -21,7 +21,8 @@
  * @brief Test
  */
 static void testTimeSyncRecipientData(
-    BACNET_RECIPIENT_LIST *recipient1, BACNET_RECIPIENT_LIST *recipient2)
+    const BACNET_RECIPIENT_LIST *recipient1,
+    const BACNET_RECIPIENT_LIST *recipient2)
 {
     unsigned i = 0;
 
@@ -124,7 +125,7 @@ static void testTimeSyncRecipient(void)
 }
 
 static int timesync_decode_apdu_service(
-    uint8_t *apdu,
+    const uint8_t *apdu,
     BACNET_UNCONFIRMED_SERVICE service,
     unsigned apdu_len,
     BACNET_DATE *my_date,
@@ -149,7 +150,7 @@ static int timesync_decode_apdu_service(
 }
 
 int timesync_utc_decode_apdu(
-    uint8_t *apdu,
+    const uint8_t *apdu,
     unsigned apdu_len,
     BACNET_DATE *my_date,
     BACNET_TIME *my_time)
@@ -160,7 +161,7 @@ int timesync_utc_decode_apdu(
 }
 
 int timesync_decode_apdu(
-    uint8_t *apdu,
+    const uint8_t *apdu,
     unsigned apdu_len,
     BACNET_DATE *my_date,
     BACNET_TIME *my_time)
@@ -170,7 +171,8 @@ int timesync_decode_apdu(
         my_time);
 }
 
-static void testTimeSyncData(BACNET_DATE *my_date, BACNET_TIME *my_time)
+static void testTimeSyncData(
+    const BACNET_DATE *my_date, const BACNET_TIME *my_time)
 {
     uint8_t apdu[480] = { 0 };
     int len = 0;

test/bacnet/whohas/src/main.c

@@ -18,7 +18,7 @@
  * @brief Test
  */
 int whohas_decode_apdu(
-    uint8_t *apdu, unsigned apdu_size, BACNET_WHO_HAS_DATA *data)
+    const uint8_t *apdu, unsigned apdu_size, BACNET_WHO_HAS_DATA *data)
 {
     int len = 0;
 

test/bacnet/whois/src/main.c

@@ -21,7 +21,10 @@
  * @brief Test
  */
 static int whois_decode_apdu(
-    uint8_t *apdu, unsigned apdu_len, int32_t *pLow_limit, int32_t *pHigh_limit)
+    const uint8_t *apdu,
+    unsigned apdu_len,
+    int32_t *pLow_limit,
+    int32_t *pHigh_limit)
 {
     int len = 0;
 

test/bacnet/wp/src/main.c

@@ -21,7 +21,7 @@
  * @return number of bytes decoded, or #BACNET_STATUS_ERROR
  */
 static int wp_decode_apdu(
-    uint8_t *apdu,
+    const uint8_t *apdu,
     unsigned apdu_size,
     uint8_t *invoke_id,
     BACNET_WRITE_PROPERTY_DATA *wpdata)
@@ -63,7 +63,7 @@ static int wp_decode_apdu(
     return apdu_len;
 }
 
-static void testWritePropertyTag(BACNET_APPLICATION_DATA_VALUE *value)
+static void testWritePropertyTag(const BACNET_APPLICATION_DATA_VALUE *value)
 {
     BACNET_WRITE_PROPERTY_DATA wpdata = { 0 };
     BACNET_WRITE_PROPERTY_DATA test_data = { 0 };

test/bacnet/wpm/src/main.c

@@ -17,7 +17,8 @@
 /**
  * @brief Decode service header for WritePropertyMultiple
  */
-static int wpm_decode_apdu(uint8_t *apdu, unsigned apdu_len, uint8_t *invoke_id)
+static int wpm_decode_apdu(
+    const uint8_t *apdu, unsigned apdu_len, uint8_t *invoke_id)
 {
     int len = 0;
 

test/unit/bacnet/bacerror/src/fakes/bacdcode.c

@@ -16,7 +16,7 @@ DEFINE_FAKE_VALUE_FUNC(int, decode_tag_number, uint8_t *, uint8_t *);
 DEFINE_FAKE_VALUE_FUNC(int, bacnet_tag_number_decode, uint8_t *, uint32_t, uint8_t *);
 #endif
 DEFINE_FAKE_VALUE_FUNC(
-    int, decode_tag_number_and_value, uint8_t *, uint8_t *, uint32_t *);
+    int, decode_tag_number_and_value, const uint8_t *, uint8_t *, uint32_t *);
 #if 0
 DEFINE_FAKE_VALUE_FUNC(int, bacnet_tag_number_and_value_decode, uint8_t *, uint32_t, uint8_t *, uint32_t *);
 DEFINE_FAKE_VALUE_FUNC(bool, decode_is_opening_tag_number, uint8_t *, uint8_t);
@@ -86,7 +86,7 @@ DEFINE_FAKE_VALUE_FUNC(int, bacnet_signed_application_decode, uint8_t *, uint16_
 DEFINE_FAKE_VALUE_FUNC(int, bacnet_enumerated_decode, uint8_t *, uint16_t, uint32_t, uint32_t *);
 DEFINE_FAKE_VALUE_FUNC(int, bacnet_enumerated_context_decode, uint8_t *, uint16_t, uint8_t, uint32_t *);
 #endif
-DEFINE_FAKE_VALUE_FUNC(int, decode_enumerated, uint8_t *, uint32_t, uint32_t *);
+DEFINE_FAKE_VALUE_FUNC(int, decode_enumerated, const uint8_t *, uint32_t, uint32_t *);
 #if 0
 DEFINE_FAKE_VALUE_FUNC(int, decode_context_enumerated, uint8_t *, uint8_t, uint32_t *);
 DEFINE_FAKE_VALUE_FUNC(int, encode_bacnet_enumerated, uint8_t *, uint32_t);

test/unit/bacnet/bacerror/src/fakes/bacdcode.h

@@ -29,7 +29,7 @@ DECLARE_FAKE_VALUE_FUNC(int, decode_tag_number, uint8_t *, uint8_t *);
 DECLARE_FAKE_VALUE_FUNC(int, bacnet_tag_number_decode, uint8_t *, uint32_t, uint8_t *);
 #endif
 DECLARE_FAKE_VALUE_FUNC(
-    int, decode_tag_number_and_value, uint8_t *, uint8_t *, uint32_t *);
+    int, decode_tag_number_and_value, const uint8_t *, uint8_t *, uint32_t *);
 #if 0
 DECLARE_FAKE_VALUE_FUNC(int, bacnet_tag_number_and_value_decode, uint8_t *, uint32_t, uint8_t *, uint32_t *);
 DECLARE_FAKE_VALUE_FUNC(bool, decode_is_opening_tag_number, uint8_t *, uint8_t);
@@ -100,7 +100,7 @@ DECLARE_FAKE_VALUE_FUNC(int, bacnet_enumerated_decode, uint8_t *, uint16_t, uint
 DECLARE_FAKE_VALUE_FUNC(int, bacnet_enumerated_context_decode, uint8_t *, uint16_t, uint8_t, uint32_t *);
 #endif
 DECLARE_FAKE_VALUE_FUNC(
-    int, decode_enumerated, uint8_t *, uint32_t, uint32_t *);
+    int, decode_enumerated, const uint8_t *, uint32_t, uint32_t *);
 #if 0
 DECLARE_FAKE_VALUE_FUNC(int, decode_context_enumerated, uint8_t *, uint8_t, uint32_t *);
 DECLARE_FAKE_VALUE_FUNC(int, encode_bacnet_enumerated, uint8_t *, uint32_t);

test/unit/bacnet/bacerror/src/main.c

@@ -93,7 +93,7 @@ struct decode_tag_number_and_value_custom_fake_context {
 };
 
 static int decode_tag_number_and_value_custom_fake(
-    uint8_t *apdu, uint8_t *tag_number, uint32_t *value)
+    const uint8_t *apdu, uint8_t *tag_number, uint32_t *value)
 {
     RETURN_HANDLED_CONTEXT(decode_tag_number_and_value,
         struct decode_tag_number_and_value_custom_fake_context,
@@ -125,7 +125,7 @@ struct decode_enumerated_custom_fake_context {
 };
 
 static int decode_enumerated_custom_fake(
-    uint8_t *apdu, uint32_t len_value, uint32_t *value)
+    const uint8_t *apdu, uint32_t len_value, uint32_t *value)
 {
     RETURN_HANDLED_CONTEXT(decode_enumerated,
         struct decode_enumerated_custom_fake_context,