Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
49 lines
870 B
C
49 lines
870 B
C
/**
|
|
* @file
|
|
* @brief mock Device object functions
|
|
* @author Mikhail Antropov
|
|
* @date July 2022
|
|
*
|
|
* SPDX-License-Identifier: MIT
|
|
*/
|
|
#include <zephyr/ztest.h>
|
|
#include <bacnet/bactext.h>
|
|
#include <bacnet/basic/object/device.h>
|
|
|
|
bool Device_Valid_Object_Name(
|
|
const BACNET_CHARACTER_STRING *object_name,
|
|
BACNET_OBJECT_TYPE *object_type,
|
|
uint32_t *object_instance)
|
|
{
|
|
(void)object_name;
|
|
(void)object_type;
|
|
(void)object_instance;
|
|
return true;
|
|
}
|
|
|
|
void Device_Inc_Database_Revision(void)
|
|
{
|
|
}
|
|
|
|
uint32_t Device_Object_Instance_Number(void)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
bool Device_Write_Property(BACNET_WRITE_PROPERTY_DATA *wp_data)
|
|
{
|
|
(void)wp_data;
|
|
return false;
|
|
}
|
|
|
|
void Device_getCurrentDateTime(BACNET_DATE_TIME *DateTime)
|
|
{
|
|
(void)DateTime;
|
|
}
|
|
|
|
int Device_Read_Property(BACNET_READ_PROPERTY_DATA *rpdata)
|
|
{
|
|
(void)rpdata;
|
|
return 0;
|
|
}
|