dali/bacnet_stack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed the NDPU encoding for confirmed COV notifications (#917)

Browse Source
This commit is contained in:
Steve Karg
2025-02-18 08:44:16 -06:00
committed by GitHub
parent aa87bd8051
commit 97490dacb1
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bacnet/basic/service/h_cov.c
+3 -2
View File
@@ -472,7 +472,9 @@ static bool cov_send_request(
return status; return status;
} }
datalink_get_my_address(&my_address); datalink_get_my_address(&my_address);
npdu_encode_npdu_data(&npdu_data, false, MESSAGE_PRIORITY_NORMAL); npdu_encode_npdu_data(
&npdu_data, cov_subscription->flag.issueConfirmedNotifications,
MESSAGE_PRIORITY_NORMAL);
pdu_len = npdu_encode_pdu( pdu_len = npdu_encode_pdu(
&Handler_Transmit_Buffer[0], dest, &my_address, &npdu_data); &Handler_Transmit_Buffer[0], dest, &my_address, &npdu_data);
/* load the COV data structure for outgoing message */ /* load the COV data structure for outgoing message */
@@ -486,7 +488,6 @@ static bool cov_send_request(
cov_data.timeRemaining = cov_subscription->lifetime; cov_data.timeRemaining = cov_subscription->lifetime;
cov_data.listOfValues = value_list; cov_data.listOfValues = value_list;
if (cov_subscription->flag.issueConfirmedNotifications) { if (cov_subscription->flag.issueConfirmedNotifications) {
npdu_data.data_expecting_reply = true;
invoke_id = tsm_next_free_invokeID(); invoke_id = tsm_next_free_invokeID();
if (invoke_id) { if (invoke_id) {
cov_subscription->invokeID = invoke_id; cov_subscription->invokeID = invoke_id;