From 97490dacb12896154901c4df259d90703c77a6d0 Mon Sep 17 00:00:00 2001 From: Steve Karg Date: Tue, 18 Feb 2025 08:44:16 -0600 Subject: [PATCH] Fixed the NDPU encoding for confirmed COV notifications (#917) --- src/bacnet/basic/service/h_cov.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/bacnet/basic/service/h_cov.c b/src/bacnet/basic/service/h_cov.c index fb379012..187c70c9 100644 --- a/src/bacnet/basic/service/h_cov.c +++ b/src/bacnet/basic/service/h_cov.c @@ -472,7 +472,9 @@ static bool cov_send_request( return status; } datalink_get_my_address(&my_address); - npdu_encode_npdu_data(&npdu_data, false, MESSAGE_PRIORITY_NORMAL); + npdu_encode_npdu_data( + &npdu_data, cov_subscription->flag.issueConfirmedNotifications, + MESSAGE_PRIORITY_NORMAL); pdu_len = npdu_encode_pdu( &Handler_Transmit_Buffer[0], dest, &my_address, &npdu_data); /* load the COV data structure for outgoing message */ @@ -486,7 +488,6 @@ static bool cov_send_request( cov_data.timeRemaining = cov_subscription->lifetime; cov_data.listOfValues = value_list; if (cov_subscription->flag.issueConfirmedNotifications) { - npdu_data.data_expecting_reply = true; invoke_id = tsm_next_free_invokeID(); if (invoke_id) { cov_subscription->invokeID = invoke_id;