fix the bacapp snprintf return size (#294)

Co-authored-by: Steve Karg <skarg@users.sourceforge.net>
2022-06-12 15:02:05 -05:00
parent 6490daacba
commit 20ffb968ef
1 changed files with 2 additions and 3 deletions
@@ -1169,7 +1169,7 @@ int bacapp_snprintf_value(
    BACNET_APPLICATION_DATA_VALUE *value;
    BACNET_PROPERTY_ID property = PROP_ALL;
    BACNET_OBJECT_TYPE object_type = MAX_BACNET_OBJECT_TYPE;
-    int ret_val = BACNET_STATUS_ERROR;
+    int ret_val = 0;
    int slen = 0;
 #if defined(BACAPP_OCTET_STRING) || defined (BACAPP_TYPES_EXTRA)
    uint8_t *octet_str;
@@ -1561,7 +1561,7 @@ int bacapp_snprintf_value(
                    }
                }
                ret_val += slen;
-                slen = snprintf(str, str_len, "%lu",
+                slen = snprintf(str, str_len, "%lu)",
                    (unsigned long)value->type.Object_Id.instance);
                ret_val += slen;
                break;
@@ -1643,7 +1643,6 @@ int bacapp_snprintf_value(
                break;
 #endif
            default:
-                ret_val = 0;
                break;
        }
    }