From 20ffb968efd9f421ea9e2b0ac7cf952ee8b75463 Mon Sep 17 00:00:00 2001 From: Steve Karg Date: Sun, 12 Jun 2022 15:02:05 -0500 Subject: [PATCH] fix the bacapp snprintf return size (#294) Co-authored-by: Steve Karg --- src/bacnet/bacapp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/bacnet/bacapp.c b/src/bacnet/bacapp.c index 8399447e..6aa0c355 100644 --- a/src/bacnet/bacapp.c +++ b/src/bacnet/bacapp.c @@ -1169,7 +1169,7 @@ int bacapp_snprintf_value( BACNET_APPLICATION_DATA_VALUE *value; BACNET_PROPERTY_ID property = PROP_ALL; BACNET_OBJECT_TYPE object_type = MAX_BACNET_OBJECT_TYPE; - int ret_val = BACNET_STATUS_ERROR; + int ret_val = 0; int slen = 0; #if defined(BACAPP_OCTET_STRING) || defined (BACAPP_TYPES_EXTRA) uint8_t *octet_str; @@ -1561,7 +1561,7 @@ int bacapp_snprintf_value( } } ret_val += slen; - slen = snprintf(str, str_len, "%lu", + slen = snprintf(str, str_len, "%lu)", (unsigned long)value->type.Object_Id.instance); ret_val += slen; break; @@ -1643,7 +1643,6 @@ int bacapp_snprintf_value( break; #endif default: - ret_val = 0; break; } }