From fd3342a6839b3bb1a35023607afd1b381639b88c Mon Sep 17 00:00:00 2001 From: Bryan Oltman Date: Mon, 3 Feb 2025 09:53:17 -0500 Subject: [PATCH] fix: use temp dir for ios-framework release artifacts (#2830) --- .../shorebird_cli/lib/src/code_push_client_wrapper.dart | 8 +------- .../lib/src/commands/release/ios_framework_releaser.dart | 5 ++++- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/packages/shorebird_cli/lib/src/code_push_client_wrapper.dart b/packages/shorebird_cli/lib/src/code_push_client_wrapper.dart index dbe50b4b..6b99a0ff 100644 --- a/packages/shorebird_cli/lib/src/code_push_client_wrapper.dart +++ b/packages/shorebird_cli/lib/src/code_push_client_wrapper.dart @@ -4,9 +4,7 @@ // cspell:words xcarchive codesigned xcframework import 'dart:io'; -import 'dart:isolate'; -import 'package:archive/archive_io.dart'; import 'package:collection/collection.dart'; import 'package:crypto/crypto.dart'; import 'package:equatable/equatable.dart'; @@ -814,11 +812,7 @@ aar artifact already exists, continuing...''', }) async { final createArtifactProgress = logger.progress('Uploading artifacts'); final appFrameworkDirectory = Directory(appFrameworkPath); - await Isolate.run( - () => ZipFileEncoder().zipDirectory(appFrameworkDirectory), - ); - final zippedAppFrameworkFile = File('$appFrameworkPath.zip'); - + final zippedAppFrameworkFile = await appFrameworkDirectory.zipToTempFile(); try { await codePushClient.createReleaseArtifact( appId: appId, diff --git a/packages/shorebird_cli/lib/src/commands/release/ios_framework_releaser.dart b/packages/shorebird_cli/lib/src/commands/release/ios_framework_releaser.dart index 6af6fa3f..bc1b4432 100644 --- a/packages/shorebird_cli/lib/src/commands/release/ios_framework_releaser.dart +++ b/packages/shorebird_cli/lib/src/commands/release/ios_framework_releaser.dart @@ -35,7 +35,10 @@ class IosFrameworkReleaser extends Releaser { /// The directory where the release artifacts are stored. Directory get releaseDirectory => Directory( - p.join(shorebirdEnv.getShorebirdProjectRoot()!.path, 'release'), + p.join( + shorebirdEnv.getShorebirdProjectRoot()!.path, + 'release', + ), ); @override