From 9e5c37ebf1e6fa00fb4d94dfd816fd26f98594d5 Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Wed, 22 Mar 2023 16:17:52 -0500 Subject: [PATCH] docs: minor update to UPDATING_ENGINE.md --- updater/UPDATING_ENGINE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/updater/UPDATING_ENGINE.md b/updater/UPDATING_ENGINE.md index 5c0b6750..ee25e813 100644 --- a/updater/UPDATING_ENGINE.md +++ b/updater/UPDATING_ENGINE.md @@ -27,4 +27,4 @@ Where we are looking for the buildroot hash: https://github.com/flutter/engine/b e.g. `git rebase --onto 8747bce41d0dc6d9dc45c4d1b46d2100bb9ee688 93f7f85422a8604bdc44ef76c3f105ead65e8c1c` Where as that should be `--onto new_base_revision previous_base_revision`. The base revision is the git id *before* we started making changes. 1. Once you've successfully rebased the buildroot, you then need to change the buildroot id in our fork of the engine (so that when others use `gclient sync` it pulls our modified buildroot rather than an unmodified one. - +1. Finally, update the [Shorebird CLI flutterEngineRevision](https://github.com/shorebirdtech/shorebird/blob/main/packages/shorebird_cli/lib/src/flutter_engine_revision.dart#L3) to the new Flutter engine revision