diff --git a/.github/actions/pana/action.yaml b/.github/actions/pana/action.yaml deleted file mode 100644 index 5379129c..00000000 --- a/.github/actions/pana/action.yaml +++ /dev/null @@ -1,34 +0,0 @@ -name: Pana Workflow - -inputs: - min_score: - required: false - type: number - default: 120 - pana_version: - required: false - type: string - working_directory: - required: false - type: string - default: "." - -runs: - using: "composite" - steps: - - uses: subosito/flutter-action@v2 - with: - channel: stable - cache: true - - - working-directory: ${{ inputs.working_directory }} - shell: ${{ inputs.shell }} - run: flutter pub global activate pana ${{inputs.pana_version}} - - - working-directory: ${{ inputs.working_directory }} - shell: ${{ inputs.shell }} - run: | - PANA=$(pana . --no-warning); PANA_SCORE=$(echo $PANA | sed -n "s/.*Points: \([0-9]*\)\/\([0-9]*\)./\1\/\2/p") - echo "Score: $PANA_SCORE" - IFS='/'; read -a SCORE_ARR <<< "$PANA_SCORE"; SCORE=SCORE_ARR[0]; - if (( $SCORE < ${{inputs.min_score}} )); then echo "The minimum score of ${{inputs.min_score}} was not met!"; exit 1; fi diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml index e4d1f8f8..10ab4fbd 100644 --- a/.github/workflows/main.yaml +++ b/.github/workflows/main.yaml @@ -18,27 +18,11 @@ jobs: outputs: needs_build: ${{ steps.needs_build.outputs.changes }} - needs_pana: ${{ steps.needs_pana.outputs.changes }} needs_verify: ${{ steps.needs_verify.outputs.changes }} name: 👀 Detect Changes steps: - - uses: dorny/paths-filter@v2 - name: Pana Detection - id: needs_pana - with: - filters: | - shorebird_cli: - - ./.github/actions/dart_package - - packages/shorebird_cli/** - shorebird_code_push_api: - - ./.github/actions/dart_package - - packages/shorebird_code_push_api/** - shorebird_code_push_api_client: - - ./.github/actions/dart_package - - packages/shorebird_code_push_api_client/** - - uses: dorny/paths-filter@v2 name: Build Detection id: needs_build @@ -64,29 +48,6 @@ jobs: - ./.github/actions/dart_package - packages/shorebird_cli/** - pana_packages: - needs: changes - if: ${{ needs.changes.outputs.needs_pana != '[]' }} - - continue-on-error: true - - strategy: - matrix: - package: ${{ fromJSON(needs.changes.outputs.needs_pana) }} - - runs-on: ubuntu-latest - - name: 📊 Pana ${{ matrix.package }} - - steps: - - name: 📚 Git Checkout - uses: actions/checkout@v3 - - - name: 📊 Pana ${{ matrix.package }} - uses: ./.github/actions/pana - with: - working_directory: packages/${{ matrix.package }} - build_packages: needs: changes if: ${{ needs.changes.outputs.needs_build != '[]' }} @@ -130,8 +91,7 @@ jobs: working_directory: packages/${{ matrix.package }} ci: - needs: - [semantic_pull_request, pana_packages, build_packages, verify_packages] + needs: [semantic_pull_request, build_packages, verify_packages] if: ${{ always() }} runs-on: ubuntu-latest