From 6d589296f45f2f534c9a61bcdce9d69b697dcd4f Mon Sep 17 00:00:00 2001 From: Bryan Oltman Date: Wed, 15 May 2024 16:49:38 -0400 Subject: [PATCH] Revert "fix(shorebird_cli): don't export FLUTTER_STORAGE_BASE_URL in shorebird.ps1" (#2112) --- bin/shorebird.ps1 | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/bin/shorebird.ps1 b/bin/shorebird.ps1 index 3b24119a..1dc3464e 100644 --- a/bin/shorebird.ps1 +++ b/bin/shorebird.ps1 @@ -117,13 +117,9 @@ function Update-Flutter { # Set FLUTTER_STORAGE_BASE_URL=https://download.shorebird.dev and execute # a `flutter` command to trigger a download of Dart, etc. - # - # This is invoked in a subshell to avoid polluting the environment if the - # flutter command fails. See https://stackoverflow.com/a/69758192 for - # subshell suggestion and - # https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_pwsh?view=powershell-7.4 - # for official documentation on pwsh. - pwsh -Command { $env:FLUTTER_STORAGE_BASE_URL="https://download.shorebird.dev"; & $args[0] --version } -args $flutter + $env:FLUTTER_STORAGE_BASE_URL = 'https://download.shorebird.dev'; + & $flutter --version + Remove-Item Env:\FLUTTER_STORAGE_BASE_URL } function Update-Shorebird {