diff --git a/packages/shorebird_cli/lib/src/validators/android_internet_permission_validator.dart b/packages/shorebird_cli/lib/src/validators/android_internet_permission_validator.dart index e585e207..d224c63e 100644 --- a/packages/shorebird_cli/lib/src/validators/android_internet_permission_validator.dart +++ b/packages/shorebird_cli/lib/src/validators/android_internet_permission_validator.dart @@ -66,7 +66,9 @@ class AndroidInternetPermissionValidator extends Validator { .map( (String manifestPath) => ValidationIssue( severity: ValidationIssueSeverity.error, - message: '$manifestPath is missing the INTERNET permission.', + message: + '${p.relative(manifestPath, from: Directory.current.path)} ' + 'is missing the INTERNET permission.', fix: () => _addInternetPermissionToFile(manifestPath), ), ) diff --git a/packages/shorebird_cli/test/src/validators/android_internet_permission_validator_test.dart b/packages/shorebird_cli/test/src/validators/android_internet_permission_validator_test.dart index 9c189c8b..4be9c7f6 100644 --- a/packages/shorebird_cli/test/src/validators/android_internet_permission_validator_test.dart +++ b/packages/shorebird_cli/test/src/validators/android_internet_permission_validator_test.dart @@ -110,7 +110,7 @@ void main() { 'INTERNET permission', () async { final tempDirectory = createTempDir(); - final manifestPaths = [ + final relativeManifestPaths = [ 'internet_permission', 'debug', 'main', @@ -118,7 +118,6 @@ void main() { ] .map( (dir) => p.join( - tempDirectory.path, 'android', 'app', 'src', @@ -126,23 +125,26 @@ void main() { ), ) .toList(); - final badManifestPaths = manifestPaths.slice(1); + final absoluteManifestPaths = relativeManifestPaths + .map((path) => p.join(tempDirectory.path, path)) + .toList(); + final badManifestPaths = relativeManifestPaths.slice(1); writeManifestToPath( manifestWithInternetPermission, - manifestPaths[0], + absoluteManifestPaths[0], ); writeManifestToPath( manifestWithCommentedOutInternetPermission, - manifestPaths[1], + absoluteManifestPaths[1], ); writeManifestToPath( manifestWithNonInternetPermissions, - manifestPaths[2], + absoluteManifestPaths[2], ); writeManifestToPath( manifestWithNoPermissions, - manifestPaths[3], + absoluteManifestPaths[3], ); final results = await IOOverrides.runZoned(