From 3f3834f00708ce9a5ddb03ecbbc0537ebc5e0bcd Mon Sep 17 00:00:00 2001 From: Bryan Oltman Date: Wed, 19 Nov 2025 13:28:52 -0500 Subject: [PATCH] chore(artifact_proxy): delete generate_manifest.sh, it now lives in build_engine (#3391) --- .../test/artifact_proxy_test.dart | 33 ------- .../artifact_proxy/tool/generate_manifest.sh | 92 ------------------- 2 files changed, 125 deletions(-) delete mode 100755 packages/artifact_proxy/tool/generate_manifest.sh diff --git a/packages/artifact_proxy/test/artifact_proxy_test.dart b/packages/artifact_proxy/test/artifact_proxy_test.dart index 89a621be..8259def4 100644 --- a/packages/artifact_proxy/test/artifact_proxy_test.dart +++ b/packages/artifact_proxy/test/artifact_proxy_test.dart @@ -1,7 +1,6 @@ import 'dart:io'; import 'package:artifact_proxy/artifact_proxy.dart'; -import 'package:checked_yaml/checked_yaml.dart'; import 'package:mocktail/mocktail.dart'; import 'package:shelf/shelf.dart'; import 'package:test/test.dart'; @@ -122,37 +121,5 @@ void main() { expect(response.headers['content-type'], equals('text/html')); expect(response.readAsString(), completion(contains('Shorebird'))); }); - - // artifact_proxy only runs on linux currently. - test( - 'generate_manifest matches config', - () async { - // Make a temp directory, run generate_manifest, parse the yaml - // and make sure all urls are handled. - const engineRevision = '8b89f8bd9fc6982aa9c4557fd0e5e89db1ff9986'; - final result = Process.runSync('/bin/sh', [ - 'tool/generate_manifest.sh', - engineRevision, - ]); - expect(result.exitCode, equals(0)); - final manifest = checkedYamlDecode( - result.stdout as String, - (m) => ArtifactsManifest.fromJson(m!), - ); - expect(manifest.artifactOverrides, isNotEmpty); - - for (final pattern in manifest.artifactOverrides) { - final path = pattern.replaceAll(r'$engine', engineRevision); - final request = buildRequest(path); - final response = await handler(request); - expect( - response.statusCode, - isNot(HttpStatus.notFound), - reason: 'Pattern $pattern not handled', - ); - } - }, - onPlatform: {'windows': const Skip('needs bash')}, - ); }); } diff --git a/packages/artifact_proxy/tool/generate_manifest.sh b/packages/artifact_proxy/tool/generate_manifest.sh deleted file mode 100755 index 21fcbf8a..00000000 --- a/packages/artifact_proxy/tool/generate_manifest.sh +++ /dev/null @@ -1,92 +0,0 @@ -#!/bin/bash - -# This script outputs an artifact_manifest.yaml mapping -# a shorebird engine revision to a flutter engine revision. -# Usage: -# ./generate_manifest.sh > artifact_manifest.yaml - -set -e - -# NOTE: If you edit this file you also may need to edit the global list -# of all known artifacts in config.dart - -if [ "$#" -ne 1 ]; then - echo "Usage: ./generate_manifest.sh " - exit 1 -fi - -FLUTTER_ENGINE_REVISION=$1 - -cat <