From 28dac16cb93086238800b7de80eec3cce7d01dd8 Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Fri, 30 Aug 2024 12:14:44 -0500 Subject: [PATCH] feat(shorebird_cli): remove link % from patch summary (#2458) --- .../shorebird_cli/lib/src/commands/patch/patch_command.dart | 2 -- packages/shorebird_cli/lib/src/commands/patch/patcher.dart | 6 ------ .../test/src/commands/patch/patch_command_test.dart | 1 - 3 files changed, 9 deletions(-) diff --git a/packages/shorebird_cli/lib/src/commands/patch/patch_command.dart b/packages/shorebird_cli/lib/src/commands/patch/patch_command.dart index fedd7bbf..e08093bc 100644 --- a/packages/shorebird_cli/lib/src/commands/patch/patch_command.dart +++ b/packages/shorebird_cli/lib/src/commands/patch/patch_command.dart @@ -424,8 +424,6 @@ Please re-run the release command for this version or create a new release.'''); '🟠 Track: ${lightCyan.wrap('Staging')}' else 'đŸŸĸ Track: ${lightCyan.wrap('Production')}', - if (patcher.linkPercentage != null) - '''🔗 Running ${lightCyan.wrap('${patcher.linkPercentage!.toStringAsFixed(1)}%')} on CPU''', if (patcher.linkPercentage != null && patcher.linkPercentage! < Patcher.minLinkPercentage) '''🔍 Debug Info: ${lightCyan.wrap(patcher.debugInfoFile.path)}''', diff --git a/packages/shorebird_cli/lib/src/commands/patch/patcher.dart b/packages/shorebird_cli/lib/src/commands/patch/patcher.dart index 94ea017a..081ef8ea 100644 --- a/packages/shorebird_cli/lib/src/commands/patch/patcher.dart +++ b/packages/shorebird_cli/lib/src/commands/patch/patcher.dart @@ -29,12 +29,6 @@ abstract class Patcher { }); // Link percentage that is considered the minimum before a user might notice. - // Our early testing has shown that about: - // - 1/3rd of patches link at 99% - // - 1/3rd of patches link between 20% and 99% - // - 1/3rd of patches link below 20% - // Most lowering is likely due to: - // https://github.com/shorebirdtech/shorebird/issues/1825 static const double minLinkPercentage = 75; /// The standard link percentage warning. diff --git a/packages/shorebird_cli/test/src/commands/patch/patch_command_test.dart b/packages/shorebird_cli/test/src/commands/patch/patch_command_test.dart index def4b81d..24aab0d4 100644 --- a/packages/shorebird_cli/test/src/commands/patch/patch_command_test.dart +++ b/packages/shorebird_cli/test/src/commands/patch/patch_command_test.dart @@ -522,7 +522,6 @@ void main() { 'đŸ“Ļ Release Version: ${lightCyan.wrap(releaseVersion)}', '''🕹ī¸ Platform: ${lightCyan.wrap(patcher.releaseType.releasePlatform.name)} ${lightCyan.wrap('[arm32 (42 B)]')}''', 'đŸŸĸ Track: ${lightCyan.wrap('Production')}', - '''🔗 Running ${lightCyan.wrap('${patcher.linkPercentage!.toStringAsFixed(1)}%')} on CPU''', '''🔍 Debug Info: ${lightCyan.wrap(patcher.debugInfoFile.path)}''', ]; await expectLater(