From 0cff8fca3c236e48ad0052502e8700d67f946fd4 Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Tue, 15 Apr 2025 14:07:40 -0500 Subject: [PATCH] fix(shorebird_cli): flavor casing (#3052) --- .../shorebird_cli/lib/src/platform/apple.dart | 2 +- .../test/fixtures/xcschemes/Dev.xcscheme | 77 +++++++++++++++++++ .../test/src/platform/apple_test.dart | 6 +- 3 files changed, 81 insertions(+), 4 deletions(-) create mode 100644 packages/shorebird_cli/test/fixtures/xcschemes/Dev.xcscheme diff --git a/packages/shorebird_cli/lib/src/platform/apple.dart b/packages/shorebird_cli/lib/src/platform/apple.dart index 7a54f6c9..a27b2e5a 100644 --- a/packages/shorebird_cli/lib/src/platform/apple.dart +++ b/packages/shorebird_cli/lib/src/platform/apple.dart @@ -205,7 +205,7 @@ class Apple { .where((e) => p.extension(e.path) == '.xcscheme') .where((e) => p.basenameWithoutExtension(e.path) != 'Runner') .whereNot((e) => _isExtensionScheme(schemeFile: e)) - .map((file) => p.basenameWithoutExtension(file.path)) + .map((file) => p.basenameWithoutExtension(file.path).toLowerCase()) .toSet(); } diff --git a/packages/shorebird_cli/test/fixtures/xcschemes/Dev.xcscheme b/packages/shorebird_cli/test/fixtures/xcschemes/Dev.xcscheme new file mode 100644 index 00000000..e3ee8475 --- /dev/null +++ b/packages/shorebird_cli/test/fixtures/xcschemes/Dev.xcscheme @@ -0,0 +1,77 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/packages/shorebird_cli/test/src/platform/apple_test.dart b/packages/shorebird_cli/test/src/platform/apple_test.dart index ba11df69..73c67325 100644 --- a/packages/shorebird_cli/test/src/platform/apple_test.dart +++ b/packages/shorebird_cli/test/src/platform/apple_test.dart @@ -245,7 +245,7 @@ To add macOS, run "flutter create . --platforms macos"'''); runWithOverrides( () => apple.flavors(platform: ApplePlatform.ios), ), - {'internal', 'beta', 'stable'}, + {'internal', 'beta', 'stable', 'dev'}, ); }); }); @@ -264,7 +264,7 @@ To add macOS, run "flutter create . --platforms macos"'''); runWithOverrides( () => apple.flavors(platform: ApplePlatform.ios), ), - {'internal', 'beta', 'stable'}, + {'internal', 'beta', 'stable', 'dev'}, ); }); }); @@ -344,7 +344,7 @@ To add macOS, run "flutter create . --platforms macos"'''); runWithOverrides( () => apple.flavors(platform: ApplePlatform.macos), ), - {'internal', 'beta', 'stable'}, + {'internal', 'beta', 'stable', 'dev'}, ); }); });