From 283bef2a810ca0d2755af2e83b7dfa31816bcff5 Mon Sep 17 00:00:00 2001 From: Tony Date: Fri, 26 Jun 2026 05:50:48 +0800 Subject: [PATCH] Avoid Linux tester build in release artifacts --- .github/workflows/open-shorebird-ci.yml | 20 ++++++++++++++++++-- scripts/verify_ci_workflow.rb | 2 ++ 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/.github/workflows/open-shorebird-ci.yml b/.github/workflows/open-shorebird-ci.yml index 6bd1705..33f132c 100644 --- a/.github/workflows/open-shorebird-ci.yml +++ b/.github/workflows/open-shorebird-ci.yml @@ -801,8 +801,7 @@ jobs: run: | ninja -C out/linux_release_x64 \ flutter/shell/platform/linux:flutter_gtk \ - flutter/build/archives:flutter_patched_sdk \ - flutter/build/archives:artifacts + flutter/build/archives:flutter_patched_sdk - name: Verify Linux engine args run: | @@ -824,6 +823,23 @@ jobs: gtk_zip="$(find "$out/zip_archives" -name 'linux-x64-flutter-gtk.zip' -type f -print -quit)" patched_sdk_zip="$(find "$out/zip_archives" -name 'flutter_patched_sdk_product.zip' -type f -print -quit)" artifacts_zip="$(find "$out/zip_archives" -path '*/linux-x64-release/artifacts.zip' -type f -print -quit)" + if [ -z "$artifacts_zip" ]; then + test -x "$out/gen_snapshot" + artifacts_zip="$out/zip_archives/linux-x64-release/artifacts.zip" + mkdir -p "$(dirname "$artifacts_zip")" + python3 - "$out/gen_snapshot" "$artifacts_zip" <<'PY' + from pathlib import Path + import sys + import zipfile + + source = Path(sys.argv[1]) + output = Path(sys.argv[2]) + info = zipfile.ZipInfo('gen_snapshot') + info.external_attr = (source.stat().st_mode & 0xFFFF) << 16 + with zipfile.ZipFile(output, 'w', zipfile.ZIP_DEFLATED) as archive: + archive.writestr(info, source.read_bytes(), zipfile.ZIP_DEFLATED) + PY + fi test -n "$gtk_zip" test -n "$patched_sdk_zip" test -n "$artifacts_zip" diff --git a/scripts/verify_ci_workflow.rb b/scripts/verify_ci_workflow.rb index d440def..33a9220 100755 --- a/scripts/verify_ci_workflow.rb +++ b/scripts/verify_ci_workflow.rb @@ -2056,6 +2056,8 @@ assert!( run_text_by_job.fetch('linux-engine').include?('shorebird_enable_aot_patching=true') && run_text_by_job.fetch('linux-engine').include?('shorebird_use_interpreter=false') && run_text_by_job.fetch('linux-engine').include?('flutter_prebuilt_dart_sdk=false') && + !run_text_by_job.fetch('linux-engine').include?('flutter/build/archives:artifacts') && + run_text_by_job.fetch('linux-engine').include?("zipfile.ZipInfo('gen_snapshot')") && run_text_by_job.fetch('linux-engine').include?('linux-x64-flutter-gtk.zip') && run_text_by_job.fetch('linux-engine').include?('flutter_patched_sdk_product.zip') && run_text_by_job.fetch('linux-engine').include?('mirror/shorebird/flutter_infra_release/flutter/${engine_revision}/linux-x64-release/artifacts.zip') &&