Lasse R.H. Nielsen
ff5f391c0a
Make API more consistent for a few methods. Reduce the number of language features used in tests: * Never iterating an iterable, always converting it using `.toList()` first and iterating using indices (fx `setEquals`). Also require a `List` in places where an `Iterable` wasn't necessary. * Avoid doing complicated computations that are also used for the error message. Do simple check first, then recompute to get better error messages (fx `allDistinct`). Renamed some rarely used members for consistency (`stringContainsInOrder`->`containsInOrder`, where other string-contains functions just start with `contains`, and `containsOneOf` -> `containsAny` to match `Iterable.any` phrasing, and also it accepts if containing at least one, not precisely one.) Removed a function that wasn't used anywhere. Moved `assertStatementsEnabled` to `variations.dart` as `asserts`. Removed `typeAssertionsEnabled` and `checkedModeEnabled`. The former used in one place, where it was replaced with `checkedImplicitDowncasts` from `variations.dart`, the latter wasn't used anywhere. Deprecates `package:expect/minitest.dart`. It was never intended to be used for new tests, only as a help to convert existing tests written against `package:unit_test`. All existing imports marked as `// ignore: deprecated_member_use`. Change-Id: I07e21d4c0f3ccf11b82ee34af2668fdbb22264d2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352360 Reviewed-by: Slava Egorov <vegorov@google.com> Reviewed-by: Ömer Ağacan <omersa@google.com> Reviewed-by: Nate Bosch <nbosch@google.com> Reviewed-by: Stephen Adams <sra@google.com> Commit-Queue: Lasse Nielsen <lrn@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency