Jens Johansen
a9469269d7
In AOT this makes reading faster: Output from `out/ReleaseX64/dart pkg/front_end/tool/benchmarker.dart --iterations=10 --snapshot=pkg/front_end/test/kernel_binary_bench.aot.1 --snapshot=pkg/front_end/test/kernel_binary_bench.aot.2 --arguments="--warmups=10" --arguments="--iterations=5" --arguments="AstFromBinaryEager" --arguments="out/ReleaseX64/vm_platform_strong.dill"`: ``` msec task-clock:u: -8.6925% +/- 0.5737% (-167.09 +/- 11.03) page-faults:u: 0.1410% +/- 0.0051% (243.00 +/- 8.71) cycles:u: -10.2918% +/- 0.6161% (-732576747.50 +/- 43853449.16) instructions:u: -14.4988% +/- 0.0004% (-1636799813.90 +/- 39902.18) branch-misses:u: -3.4891% +/- 2.1142% (-1166085.00 +/- 706582.35) seconds time elapsed: -8.7005% +/- 0.5634% (-0.17 +/- 0.01) seconds user: -9.9752% +/- 1.5104% (-0.17 +/- 0.03) ``` Stats running manually (run as e.g. `out/ReleaseX64/dart-sdk/bin/dartaotruntime pkg/front_end/test/kernel_binary_bench.aot.1 --warmups=10 --iterations=5 AstFromBinaryEager out/ReleaseX64/vm_platform_strong.dill`): ``` AstFromBinaryEagerCold: -12.5174% +/- 3.10688% AstFromBinaryEagerWarmup: -8.33675% +/- 2.62433% AstFromBinaryEager: -10.3432% +/- 3.68375% ``` I don't expect there to be much of a change (if any) in JIT as the actual type was in practise always Uint8List anyway. TEST=Existing tests. Change-Id: I86b16ed207343848dee2e376f42598c223bbc48f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393740 Reviewed-by: Mayank Patke <fishythefish@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Morgan :) <davidmorgan@google.com> Reviewed-by: Srujan Gaddam <srujzs@google.com> Reviewed-by: Alexander Aprelev <aam@google.com>
89 lines
2.5 KiB
Dart
89 lines
2.5 KiB
Dart
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'dart:io';
|
|
import 'dart:typed_data';
|
|
|
|
import 'package:kernel/binary/ast_from_binary.dart';
|
|
import 'package:kernel/kernel.dart';
|
|
import 'package:kernel/src/tool/find_referenced_libraries.dart';
|
|
|
|
import '../relink_test.dart';
|
|
import 'find_sdk_dills.dart';
|
|
|
|
void main() {
|
|
List<File> dills = findSdkDills();
|
|
print("Found ${dills.length} dills!");
|
|
|
|
for (File dill in dills) {
|
|
readAndRelink(dill);
|
|
}
|
|
}
|
|
|
|
void readAndRelink(File dill) {
|
|
print("Reading $dill");
|
|
Uint8List bytes = dill.readAsBytesSync();
|
|
|
|
try {
|
|
// Loading a component it should be self-contained.
|
|
Component component1 = new Component();
|
|
new BinaryBuilder(bytes,
|
|
alwaysCreateNewNamedNodes: true, disableLazyReading: true)
|
|
.readComponent(component1);
|
|
checkReachable(component1);
|
|
|
|
// Loading a component it should be self-contained.
|
|
Component component2 = new Component(nameRoot: component1.root);
|
|
new BinaryBuilder(bytes,
|
|
alwaysCreateNewNamedNodes: true, disableLazyReading: true)
|
|
.readComponent(component2);
|
|
checkReachable(component2);
|
|
|
|
// Now that we read "component 2" on top of "component 1" the 1-version is
|
|
// no longer self-contained.
|
|
try {
|
|
checkReachable(component1);
|
|
throw "Expected this one to fail.";
|
|
} catch (e) {
|
|
// Expected.
|
|
}
|
|
|
|
// Relinking it it should be back to being self contained though.
|
|
component1.relink();
|
|
checkReachable(component1);
|
|
|
|
// Now that component 1 is relinked component 2 is no longer self contained.
|
|
try {
|
|
checkReachable(component2);
|
|
throw "Expected this one to fail.";
|
|
} catch (e) {
|
|
// Expected.
|
|
}
|
|
|
|
// But relinking makes it self-contained again.
|
|
component2.relink();
|
|
checkReachable(component2);
|
|
} catch (e, st) {
|
|
print("Error for $dill:");
|
|
print(e);
|
|
print(st);
|
|
print("");
|
|
print("--------------------");
|
|
print("");
|
|
exitCode = 1;
|
|
}
|
|
}
|
|
|
|
void checkReachable(Component component) {
|
|
expectReachable(
|
|
findAllReferencedLibraries(component.libraries), component.libraries);
|
|
expectReachable(
|
|
findAllReferencedLibraries(component.libraries,
|
|
collectViaReferencesToo: true),
|
|
component.libraries);
|
|
if (duplicateLibrariesReachable(component.libraries)) {
|
|
throw "Didn't expect duplicates libraries!";
|
|
}
|
|
}
|