dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
Files
fdf4762c9946bf0b239b6ca90c6c8ff8f4cdeaeb
sdk/runtime/bin
T
History
Zichang Guo fdf4762c99 Reland "[dart:io] Fix hanging on zero-length datagram" 
This is a reland of c326c587c5

The fix is to remove "_availableDatagram" check at the start of receive(). Since receive() can be called without receiver being listening, this check will block the receive().

Original change's description:
> [dart:io] Fix hanging on zero-length datagram
>
> This is observed on Win and Linux.
> Here is a doc to explain the problem: https://docs.google.com/document/d/1ZzyBUMrDHLU6vNryjgSMJfUruOdpmTImtE_s2E0J8IQ/edit?usp=sharing.
>
> Bug: https://github.com/dart-lang/sdk/issues/39910
> Change-Id: Ia961239f45615f14108bcd66043ac33d9a0a4abe
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137425
> Commit-Queue: Zichang Guo <zichangguo@google.com>
> Reviewed-by: Siva Annamalai <asiva@google.com>

Bug: https://github.com/dart-lang/sdk/issues/39910
Change-Id: Iefc0af96ed4e1b433396bb5fe11276e8a04c00d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140164
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Zichang Guo <zichangguo@google.com>
2020-03-27 15:28:23 +00:00
..
ffi_test
[vm/ffi] Expose dart_native_api.h symbols via dart:ffi
2020-02-28 18:44:45 +00:00
abi_version_in.cc
Move use_abi_version from vm directory to bin
2019-03-15 22:35:25 +00:00
abi_version.h
Move use_abi_version from vm directory to bin
2019-03-15 22:35:25 +00:00
address_sanitizer.cc
…
BUILD.gn
[VM/NNBD] - Make the null safety flag be isolate specific.
2020-03-20 02:09:29 +00:00
builtin_gen_snapshot.cc
[vm] Remove DART_CHECK_VALID; add check for a current isolate to Dart_PropagateError.
2019-04-02 20:06:19 +00:00
builtin_impl_sources.gni
[BUILD] - Format gn files, this is being done to ensure the unfork CL
2020-03-10 21:56:11 +00:00
builtin_in.cc
…
builtin_natives.cc
[vm] Remove DART_CHECK_VALID; add check for a current isolate to Dart_PropagateError.
2019-04-02 20:06:19 +00:00
builtin_sources.gni
[NNBD/VM] Restructure VM patch files for the NNBD dart sdk split
2019-09-19 03:57:30 +00:00
builtin.cc
[VM/runtime] Remove support for loading URLs through service isolate
2019-12-27 17:30:05 +00:00
builtin.h
[VM/runtime] Remove support for loading URLs through service isolate
2019-12-27 17:30:05 +00:00
cli_impl_sources.gni
…
cli_sources.gni
[NNBD/VM] Restructure VM patch files for the NNBD dart sdk split
2019-09-19 03:57:30 +00:00
cli.cc
…
console_posix.cc
…
console_win.cc
…
console.h
…
crashpad.cc
[build] Remove last platform -> vm and bin -> vm dependencies. Fix some ODR violations.
2019-04-22 20:15:43 +00:00
crashpad.h
[gardening] Integrate Crashpad with run_vm_tests.
2018-10-29 15:11:16 +00:00
crypto_android.cc
[dart:io] Don't leak /dev/urandom fd on fork.
2019-05-15 21:27:19 +00:00
crypto_fuchsia.cc
…
crypto_linux.cc
[dart:io] Don't leak /dev/urandom fd on fork.
2019-05-15 21:27:19 +00:00
crypto_macos.cc
[dart:io] Don't leak /dev/urandom fd on fork.
2019-05-15 21:27:19 +00:00
crypto_test.cc
…
crypto_win.cc
…
crypto.cc
…
crypto.h
…
dart_embedder_api_impl.cc
[vm] Avoid allocating Monitor/Mutex/... with global initializer, use Init()/Cleanup() functions instead
2020-03-17 08:49:52 +00:00
dart_io_api_impl.cc
[vm] Avoid allocating Monitor/Mutex/... with global initializer, use Init()/Cleanup() functions instead
2020-03-17 08:49:52 +00:00
dartdev_utils.cc
[ VM / DartDev ] Disable DartDev for the 2.8 release
2020-03-26 16:50:23 +00:00
dartdev_utils.h
Reland "[ VM / DartDev ] Load and run dartdev snapshot if first argument to dart is not a valid file path"
2020-03-02 22:55:46 +00:00
dartutils.cc
[VM/runtime] Remove support for loading URLs through service isolate
2019-12-27 17:30:05 +00:00
dartutils.h
[VM/runtime] Remove support for loading URLs through service isolate
2019-12-27 17:30:05 +00:00
dfe.cc
[standalone] Fix memory leak in DFE::TryReadFile.
2020-02-28 00:59:53 +00:00
dfe.h
[vm] Use current platform dill file to bootstrap VM
2019-06-26 20:57:46 +00:00
directory_android.cc
[vm] Add macro for fallthrough annotations
2019-02-15 01:12:01 +00:00
directory_fuchsia.cc
[vm] Add macro for fallthrough annotations
2019-02-15 01:12:01 +00:00
directory_linux.cc
[vm] Add macro for fallthrough annotations
2019-02-15 01:12:01 +00:00
directory_macos.cc
[vm] Add macro for fallthrough annotations
2019-02-15 01:12:01 +00:00
directory_test.cc
…
directory_win.cc
Fix issues found compiling with clang on Windows
2020-02-10 22:39:05 +00:00
directory.cc
[build] Remove last platform -> vm and bin -> vm dependencies. Fix some ODR violations.
2019-04-22 20:15:43 +00:00
directory.h
…
elf_loader.cc
Reland "[vm, linux] Try to attach names to all VirtualMemory allocations using memfd."
2019-12-18 18:02:41 +00:00
elf_loader.h
[vm] Improve docs for Dart_LoadELF.
2020-03-09 14:16:47 +00:00
entrypoints_verification_test_extension_dllmain_win.cc
Re-land "[vm] Prevent access to non-annotated members through native API."
2019-01-29 15:10:34 +00:00
entrypoints_verification_test_extension.cc
[VM/nnbd] Remove propagation of library mode to runtime after spec change.
2020-03-03 20:30:32 +00:00
error_exit.cc
[build] Remove last platform -> vm and bin -> vm dependencies. Fix some ODR violations.
2019-04-22 20:15:43 +00:00
error_exit.h
…
eventhandler_android.cc
[vm] not remove port if socket was listening by other isolates
2019-11-06 16:28:12 +00:00
eventhandler_android.h
[VM] Remove retry logic from close(fd) calls
2019-02-15 23:28:17 +00:00
eventhandler_fuchsia.cc
[vm] not remove port if socket was listening by other isolates
2019-11-06 16:28:12 +00:00
eventhandler_fuchsia.h
[vm] Eliminate Mutex/Monitor indirection where possible
2019-05-13 21:17:51 +00:00
eventhandler_linux.cc
[vm] not remove port if socket was listening by other isolates
2019-11-06 16:28:12 +00:00
eventhandler_linux.h
[VM] Remove retry logic from close(fd) calls
2019-02-15 23:28:17 +00:00
eventhandler_macos.cc
[vm] not remove port if socket was listening by other isolates
2019-11-06 16:28:12 +00:00
eventhandler_macos.h
[VM] Remove retry logic from close(fd) calls
2019-02-15 23:28:17 +00:00
eventhandler_test.cc
…
eventhandler_win.cc
Reland "[dart:io] Fix hanging on zero-length datagram"
2020-03-27 15:28:23 +00:00
eventhandler_win.h
Reland "[dart:io] Fix hanging on zero-length datagram"
2020-03-27 15:28:23 +00:00
eventhandler.cc
[eventhandler] generalize socket initialization
2019-10-07 22:10:59 +00:00
eventhandler.h
[vm] not remove port if socket was listening by other isolates
2019-11-06 16:28:12 +00:00
exe_utils.cc
[ VM ] Fix issue where DartDev snapshot would not be found when Dart is installed with Brew
2020-03-17 20:16:25 +00:00
exe_utils.h
Reland "[ VM / DartDev ] Added support for format and pub commands via standalone VM"
2020-02-06 00:04:09 +00:00
extensions_android.cc
[vm/aot] Add a custom ELF loader in dart_precompiled_runtime.
2019-09-24 15:03:19 +00:00
extensions_fuchsia.cc
[vm/aot] Add a custom ELF loader in dart_precompiled_runtime.
2019-09-24 15:03:19 +00:00
extensions_linux.cc
[vm/aot] Add a custom ELF loader in dart_precompiled_runtime.
2019-09-24 15:03:19 +00:00
extensions_macos.cc
[vm/aot] Add a custom ELF loader in dart_precompiled_runtime.
2019-09-24 15:03:19 +00:00
extensions_win.cc
[vm/aot] Add a custom ELF loader in dart_precompiled_runtime.
2019-09-24 15:03:19 +00:00
extensions.cc
…
extensions.h
…
fdutils_android.cc
[VM] Remove retry logic from close(fd) calls
2019-02-15 23:28:17 +00:00
fdutils_fuchsia.cc
…
fdutils_linux.cc
[VM] Remove retry logic from close(fd) calls
2019-02-15 23:28:17 +00:00
fdutils_macos.cc
[VM] Remove retry logic from close(fd) calls
2019-02-15 23:28:17 +00:00
fdutils.h
…
file_android.cc
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
file_fuchsia.cc
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
file_linux.cc
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
file_macos.cc
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
file_support.cc
Reland "Reland "fix hanging of write on Windows""
2020-02-14 17:49:42 +00:00
file_system_watcher_android.cc
…
file_system_watcher_fuchsia.cc
[fuchsia] Fixes for the Fuchsia build
2018-11-26 16:30:33 +00:00
file_system_watcher_linux.cc
[gardening] Migrate most files to be implicit-bool-conversion free
2019-09-05 21:41:42 +00:00
file_system_watcher_macos.cc
[VM] Remove retry logic from close(fd) calls
2019-02-15 23:28:17 +00:00
file_system_watcher_win.cc
[vm/io] Return data right away if it's ready.
2019-09-09 23:16:52 +00:00
file_system_watcher.cc
…
file_system_watcher.h
…
file_test.cc
[gardening] Migrate most files to be implicit-bool-conversion free
2019-09-05 21:41:42 +00:00
file_win.cc
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
file.cc
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
file.h
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
filter.cc
[vm] Integrate dart binary with Crashpad on Windows.
2018-10-24 13:30:16 +00:00
filter.h
…
gen_snapshot.cc
Re-land "[vm] AOT blobs snapshots are obsolete. Remove dead code."
2020-02-17 11:12:15 +00:00
gzip.cc
[vm] Reduce frame size for the functions with the largest frame sizes.
2019-12-11 18:15:27 +00:00
gzip.h
…
hashmap_test.cc
…
ifaddrs-android.cc
[vm] Support ListInterfaces for android
2019-04-19 16:38:44 +00:00
ifaddrs-android.h
[vm] Support ListInterfaces for android
2019-04-19 16:38:44 +00:00
io_buffer.cc
[vm, io] Fix some MemorySanitizer issues.
2020-02-27 17:50:43 +00:00
io_buffer.h
…
io_impl_sources.gni
[BUILD] - Format gn files, this is being done to ensure the unfork CL
2020-03-10 21:56:11 +00:00
io_natives.cc
Reland "[dart:io] Fix hanging on zero-length datagram"
2020-03-27 15:28:23 +00:00
io_natives.h
…
io_service_no_ssl.cc
…
io_service_no_ssl.h
…
io_service.cc
…
io_service.h
…
io_sources.gni
[NNBD/VM] Restructure VM patch files for the NNBD dart sdk split
2019-09-19 03:57:30 +00:00
isolate_data.cc
[VM] More cleanup in the loader code
2019-10-21 17:44:18 +00:00
isolate_data.h
[VM] More cleanup in the loader code
2019-10-21 17:44:18 +00:00
loader.cc
[standalone] Fix memory leak when failing to load a native extension.
2020-02-28 00:57:16 +00:00
loader.h
[VM/Runtime] Propagate error from Loader::InitForSnapshot instead of asserting
2020-01-02 23:00:36 +00:00
lockers.h
…
main_options.cc
[ VM ] Fix issue where DartDev snapshot would not be found when Dart is installed with Brew
2020-03-17 20:16:25 +00:00
main_options.h
[vmservice] allow fallback on port bind failure
2020-01-28 23:36:14 +00:00
main.cc
[vm] Avoid allocating Monitor/Mutex/... with global initializer, use Init()/Cleanup() functions instead
2020-03-17 08:49:52 +00:00
namespace_android.cc
…
namespace_fuchsia.cc
[dart:io,fuchsia] Change namespace setup failure from ASSERTs to FATALs
2019-05-28 19:12:35 +00:00
namespace_fuchsia.h
[dart:io,fuchsia] Pass Isolate namespace to child process. Fix double free.
2019-01-15 22:07:51 +00:00
namespace_linux.cc
…
namespace_macos.cc
…
namespace_win.cc
…
namespace.cc
Add various missing argument checks to dart:io natives.
2019-08-01 23:32:40 +00:00
namespace.h
[build] Remove last platform -> vm and bin -> vm dependencies. Fix some ODR violations.
2019-04-22 20:15:43 +00:00
observatory_assets_empty.cc
[vm] Cleanup C99 header includes
2019-07-03 10:54:24 +00:00
options.cc
[build] Remove last platform -> vm and bin -> vm dependencies. Fix some ODR violations.
2019-04-22 20:15:43 +00:00
options.h
[build] Remove last platform -> vm and bin -> vm dependencies. Fix some ODR violations.
2019-04-22 20:15:43 +00:00
platform_android.cc
Revert "[ VM ] Update embedding API to perform Platform initialization"
2019-09-24 20:43:20 +00:00
platform_fuchsia.cc
Revert "[ VM ] Update embedding API to perform Platform initialization"
2019-09-24 20:43:20 +00:00
platform_linux.cc
Revert "[ VM ] Update embedding API to perform Platform initialization"
2019-09-24 20:43:20 +00:00
platform_macos.cc
[SDK] Fixes loading appended snapshots when executed with PATH.
2019-10-18 10:30:48 +00:00
platform_win.cc
[SDK] Fixes loading appended snapshots when executed with PATH.
2019-10-18 10:30:48 +00:00
platform.cc
…
platform.h
[SDK] Fixes loading appended snapshots when executed with PATH.
2019-10-18 10:30:48 +00:00
process_android.cc
[vm] Avoid allocating Monitor/Mutex/... with global initializer, use Init()/Cleanup() functions instead
2020-03-17 08:49:52 +00:00
process_fuchsia.cc
[vm] Follow-up changes to process_fuchsia.cc
2020-03-17 18:26:50 +00:00
process_linux.cc
[vm] Avoid allocating Monitor/Mutex/... with global initializer, use Init()/Cleanup() functions instead
2020-03-17 08:49:52 +00:00
process_macos.cc
[vm] Avoid allocating Monitor/Mutex/... with global initializer, use Init()/Cleanup() functions instead
2020-03-17 08:49:52 +00:00
process_test.cc
…
process_win.cc
[vm] Avoid allocating Monitor/Mutex/... with global initializer, use Init()/Cleanup() functions instead
2020-03-17 08:49:52 +00:00
process.cc
[vm] not remove port if socket was listening by other isolates
2019-11-06 16:28:12 +00:00
process.h
[vm] Avoid allocating Monitor/Mutex/... with global initializer, use Init()/Cleanup() functions instead
2020-03-17 08:49:52 +00:00
reference_counting.h
[vm] Fix TSAN failures related to object headers and GC task phases.
2019-10-09 21:48:20 +00:00
root_certificates_unsupported.cc
…
run_vm_tests.cc
[vm] Avoid allocating Monitor/Mutex/... with global initializer, use Init()/Cleanup() functions instead
2020-03-17 08:49:52 +00:00
secure_socket_filter.cc
[vm] Avoid allocating Monitor/Mutex/... with global initializer, use Init()/Cleanup() functions instead
2020-03-17 08:49:52 +00:00
secure_socket_filter.h
[vm] Avoid allocating Monitor/Mutex/... with global initializer, use Init()/Cleanup() functions instead
2020-03-17 08:49:52 +00:00
secure_socket_unsupported.cc
…
secure_socket_utils.cc
[gardening] Migrate most files to be implicit-bool-conversion free
2019-09-05 21:41:42 +00:00
secure_socket_utils.h
Reland "Update BoringSSL to 4dfd5af70191b068aebe567b8e29ce108cee85ce."
2019-10-23 18:08:16 +00:00
security_context_android.cc
[build] Remove last platform -> vm and bin -> vm dependencies. Fix some ODR violations.
2019-04-22 20:15:43 +00:00
security_context_fuchsia.cc
[build] Remove last platform -> vm and bin -> vm dependencies. Fix some ODR violations.
2019-04-22 20:15:43 +00:00
security_context_linux.cc
[build] Remove last platform -> vm and bin -> vm dependencies. Fix some ODR violations.
2019-04-22 20:15:43 +00:00
security_context_macos.cc
[ VM / dart:io ] Replace usage of SecTrustEvaluate with SecTrustEvaluateWithError on MacOS >= 10.14
2019-10-31 22:17:17 +00:00
security_context_win.cc
[build] Remove last platform -> vm and bin -> vm dependencies. Fix some ODR violations.
2019-04-22 20:15:43 +00:00
security_context.cc
Reland "Update BoringSSL to 4dfd5af70191b068aebe567b8e29ce108cee85ce."
2019-10-23 18:08:16 +00:00
security_context.h
…
snapshot_empty.cc
[vm] Cleanup C99 header includes
2019-07-03 10:54:24 +00:00
snapshot_in.cc
[vm] Cleanup C99 header includes
2019-07-03 10:54:24 +00:00
snapshot_utils.cc
Re-land "[vm] AOT blobs snapshots are obsolete. Remove dead code."
2020-02-17 11:12:15 +00:00
snapshot_utils.h
Re-land "[vm] AOT blobs snapshots are obsolete. Remove dead code."
2020-02-17 11:12:15 +00:00
socket_android.cc
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
socket_base_android.cc
Reland "[dart:io] Fix hanging on zero-length datagram"
2020-03-27 15:28:23 +00:00
socket_base_android.h
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
socket_base_fuchsia.cc
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
socket_base_fuchsia.h
[dart:io] Fix Unix domain socket headers for Fuchsia
2020-03-23 20:35:47 +00:00
socket_base_linux.cc
Reland "[dart:io] Fix hanging on zero-length datagram"
2020-03-27 15:28:23 +00:00
socket_base_linux.h
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
socket_base_macos.cc
Reland "[dart:io] Fix hanging on zero-length datagram"
2020-03-27 15:28:23 +00:00
socket_base_macos.h
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
socket_base_win.cc
Reland "[dart:io] Fix hanging on zero-length datagram"
2020-03-27 15:28:23 +00:00
socket_base_win.h
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
socket_base.cc
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
socket_base.h
Reland "[dart:io] Fix hanging on zero-length datagram"
2020-03-27 15:28:23 +00:00
socket_fuchsia.cc
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
socket_linux.cc
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
socket_macos.cc
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
socket_win.cc
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
socket.cc
Reland "[dart:io] Fix hanging on zero-length datagram"
2020-03-27 15:28:23 +00:00
socket.h
fix Unix domain socket test failure
2020-03-25 05:01:10 +00:00
stdio_android.cc
…
stdio_fuchsia.cc
[fuchsia] Fixes for the Fuchsia build
2018-11-26 16:30:33 +00:00
stdio_linux.cc
[gardening] Migrate most files to be implicit-bool-conversion free
2019-09-05 21:41:42 +00:00
stdio_macos.cc
…
stdio_win.cc
…
stdio.cc
…
stdio.h
…
sync_socket_android.cc
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
sync_socket_fuchsia.cc
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
sync_socket_linux.cc
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
sync_socket_macos.cc
[dart:io] support Unix domain communications
2020-03-23 03:51:40 +00:00
sync_socket_win.cc
…
sync_socket.cc
Add various missing argument checks to dart:io natives.
2019-08-01 23:32:40 +00:00
sync_socket.h
…
test_extension_dllmain_win.cc
…
test_extension.c
…
thread_android.cc
[vm, arm64] Adjust CSP during the invocation stub instead of each function prologue.
2019-10-25 19:21:56 +00:00
thread_android.h
…
thread_fuchsia.cc
[standalone] Name dart:io threads, take 2.
2019-02-13 20:29:46 +00:00
thread_fuchsia.h
…
thread_linux.cc
[standalone] Name dart:io threads, take 2.
2019-02-13 20:29:46 +00:00
thread_linux.h
…
thread_macos.cc
[standalone] Name dart:io threads, take 2.
2019-02-13 20:29:46 +00:00
thread_macos.h
…
thread_win.cc
[ VM / Windows ] Removed call to SetThreadDescription which is only supported in new Win 10 builds
2019-02-26 01:00:26 +00:00
thread_win.h
[vm] Update Windows synchronization code to CONDITION_VARIABLEs and SRWLOCKs.
2018-11-09 18:44:49 +00:00
thread.h
[standalone] Name dart:io threads, take 2.
2019-02-13 20:29:46 +00:00
typed_data_utils.cc
…
typed_data_utils.h
…
utils_android.cc
…
utils_fuchsia.cc
[fuchsia] Migrate to zx_clock_get_new
2019-05-10 18:22:28 +00:00
utils_linux.cc
…
utils_macos.cc
…
utils_win.cc
[build] Remove last platform -> vm and bin -> vm dependencies. Fix some ODR violations.
2019-04-22 20:15:43 +00:00
utils_win.h
…
utils.h
…
vmservice_impl.cc
[vmservice] allow fallback on port bind failure
2020-01-28 23:36:14 +00:00
vmservice_impl.h
[vmservice] allow fallback on port bind failure
2020-01-28 23:36:14 +00:00