Paul Berry
f9c45af689
The spec uses the terms "upwards" vs "downwards" inference to refer to whether type constraints come from a return type or parameter types. Previous to this change the code used the terms "upwards" vs "partial" inference to refer to whether the types being chosen were preliminary (and hence might contain `?`s) or were the final inferred types. This led to confusion; for example the method `downwardInferObjectPatternRequiredType` was calling `upwardsInfer`. This change adjusts the nomenclature so that the methods that choose types are called `choosePreliminaryTypes` and `chooseFinalTypes`, to avoid any confusion with the direction of inference. See discussion here: https://dart-review.googlesource.com/c/sdk/+/290613/comment/894a767c_e269584e/. Change-Id: Ie05dcae027ca82b2ce7e5a57f1846412d5b32d50 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290901 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Chloe Stefantsova <cstefantsova@google.com> Commit-Queue: Paul Berry <paulberry@google.com>