Emmanuel Pellereau
d0556f9c27
This reverts commit608934e330. Reason for revert: breaks google3. See b/274843808. Original change's description: > Reland "Add class modifiers to `dart:convert`." > > This is a reland of commitb2f4cf3e01> > Commented out deprecation for now. > > Original change's description: > > Add class modifiers to `dart:convert`. > > > > The usual approach: > > Pure interfaces marked `interface`. > > Pure implementation classes marked `final`. > > Base classes marked `base` or nothing, and `mixin class` if reasonable. > > Combined X/XBase/XMixin where possible. > > > > CoreLibraryReviewExempt: Aske is away > > Change-Id: I927f9bd488fb385ff9c17c8fc94920a1f5076347 > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289200 > > Reviewed-by: Stephen Adams <sra@google.com> > > Reviewed-by: Slava Egorov <vegorov@google.com> > > Reviewed-by: Nate Bosch <nbosch@google.com> > > Commit-Queue: Lasse Nielsen <lrn@google.com> > > CoreLibraryReviewExempt: Approved in original. > Change-Id: I1bc14f99b742567e2634dcfcbc52f332dbcc5364 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290521 > Reviewed-by: Nate Bosch <nbosch@google.com> > Commit-Queue: Lasse Nielsen <lrn@google.com> Change-Id: Ie438531e9b97658c86e242fabddbb8a2919f634b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290763 Reviewed-by: Alexander Thomas <athom@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Oleh Prypin <oprypin@google.com> Commit-Queue: Emmanuel Pellereau <emmanuelp@google.com>
Analysis Server Benchmarks
How to run the benchmarks
To see a list of all available benchmarks, run:
dart benchmark/benchmarks.dart list
To run an individual benchmark, run:
dart benchmark/benchmarks.dart run <benchmark-id>
How they're tested
In order to make sure that our benchmarks don't regress in terms of their ability to run, we create one unit test per benchmark, and run those tests as part of our normal CI test suite.
To save time on the CI, we only run one iteration of each benchmark
(--repeat=1), and we run the benchmark on a smaller data set (--quick).
See test/benchmark_test.dart.
To add a new benchmark
Register the new benchmark in the main() method of benchmark/benchmarks.dart.
On the bots
Our benchmarks run on a continuous performance testing system. Currently, the benchmarks need to be manually registered ahead of time.