Jens Johansen
fb3f2633ba
* document_ignores read each file once * lines_longer_than_80_chars read each file for every line > 80 chars (!). This follows the approach in https://dart-review.googlesource.com/c/sdk/+/401424 where the same pattern was identified as bad. Before this CL, if a file had, say, 1000 lines > 80 chars (and having the lint enabled), the lint would read the file - from disk - 1000 times. A somewhat saving grace is that for open files - which I guess is where it's normally run a lot - it normally reads from an overlay file and thus not from disk. Except if you are editing a part in which case the open part is an overlay, but the "parent" (which is for whatever reason also linted) is read from file. So if you have 1000 lines > 80 chars in the "parent" file, and is typing in a part file you're in for a really bad time. This CL should reduce the number of reads in the lint to 0. Change-Id: Iac6c78f50add1bc7a411c0c244a181f5ca2ea25b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411300 Reviewed-by: Samuel Rawlins <srawlins@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency