Clement Skau
12a5c93d4a
This reverts commit1bf25798fa. Reason for revert: Rolling back as it breaks more external targets and is currently blocking rolls. Original change's description: > Reland "[VM] Remove unnecessary Closure.clone() from sync*." > > This reverts commit430c75b5fa. > > Reason for revert: We probably don't care about the dartkb breakages. > > Original change's description: > > Revert "[VM] Remove unnecessary Closure.clone() from sync*." > > > > This reverts commitca94ad7112. > > > > Reason for revert: Appears to break dartkb. > > > > Original change's description: > > > [VM] Remove unnecessary Closure.clone() from sync*. > > > > > > Instead, this CL wraps sync*'s sync_op in an additional function > > > that captures local copies of the necessary closure state. > > > Notably this state includes the parameters of the original sync* function > > > as these also need to be cloned for each instance. > > > > > > > > > Note: a large number of .expect files have a small number of changes > > > due to the additional wrapper function, as well as some extra plumbing. > > > > > > Bug: https://github.com/dart-lang/sdk/issues/37753 > > > Change-Id: If099dbfe9e5d62979626b852386fd0173fc76de5 > > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136190 > > > Commit-Queue: Clement Skau <cskau@google.com> > > > Reviewed-by: Vyacheslav Egorov <vegorov@google.com> > > > > TBR=vegorov@google.com,cskau@google.com > > > > Change-Id: I89e517196f03622337f909f0fcecbdc77c9dda93 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: https://github.com/dart-lang/sdk/issues/37753 > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144920 > > Reviewed-by: Clement Skau <cskau@google.com> > > Commit-Queue: Clement Skau <cskau@google.com> > > TBR=vegorov@google.com,cskau@google.com > > Change-Id: I78589c83cbb17151ca4ab8f811b4f18f252fb9c1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: https://github.com/dart-lang/sdk/issues/37753 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144921 > Reviewed-by: Clement Skau <cskau@google.com> > Commit-Queue: Clement Skau <cskau@google.com> TBR=vegorov@google.com,cskau@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: https://github.com/dart-lang/sdk/issues/37753 Change-Id: I879df17bd282d01468fa010b94a8c89afdb8cd0d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145361 Reviewed-by: Clement Skau <cskau@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Clement Skau <cskau@google.com>