Tess Strickland
fa03ee7782
Generally, methods that take a *TextBuffer pointer do not care how the internal buffer is allocated, and so they could be used for either if both were subclasses of a base class that contained the printing methods. This CL makes that base class, and now TextBuffer and ZoneTextBuffer now share the exact same set of methods for printing to the internal buffer. Since the base class is in platform, this does mean dropping the overload of AddString for Dart String objects that was part of ZoneTextBuffer. Instead, this CL just adds an intermediate call to ToCString() for the small number of callers that used the overload, keeping the printing interface the same for both. In addition, one use of TextBuffer that then re-allocated the buffer contents into the zone manually has been replaced with a ZoneTextBuffer instead. Change-Id: I438a085e7e20d55d93987fd7f36afd636f95955f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157741 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Tess Strickland <sstrickl@google.com>
42 lines
1.2 KiB
C++
42 lines
1.2 KiB
C++
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "vm/zone_text_buffer.h"
|
|
|
|
#include "platform/assert.h"
|
|
#include "platform/globals.h"
|
|
#include "platform/utils.h"
|
|
#include "vm/object.h"
|
|
#include "vm/os.h"
|
|
#include "vm/zone.h"
|
|
|
|
namespace dart {
|
|
|
|
ZoneTextBuffer::ZoneTextBuffer(Zone* zone, intptr_t initial_capacity)
|
|
: zone_(zone) {
|
|
ASSERT(initial_capacity > 0);
|
|
buffer_ = reinterpret_cast<char*>(zone->Alloc<char>(initial_capacity));
|
|
capacity_ = initial_capacity;
|
|
buffer_[length_] = '\0';
|
|
}
|
|
|
|
void ZoneTextBuffer::Clear() {
|
|
const intptr_t initial_capacity = 64;
|
|
buffer_ = reinterpret_cast<char*>(zone_->Alloc<char>(initial_capacity));
|
|
capacity_ = initial_capacity;
|
|
length_ = 0;
|
|
buffer_[length_] = '\0';
|
|
}
|
|
|
|
void ZoneTextBuffer::EnsureCapacity(intptr_t len) {
|
|
intptr_t remaining = capacity_ - length_;
|
|
if (remaining <= len) {
|
|
intptr_t new_capacity = capacity_ + Utils::Maximum(capacity_, len);
|
|
buffer_ = zone_->Realloc<char>(buffer_, capacity_, new_capacity);
|
|
capacity_ = new_capacity;
|
|
}
|
|
}
|
|
|
|
} // namespace dart
|