Daco Harkes
f98a2138b7
When uploading CLs, the presubmit checks verify that the lines in the diff are formatted correctly according to `git cl format runtime`. However, when `buildtools/<os>-<arch>/clang/bin/clang-format` is updated, it does not force reformatting of files that would be reformatted. This leads to two issues: * Inconsistent style within the code base and within a single file. * Spurious reformatting in CLs when (1) clang-format is used on the whole file, or (2) the diff lines overlap. `clang-format` doesn't change that frequently, so in general this is not a large issue, but I've seen a bit too many "spurious formatting, please revert" comments on CLs recently. This CL formats the runtime to be in line with the current pinned `clang-format`: ``` $ find runtime/ -iname *.h -o -iname *.cc | xargs buildtools/mac-arm64/clang/bin/clang-format -i ``` `git cl format` (which only formats changed lines, and does so with `clang-format`) seems to not agree with itself, or clang-format, or cpplint in a handful of places. This CL adds `// clang-format off` for these. (See previous patchsets for the specific instances.) TEST=A variety of bots including GCC, MacOS and Windows. Change-Id: I470892e898971899fda14bb3b8f2c8efefd67686 Cq-Include-Trybots: luci.dart.try:vm-gcc-linux-try,vm-ffi-qemu-linux-release-riscv64-try,vm-ffi-qemu-linux-release-arm-try,vm-aot-win-debug-x64-try,vm-win-debug-x64c-try,vm-mac-debug-x64-try,vm-mac-debug-arm64-try,vm-aot-linux-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362780 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com>
60 lines
1.7 KiB
C++
60 lines
1.7 KiB
C++
// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#ifndef RUNTIME_PLATFORM_ALLOCATION_H_
|
|
#define RUNTIME_PLATFORM_ALLOCATION_H_
|
|
|
|
#include "platform/address_sanitizer.h"
|
|
#include "platform/assert.h"
|
|
|
|
namespace dart {
|
|
|
|
void* calloc(size_t n, size_t size);
|
|
void* malloc(size_t size);
|
|
void* realloc(void* ptr, size_t size);
|
|
|
|
// Stack allocated objects subclass from this base class. Objects of this type
|
|
// cannot be allocated on either the C or object heaps. Destructors for objects
|
|
// of this type will not be run unless the stack is unwound through normal
|
|
// program control flow.
|
|
class ValueObject {
|
|
public:
|
|
ValueObject() {}
|
|
~ValueObject() {}
|
|
|
|
private:
|
|
DISALLOW_ALLOCATION();
|
|
DISALLOW_COPY_AND_ASSIGN(ValueObject);
|
|
};
|
|
|
|
// Static allocated classes only contain static members and can never
|
|
// be instantiated in the heap or on the stack.
|
|
class AllStatic {
|
|
private:
|
|
DISALLOW_ALLOCATION();
|
|
DISALLOW_IMPLICIT_CONSTRUCTORS(AllStatic);
|
|
};
|
|
|
|
class MallocAllocated {
|
|
public:
|
|
MallocAllocated() {}
|
|
|
|
// Intercept operator new to produce clearer error messages when we run out
|
|
// of memory. Don't do this when running under ASAN so it can continue to
|
|
// check malloc/new/new[] are paired with free/delete/delete[] respectively.
|
|
#if !defined(USING_ADDRESS_SANITIZER)
|
|
void* operator new(size_t size) { return dart::malloc(size); }
|
|
|
|
void* operator new[](size_t size) { return dart::malloc(size); }
|
|
|
|
void operator delete(void* pointer) { ::free(pointer); }
|
|
|
|
void operator delete[](void* pointer) { ::free(pointer); }
|
|
#endif
|
|
};
|
|
|
|
} // namespace dart
|
|
|
|
#endif // RUNTIME_PLATFORM_ALLOCATION_H_
|